Skip to content

Commit da34af1

Browse files
committed
feat(CONTRIBUTING.md): update CONTRIBUTING.md
1. update image links 2. modify log level
1 parent aeb108e commit da34af1

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,12 @@ If you want to contribute codes to java-tron, please follow the following steps:
103103
104104
Submit a pull request (PR) from your repository to `tronprotocol/java-tron`.
105105
Please be sure to click on the link in the red box shown below. Select the base branch for tronprotocol and the compare branch for your personal fork repository.
106-
![](https://codimd.s3.shivering-isles.com/demo/uploads/e24435ab42e4287d9369a2136.png)
106+
![image](https://raw.githubusercontent.com/tronprotocol/documentation-en/master/images/javatron_pr.png)
107107
108108
109109
110110
## Code Review Guidelines
111-
The only way to get code into java-tron is to send a pull request. Those pull requests need to be reviewed by someone. there a guide that explains our expectations around PRs for both authors and reviewers.
111+
The only way to get code into java-tron is to send a pull request. Those pull requests need to be reviewed by someone. The following guide explains our expectations around PRs for both authors and reviewers.
112112
113113
### Terminology
114114
- The author of a pull request is the entity who wrote the diff and submitted it to GitHub.

framework/src/main/java/org/tron/core/Wallet.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ public long getTransactionCountByBlockNum(long blockNum) {
687687
Block block = chainBaseManager.getBlockByNum(blockNum).getInstance();
688688
count = block.getTransactionsCount();
689689
} catch (StoreException e) {
690-
logger.error(e.getMessage());
690+
logger.warn(e.getMessage());
691691
}
692692

693693
return count;
@@ -1414,7 +1414,7 @@ public Block getBlockById(ByteString blockId) {
14141414
try {
14151415
block = chainBaseManager.getBlockStore().get(blockId.toByteArray()).getInstance();
14161416
} catch (StoreException e) {
1417-
logger.error(e.getMessage());
1417+
logger.warn(e.getMessage());
14181418
}
14191419
return block;
14201420
}

0 commit comments

Comments
 (0)