Merge pull request #5121 from halibobo1205/feature/log_opt

refactor(log): downgrade certain log level in some files

Author: halibobo1205

chainbase/src/main/java/org/tron/core/capsule/TransactionCapsule.java

@@ -333,13 +333,13 @@ public static byte[] getOwner(Transaction.Contract contract) {
           Class<? extends GeneratedMessageV3> clazz = TransactionFactory
               .getContract(contract.getType());
           if (clazz == null) {
-            logger.error("not exist {}", contract.getType());
+            logger.warn("not exist {}", contract.getType());
             return new byte[0];
           }
           GeneratedMessageV3 generatedMessageV3 = contractParameter.unpack(clazz);
           owner = ReflectUtils.getFieldValue(generatedMessageV3, OWNER_ADDRESS);
           if (owner == null) {
-            logger.error("not exist [{}] field,{}", OWNER_ADDRESS, clazz);
+            logger.warn("not exist [{}] field,{}", OWNER_ADDRESS, clazz);
             return new byte[0];
           }
           break;

framework/src/main/java/org/tron/core/Wallet.java

@@ -110,6 +110,7 @@
 import org.tron.common.utils.ByteUtil;
 import org.tron.common.utils.DecodeUtil;
 import org.tron.common.utils.Sha256Hash;
+import org.tron.common.utils.StringUtil;
 import org.tron.common.utils.Utils;
 import org.tron.common.utils.WalletUtil;
 import org.tron.common.zksnark.IncrementalMerkleTreeContainer;
@@ -583,7 +584,7 @@ public GrpcAPI.Return broadcastTransaction(Transaction signedTransaction) {
           .setMessage(ByteString.copyFromUtf8("Transaction expired"))
           .build();
     } catch (Exception e) {
-      logger.error(BROADCAST_TRANS_FAILED, txID, e.getMessage());
+      logger.warn("Broadcast transaction {} failed", txID, e);
       return builder.setResult(false).setCode(response_code.OTHER_ERROR)
           .setMessage(ByteString.copyFromUtf8("Error: " + e.getMessage()))
           .build();
@@ -1708,7 +1709,7 @@ public Proposal getProposalById(ByteString proposalId) {
       proposalCapsule = chainBaseManager.getProposalStore()
           .get(proposalId.toByteArray());
     } catch (StoreException e) {
-      logger.error(e.getMessage());
+      logger.warn(e.getMessage());
     }
     if (proposalCapsule != null) {
       return proposalCapsule.getInstance();
@@ -2626,7 +2627,7 @@ public TransactionInfoList getTransactionInfoByBlockNum(long blockNum) {
         }
       }
     } catch (BadItemException | ItemNotFoundException e) {
-      logger.error(e.getMessage());
+      logger.warn(e.getMessage());
     }
 
     return transactionInfoList.build();
@@ -2658,7 +2659,7 @@ public MarketOrder getMarketOrderById(ByteString orderId) {
     try {
       return marketOrderStore.get(orderId.toByteArray()).getInstance();
     } catch (ItemNotFoundException e) {
-      logger.error("orderId = " + orderId.toString() + " not found");
+      logger.warn("orderId = {} not found", orderId);
       throw new IllegalStateException("order not found in store");
     }
 
@@ -2694,7 +2695,7 @@ public MarketOrderList getMarketOrderByAccount(ByteString accountAddress) {
             marketOrderListBuilder
                 .addOrders(orderCapsule.getInstance());
           } catch (ItemNotFoundException e) {
-            logger.error("orderId = " + orderId.toString() + " not found");
+            logger.warn("orderId = {} not found", orderId);
             throw new IllegalStateException("order not found in store");
           }
         }
@@ -3061,9 +3062,9 @@ public SmartContract getContract(GrpcAPI.BytesMessage bytesMessage) {
     byte[] address = bytesMessage.getValue().toByteArray();
     AccountCapsule accountCapsule = chainBaseManager.getAccountStore().get(address);
     if (accountCapsule == null) {
-      logger.error(
-          "Get contract failed, the account does not exist or the account "
-              + "does not have a code hash!");
+      logger.warn(
+          "Get contract failed, the account {} does not exist or the account "
+              + "does not have a code hash!", StringUtil.encode58Check(address));
       return null;
     }
 
@@ -3090,9 +3091,9 @@ public SmartContractDataWrapper getContractInfo(GrpcAPI.BytesMessage bytesMessag
     byte[] address = bytesMessage.getValue().toByteArray();
     AccountCapsule accountCapsule = chainBaseManager.getAccountStore().get(address);
     if (accountCapsule == null) {
-      logger.error(
-          "Get contract failed, the account does not exist or the account does not have a code "
-              + "hash!");
+      logger.warn(
+          "Get contract failed, the account {} does not exist or the account does not have a code "
+              + "hash!", StringUtil.encode58Check(address));
       return null;
     }
 

framework/src/main/java/org/tron/core/db/Manager.java

@@ -1609,7 +1609,7 @@ public BlockCapsule generateBlock(Miner miner, long blockTime, long timeout) {
         toBePacked.add(trx);
         currentSize += trxPackSize;
       } catch (Exception e) {
-        logger.error("Process trx {} failed when generating block {}, {}.", trx.getTransactionId(),
+        logger.warn("Process trx {} failed when generating block {}, {}.", trx.getTransactionId(),
             blockCapsule.getNum(), e.getMessage());
       }
     }

framework/src/main/java/org/tron/core/services/http/Util.java

@@ -303,7 +303,7 @@ public static Transaction packTransaction(String strTransaction, boolean selfTyp
       } catch (JSONException e) {
         logger.debug("JSONException: {}", e.getMessage());
       } catch (Exception e) {
-        logger.error("", e);
+        logger.warn("{}", contractType, e);
       }
     }
     rawData.put("contract", contracts);

framework/src/main/java/org/tron/core/services/jsonrpc/JsonRpcApiUtil.java

@@ -338,7 +338,7 @@ public static long getAmountFromTransactionInfo(String hash, ContractType contra
             break;
         }
       } else {
-        logger.error("Can't find transaction {} ", hash);
+        logger.warn("Can't find transaction {} ", hash);
       }
     } catch (Exception e) {
       logger.warn("Exception happens when get amount from transactionInfo. Exception = [{}]",