Merge pull request #4792 from halibobo1205/feat/trx_hash_get_opt

feat(db): improve performance for getting transaction hash

Author: halibobo1205

chainbase/src/main/java/org/tron/core/capsule/TransactionCapsule.java

@@ -106,6 +106,7 @@ public class TransactionCapsule implements ProtoCapsule<Transaction> {
   @Setter
   private long order;
   private byte[] ownerAddress;
+  private Sha256Hash id;
 
   public byte[] getOwnerAddress() {
     if (this.ownerAddress == null) {
@@ -488,7 +489,7 @@ public void setReference(long blockNum, byte[] blockHash) {
         .setRefBlockHash(ByteString.copyFrom(ByteArray.subArray(blockHash, 8, 16)))
         .setRefBlockBytes(ByteString.copyFrom(ByteArray.subArray(refBlockNum, 6, 8)))
         .build();
-    this.transaction = this.transaction.toBuilder().setRawData(rawData).build();
+    setRawData(rawData);
   }
 
   public long getExpiration() {
@@ -501,21 +502,21 @@ public long getExpiration() {
   public void setExpiration(long expiration) {
     Transaction.raw rawData = this.transaction.getRawData().toBuilder().setExpiration(expiration)
         .build();
-    this.transaction = this.transaction.toBuilder().setRawData(rawData).build();
+    setRawData(rawData);
   }
 
   public void setTimestamp() {
     Transaction.raw rawData = this.transaction.getRawData().toBuilder()
         .setTimestamp(System.currentTimeMillis())
         .build();
-    this.transaction = this.transaction.toBuilder().setRawData(rawData).build();
+    setRawData(rawData);
   }
 
   public void setTimestamp(long timestamp) {
     Transaction.raw rawData = this.transaction.getRawData().toBuilder()
         .setTimestamp(timestamp)
         .build();
-    this.transaction = this.transaction.toBuilder().setRawData(rawData).build();
+    setRawData(rawData);
   }
 
   public long getTimestamp() {
@@ -545,7 +546,7 @@ public void sign(byte[] privateKey) {
     SignInterface cryptoEngine = SignUtils
         .fromPrivate(privateKey, CommonParameter.getInstance().isECKeyCryptoEngine());
     ByteString sig = ByteString.copyFrom(cryptoEngine.Base64toBytes(cryptoEngine
-        .signHash(getRawHash().getBytes())));
+        .signHash(getTransactionId().getBytes())));
     this.transaction = this.transaction.toBuilder().addSignature(sig).build();
   }
 
@@ -568,7 +569,8 @@ public void addSign(byte[] privateKey, AccountStore accountStore)
         .fromPrivate(privateKey, CommonParameter.getInstance().isECKeyCryptoEngine());
     byte[] address = cryptoEngine.getAddress();
     if (this.transaction.getSignatureCount() > 0) {
-      checkWeight(permission, this.transaction.getSignatureList(), this.getRawHash().getBytes(),
+      checkWeight(permission, this.transaction.getSignatureList(),
+          this.getTransactionId().getBytes(),
           approveList);
       if (approveList.contains(ByteString.copyFrom(address))) {
         throw new PermissionException(encode58Check(address) + " had signed!");
@@ -582,7 +584,7 @@ public void addSign(byte[] privateKey, AccountStore accountStore)
               + " but it is not contained of permission.");
     }
     ByteString sig = ByteString.copyFrom(cryptoEngine.Base64toBytes(cryptoEngine
-        .signHash(getRawHash().getBytes())));
+        .signHash(getTransactionId().getBytes())));
     this.transaction = this.transaction.toBuilder().addSignature(sig).build();
   }
 
@@ -614,7 +616,7 @@ public boolean validatePubSignature(AccountStore accountStore,
         throw new ValidateSignatureException("too many signatures");
       }
 
-      byte[] hash = this.getRawHash().getBytes();
+      byte[] hash = getTransactionId().getBytes();
 
       try {
         if (!validateSignature(this.transaction, hash, accountStore, dynamicPropertiesStore)) {
@@ -657,7 +659,16 @@ public boolean validateSignature(AccountStore accountStore,
   }
 
   public Sha256Hash getTransactionId() {
-    return getRawHash();
+    if (this.id == null) {
+      this.id = getRawHash();
+    }
+    return this.id;
+  }
+
+  private void setRawData(Transaction.raw rawData) {
+    this.transaction = this.transaction.toBuilder().setRawData(rawData).build();
+    // invalidate trxId
+    this.id = null;
   }
 
   @Override