Skip to content

Commit a0f431c

Browse files
317787106317787106
authored
feat(net): delete config item node.discovery.bind.ip (#5597)
* delete config item node.bind.ip * remove bindIp method from Args * get lan ip from libp2p
1 parent 989115a commit a0f431c

11 files changed

Lines changed: 17 additions & 59 deletions

File tree

‎common/build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ dependencies {
4646
compile 'org.aspectj:aspectjrt:1.8.13'
4747
compile 'org.aspectj:aspectjweaver:1.8.13'
4848
compile 'org.aspectj:aspectjtools:1.8.13'
49-
compile group: 'io.github.tronprotocol', name: 'libp2p', version: '2.1.0',{
49+
compile group: 'com.github.tronprotocol', name: 'libp2p', version: 'test-v2.2.1',{
5050
exclude group: 'io.grpc', module: 'grpc-context'
5151
exclude group: 'io.grpc', module: 'grpc-core'
5252
exclude group: 'io.grpc', module: 'grpc-netty'

‎common/src/main/java/org/tron/common/parameter/CommonParameter.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public class CommonParameter {
176176
public int nodeListenPort;
177177
@Getter
178178
@Setter
179-
public String nodeDiscoveryBindIp;
179+
public String nodeLanIp;
180180
@Getter
181181
@Setter
182182
public String nodeExternalIp;

‎common/src/main/java/org/tron/core/Constant.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,6 @@ public class Constant {
281281
public static final String EVENT_SUBSCRIBE_CONTRACT_ADDRESS = "event.subscribe.filter.contractAddress";
282282
public static final String EVENT_SUBSCRIBE_CONTRACT_TOPIC = "event.subscribe.filter.contractTopic";
283283

284-
public static final String NODE_DISCOVERY_BIND_IP = "node.discovery.bind.ip";
285-
286284
public static final String NODE_DISCOVERY_EXTERNAL_IP = "node.discovery.external.ip";
287285

288286
public static final String NODE_BACKUP_PRIORITY = "node.backup.priority";

‎framework/src/main/java/org/tron/core/config/args/Args.java‎

Lines changed: 5 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.io.InputStream;
2121
import java.net.InetAddress;
2222
import java.net.InetSocketAddress;
23-
import java.net.Socket;
2423
import java.text.ParseException;
2524
import java.util.ArrayList;
2625
import java.util.Arrays;
@@ -136,7 +135,7 @@ public static void clearParam() {
136135
PARAMETER.maxTps = 1000;
137136
PARAMETER.minParticipationRate = 0;
138137
PARAMETER.nodeListenPort = 0;
139-
PARAMETER.nodeDiscoveryBindIp = "";
138+
PARAMETER.nodeLanIp = "";
140139
PARAMETER.nodeExternalIp = "";
141140
PARAMETER.nodeP2pVersion = 0;
142141
PARAMETER.nodeEnableIpv6 = false;
@@ -635,7 +634,7 @@ public static void setParam(final String[] args, final String confFileName) {
635634
config.hasPath(Constant.NODE_LISTEN_PORT)
636635
? config.getInt(Constant.NODE_LISTEN_PORT) : 0;
637636

638-
bindIp(config);
637+
PARAMETER.nodeLanIp = PARAMETER.p2pConfig.getLanIp();
639638
externalIp(config);
640639

641640
PARAMETER.nodeP2pVersion =
@@ -1247,7 +1246,7 @@ public static List<InetSocketAddress> getInetSocketAddress(
12471246
if (filter) {
12481247
String ip = inetSocketAddress.getAddress().getHostAddress();
12491248
int port = inetSocketAddress.getPort();
1250-
if (!(PARAMETER.nodeDiscoveryBindIp.equals(ip)
1249+
if (!(PARAMETER.nodeLanIp.equals(ip)
12511250
|| PARAMETER.nodeExternalIp.equals(ip)
12521251
|| Constant.LOCAL_HOST.equals(ip))
12531252
|| PARAMETER.nodeListenPort != port) {
@@ -1525,33 +1524,14 @@ private static FilterQuery getEventFilter(final com.typesafe.config.Config confi
15251524
return filter;
15261525
}
15271526

1528-
private static void bindIp(final com.typesafe.config.Config config) {
1529-
if (!config.hasPath(Constant.NODE_DISCOVERY_BIND_IP)
1530-
|| config.getString(Constant.NODE_DISCOVERY_BIND_IP)
1531-
.trim().isEmpty()) {
1532-
if (PARAMETER.nodeDiscoveryBindIp == null) {
1533-
logger.info("Bind address wasn't set, Punching to identify it...");
1534-
try (Socket s = new Socket("www.baidu.com", 80)) {
1535-
PARAMETER.nodeDiscoveryBindIp = s.getLocalAddress().getHostAddress();
1536-
logger.info("UDP local bound to: {}", PARAMETER.nodeDiscoveryBindIp);
1537-
} catch (IOException e) {
1538-
logger.warn("Can't get bind IP. Fall back to 127.0.0.1: " + e);
1539-
PARAMETER.nodeDiscoveryBindIp = "127.0.0.1";
1540-
}
1541-
}
1542-
} else {
1543-
PARAMETER.nodeDiscoveryBindIp = config.getString(Constant.NODE_DISCOVERY_BIND_IP).trim();
1544-
}
1545-
}
1546-
15471527
private static void externalIp(final com.typesafe.config.Config config) {
15481528
if (!config.hasPath(Constant.NODE_DISCOVERY_EXTERNAL_IP) || config
15491529
.getString(Constant.NODE_DISCOVERY_EXTERNAL_IP).trim().isEmpty()) {
15501530
if (PARAMETER.nodeExternalIp == null) {
15511531
logger.info("External IP wasn't set, using ipv4 from libp2p");
15521532
PARAMETER.nodeExternalIp = PARAMETER.p2pConfig.getIp();
15531533
if (StringUtils.isEmpty(PARAMETER.nodeExternalIp)) {
1554-
PARAMETER.nodeExternalIp = PARAMETER.nodeDiscoveryBindIp;
1534+
PARAMETER.nodeExternalIp = PARAMETER.nodeLanIp;
15551535
}
15561536
}
15571537
} else {
@@ -1622,7 +1602,7 @@ public static void logConfig() {
16221602
logger.info("\n");
16231603
logger.info("************************ Net config ************************");
16241604
logger.info("P2P version: {}", parameter.getNodeP2pVersion());
1625-
logger.info("Bind IP: {}", parameter.getNodeDiscoveryBindIp());
1605+
logger.info("LAN IP: {}", parameter.getNodeLanIp());
16261606
logger.info("External IP: {}", parameter.getNodeExternalIp());
16271607
logger.info("Listen port: {}", parameter.getNodeListenPort());
16281608
logger.info("Node ipv6 enable: {}", parameter.isNodeEnableIpv6());

‎framework/src/test/java/org/tron/core/config/args/ArgsTest.java‎

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717

1818
import com.google.common.collect.Lists;
1919
import com.typesafe.config.Config;
20-
import com.typesafe.config.ConfigMergeable;
21-
import com.typesafe.config.ConfigOrigin;
22-
import com.typesafe.config.ConfigRenderOptions;
23-
import com.typesafe.config.ConfigValue;
24-
import com.typesafe.config.ConfigValueType;
2520
import io.grpc.internal.GrpcUtil;
2621
import io.grpc.netty.NettyServerBuilder;
2722
import java.lang.reflect.InvocationTargetException;
@@ -36,10 +31,8 @@
3631
import org.tron.common.utils.ByteArray;
3732
import org.tron.common.utils.LocalWitnesses;
3833
import org.tron.common.utils.PublicMethod;
39-
import org.tron.common.utils.ReflectUtils;
4034
import org.tron.core.Constant;
4135
import org.tron.core.config.Configuration;
42-
import org.tron.core.net.peer.PeerManager;
4336

4437
@Slf4j
4538
public class ArgsTest {
@@ -95,7 +88,6 @@ public void get() {
9588

9689
Assert.assertTrue(parameter.isNodeDiscoveryEnable());
9790
Assert.assertTrue(parameter.isNodeDiscoveryPersist());
98-
Assert.assertEquals("127.0.0.1", parameter.getNodeDiscoveryBindIp());
9991
Assert.assertEquals("46.168.1.1", parameter.getNodeExternalIp());
10092
Assert.assertEquals(18888, parameter.getNodeListenPort());
10193
Assert.assertEquals(2000, parameter.getNodeConnectionTimeout());
@@ -130,27 +122,18 @@ public void testIpFromLibP2p()
130122
Args.setParam(new String[] {"-w"}, Constant.TEST_CONF);
131123
CommonParameter parameter = Args.getInstance();
132124

133-
String configuredBindIp = parameter.getNodeDiscoveryBindIp();
134125
String configuredExternalIp = parameter.getNodeExternalIp();
135-
Assert.assertEquals("127.0.0.1", configuredBindIp);
136126
Assert.assertEquals("46.168.1.1", configuredExternalIp);
137127

138128
Config config = Configuration.getByFileName(null, Constant.TEST_CONF);
139-
Config config2 = config.withoutPath(Constant.NODE_DISCOVERY_BIND_IP);
140-
Config config3 = config2.withoutPath(Constant.NODE_DISCOVERY_EXTERNAL_IP);
129+
Config config3 = config.withoutPath(Constant.NODE_DISCOVERY_EXTERNAL_IP);
141130

142-
CommonParameter.getInstance().setNodeDiscoveryBindIp(null);
143131
CommonParameter.getInstance().setNodeExternalIp(null);
144132

145-
Method method1 = Args.class.getDeclaredMethod("bindIp", Config.class);
146-
method1.setAccessible(true);
147-
method1.invoke(Args.class, config3);
148-
149133
Method method2 = Args.class.getDeclaredMethod("externalIp", Config.class);
150134
method2.setAccessible(true);
151135
method2.invoke(Args.class, config3);
152136

153-
Assert.assertNotEquals(configuredBindIp, parameter.getNodeDiscoveryBindIp());
154137
Assert.assertNotEquals(configuredExternalIp, parameter.getNodeExternalIp());
155138
}
156139
}

‎framework/src/test/java/org/tron/core/services/RpcApiServicesTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,11 @@ public static void init() throws IOException {
138138
getInstance().setRpcPort(PublicMethod.chooseRandomPort());
139139
getInstance().setRpcOnSolidityPort(PublicMethod.chooseRandomPort());
140140
getInstance().setRpcOnPBFTPort(PublicMethod.chooseRandomPort());
141-
String fullNode = String.format("%s:%d", getInstance().getNodeDiscoveryBindIp(),
141+
String fullNode = String.format("%s:%d", getInstance().getNodeLanIp(),
142142
getInstance().getRpcPort());
143-
String solidityNode = String.format("%s:%d", getInstance().getNodeDiscoveryBindIp(),
143+
String solidityNode = String.format("%s:%d", getInstance().getNodeLanIp(),
144144
getInstance().getRpcOnSolidityPort());
145-
String pBFTNode = String.format("%s:%d", getInstance().getNodeDiscoveryBindIp(),
145+
String pBFTNode = String.format("%s:%d", getInstance().getNodeLanIp(),
146146
getInstance().getRpcOnPBFTPort());
147147

148148
ManagedChannel channelFull = ManagedChannelBuilder.forTarget(fullNode)

‎framework/src/test/java/org/tron/core/services/filter/LiteFnQueryGrpcInterceptorTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ public static void init() throws IOException {
5858
Args.getInstance().setRpcPort(PublicMethod.chooseRandomPort());
5959
Args.getInstance().setRpcOnSolidityPort(PublicMethod.chooseRandomPort());
6060
Args.getInstance().setRpcOnPBFTPort(PublicMethod.chooseRandomPort());
61-
String fullnode = String.format("%s:%d", Args.getInstance().getNodeDiscoveryBindIp(),
61+
String fullnode = String.format("%s:%d", Args.getInstance().getNodeLanIp(),
6262
Args.getInstance().getRpcPort());
63-
String solidityNode = String.format("%s:%d", Args.getInstance().getNodeDiscoveryBindIp(),
63+
String solidityNode = String.format("%s:%d", Args.getInstance().getNodeLanIp(),
6464
Args.getInstance().getRpcOnSolidityPort());
65-
String pBFTNode = String.format("%s:%d", Args.getInstance().getNodeDiscoveryBindIp(),
65+
String pBFTNode = String.format("%s:%d", Args.getInstance().getNodeLanIp(),
6666
Args.getInstance().getRpcOnPBFTPort());
6767
channelFull = ManagedChannelBuilder.forTarget(fullnode)
6868
.usePlaintext()

‎framework/src/test/java/org/tron/core/services/filter/RpcApiAccessInterceptorTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ public static void init() throws IOException {
5959
Args.getInstance().setRpcPort(PublicMethod.chooseRandomPort());
6060
Args.getInstance().setRpcOnSolidityPort(PublicMethod.chooseRandomPort());
6161
Args.getInstance().setRpcOnPBFTPort(PublicMethod.chooseRandomPort());
62-
String fullNode = String.format("%s:%d", Args.getInstance().getNodeDiscoveryBindIp(),
62+
String fullNode = String.format("%s:%d", Args.getInstance().getNodeLanIp(),
6363
Args.getInstance().getRpcPort());
64-
String solidityNode = String.format("%s:%d", Args.getInstance().getNodeDiscoveryBindIp(),
64+
String solidityNode = String.format("%s:%d", Args.getInstance().getNodeLanIp(),
6565
Args.getInstance().getRpcOnSolidityPort());
66-
String pBFTNode = String.format("%s:%d", Args.getInstance().getNodeDiscoveryBindIp(),
66+
String pBFTNode = String.format("%s:%d", Args.getInstance().getNodeLanIp(),
6767
Args.getInstance().getRpcOnPBFTPort());
6868

6969
ManagedChannel channelFull = ManagedChannelBuilder.forTarget(fullNode)

‎framework/src/test/resources/config-test-mainnet.conf‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ storage {
5353
node.discovery = {
5454
enable = true
5555
persist = true
56-
bind.ip = "127.0.0.1"
5756
external.ip = "46.168.1.1"
5857
}
5958

‎framework/src/test/resources/config-test-storagetest.conf‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ storage {
7676
node.discovery = {
7777
enable = true
7878
persist = true
79-
bind.ip = "127.0.0.1"
8079
external.ip = "46.168.1.1"
8180
}
8281

0 commit comments

Comments
 (0)