Merge pull request #5117 from guoquanwu/feature/unit-test-port-conflict

feature(test): use random port in unit test

Author: tomatoishealthy

framework/src/test/java/org/tron/common/utils/PublicMethod.java

@@ -1,7 +1,11 @@
 package org.tron.common.utils;
 
 import com.google.protobuf.ByteString;
+
+import java.io.IOException;
 import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.Socket;
 import java.util.Random;
 
 import org.tron.api.GrpcAPI;
@@ -105,11 +109,30 @@ public static GrpcAPI.Return broadcastTransaction(
     return response;
   }
 
+  public static int chooseRandomPort() {
+    return chooseRandomPort(10240, 65000);
+  }
+
   public static int chooseRandomPort(int min, int max) {
-    return new Random().nextInt(max - min + 1) + min;
+    int port = new Random().nextInt(max - min + 1) + min;
+    try {
+      while (!checkPortAvailable(port)) {
+        port = new Random().nextInt(max - min + 1) + min;
+      }
+    } catch (IOException e) {
+      return new Random().nextInt(max - min + 1) + min;
+    }
+    return port;
   }
 
-  public static int chooseRandomPort() {
-    return new Random().nextInt(65530 - 1024) + 1024;
+  private static boolean checkPortAvailable(int port) throws IOException {
+    InetAddress theAddress = InetAddress.getByName("127.0.0.1");
+    try (Socket socket = new Socket(theAddress, port)) {
+      // only check
+      socket.getPort();
+    } catch (IOException e) {
+      return true;
+    }
+    return false;
   }
 }

framework/src/test/java/org/tron/core/services/filter/LiteFnQueryHttpFilterTest.java

@@ -14,15 +14,14 @@
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.ExpectedException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.tron.common.application.Application;
 import org.tron.common.application.ApplicationFactory;
 import org.tron.common.application.TronApplicationContext;
 import org.tron.common.utils.FileUtil;
+import org.tron.common.utils.PublicMethod;
 import org.tron.core.ChainBaseManager;
 import org.tron.core.Constant;
 import org.tron.core.config.DefaultConfig;
@@ -50,8 +49,12 @@ public class LiteFnQueryHttpFilterTest {
    */
   @Before
   public void init() {
-    Args.setParam(new String[]{"-d", dbPath}, Constant.TEST_CONF);
-    //Args.getInstance().setFullNodeAllowShieldedTransactionArgs(false);
+    Args.setParam(new String[]{"-d", dbPath, "--p2p-disable", "true"}, Constant.TEST_CONF);
+    Args.getInstance().setFullNodeAllowShieldedTransactionArgs(false);
+    Args.getInstance().setFullNodeHttpPort(PublicMethod.chooseRandomPort());
+    Args.getInstance().setSolidityHttpPort(PublicMethod.chooseRandomPort());
+    Args.getInstance().setPBFTHttpPort(PublicMethod.chooseRandomPort());
+
     context = new TronApplicationContext(DefaultConfig.class);
     appTest = ApplicationFactory.create(context);
     FullNodeHttpApiService httpApiService = context