Skip to content

Commit 1467908

Browse files
committed
feat(config):add unit test for DynamicArgs
1 parent 8856500 commit 1467908

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

framework/src/main/java/org/tron/core/config/args/DynamicArgs.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ public class DynamicArgs {
3030

3131
public void init() {
3232
if (parameter.isDynamicConfigEnable()) {
33+
logger.info("Start the dynamic loading configuration service");
34+
long checkInterval = parameter.getDynamicConfigCheckInterval();
3335
File config = getConfigFile();
3436
if (config == null) {
3537
return;
3638
}
3739
lastModified = config.lastModified();
38-
logger.info("Start the dynamic loading configuration service");
39-
long checkInterval = parameter.getDynamicConfigCheckInterval();
4040
reloadExecutor.scheduleWithFixedDelay(() -> {
4141
try {
4242
run();

framework/src/test/java/org/tron/core/config/args/DynamicArgsTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,11 @@ public void destroy() {
3636
}
3737

3838
@Test
39-
public void get() {
39+
public void start() {
4040
CommonParameter parameter = Args.getInstance();
41-
Assert.assertFalse(parameter.isDynamicConfigEnable());
41+
Assert.assertTrue(parameter.isDynamicConfigEnable());
4242
Assert.assertEquals(600, parameter.getDynamicConfigCheckInterval());
43-
}
4443

45-
@Test
46-
public void start() {
4744
dynamicArgs.init();
4845
Assert.assertEquals(0, (long) ReflectUtils.getFieldObject(dynamicArgs, "lastModified"));
4946

@@ -63,6 +60,11 @@ public void start() {
6360
return;
6461
}
6562
}
63+
try {
64+
dynamicArgs.reload();
65+
} catch (Exception e) {
66+
// no need to deal with
67+
}
6668

6769
dynamicArgs.close();
6870
}

framework/src/test/resources/config-test.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,4 +342,5 @@ committee = {
342342
allowCreationOfContracts = 1 //mainnet:0 (reset by committee),test:1
343343
}
344344

345+
node.dynamicConfig.enable = true
345346
node.dynamicConfig.checkInterval = 0

0 commit comments

Comments
 (0)