test(refactor): create folders with temporaryFolder (#5477)

Author: halibobo1205

framework/src/test/java/org/tron/common/BaseTest.java

@@ -1,18 +1,19 @@
 package org.tron.common;
 
 import com.google.protobuf.ByteString;
-import java.io.File;
+import java.io.IOException;
 import javax.annotation.Resource;
 import lombok.extern.slf4j.Slf4j;
-import org.apache.commons.lang3.StringUtils;
 import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.rules.TemporaryFolder;
 import org.junit.runner.RunWith;
 import org.springframework.test.annotation.DirtiesContext;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
 import org.tron.common.crypto.ECKey;
 import org.tron.common.parameter.CommonParameter;
-import org.tron.common.utils.FileUtil;
 import org.tron.common.utils.Sha256Hash;
 import org.tron.consensus.base.Param;
 import org.tron.core.ChainBaseManager;
@@ -28,22 +29,27 @@
 @DirtiesContext
 public abstract class BaseTest {
 
-  protected static String dbPath;
+  @ClassRule
+  public static final TemporaryFolder temporaryFolder = new TemporaryFolder();
+
   @Resource
   protected Manager dbManager;
   @Resource
   protected ChainBaseManager chainBaseManager;
 
+
+  public static String dbPath() {
+    try {
+      return temporaryFolder.newFolder().toString();
+    } catch (IOException e) {
+      Assert.fail("create temp folder failed");
+    }
+    return null;
+  }
+
   @AfterClass
   public static void destroy() {
     Args.clearParam();
-    if (StringUtils.isNotEmpty(dbPath)) {
-      if (FileUtil.deleteDir(new File(dbPath))) {
-        logger.info("Release resources successful.");
-      } else {
-        logger.info("Release resources failure.");
-      }
-    }
   }
 
   public Protocol.Block getSignedBlock(ByteString witness, long time, byte[] privateKey) {

framework/src/test/java/org/tron/common/config/args/ArgsTest.java

@@ -1,30 +1,32 @@
 package org.tron.common.config.args;
 
-import java.io.File;
+import java.io.IOException;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
 import org.tron.common.parameter.RateLimiterInitialization;
-import org.tron.common.utils.FileUtil;
 import org.tron.core.Constant;
 import org.tron.core.config.args.Args;
 
 
 public class ArgsTest {
 
-  private static final String dbPath = "output_arg_test";
+  @Rule
+  public final TemporaryFolder temporaryFolder = new TemporaryFolder();
 
   @Before
-  public void init() {
-    Args.setParam(new String[] {"--output-directory", dbPath, "--p2p-disable", "true",
+  public void init() throws IOException {
+    Args.setParam(new String[] {"--output-directory",
+        temporaryFolder.newFolder().toString(), "--p2p-disable", "true",
         "--debug"}, Constant.TEST_CONF);
   }
 
   @After
   public void destroy() {
     Args.clearParam();
-    FileUtil.deleteDir(new File(dbPath));
   }
 
   @Test

framework/src/test/java/org/tron/common/runtime/InheritanceTest.java

@@ -25,8 +25,7 @@ public class InheritanceTest extends BaseTest {
   private static boolean init;
 
   static {
-    dbPath = "output_InheritanceTest";
-    Args.setParam(new String[]{"--output-directory", dbPath, "--debug"}, Constant.TEST_CONF);
+    Args.setParam(new String[]{"--output-directory", dbPath(), "--debug"}, Constant.TEST_CONF);
     OWNER_ADDRESS = Wallet.getAddressPreFixString() + "abd4b9367799eaa3197fecb144eb71de1e049abc";
   }
 

framework/src/test/java/org/tron/common/runtime/InternalTransactionComplexTest.java

@@ -27,8 +27,7 @@ public class InternalTransactionComplexTest extends BaseTest {
   private static boolean init;
 
   static {
-    dbPath = "output_InternalTransactionComplexTest";
-    Args.setParam(new String[]{"--output-directory", dbPath, "--debug", "--support-constant"},
+    Args.setParam(new String[]{"--output-directory", dbPath(), "--debug", "--support-constant"},
         Constant.TEST_CONF);
     OWNER_ADDRESS = Wallet.getAddressPreFixString() + "abd4b9367799eaa3197fecb144eb71de1e049abc";
   }

framework/src/test/java/org/tron/common/runtime/ProgramResultTest.java

@@ -44,8 +44,7 @@ public class ProgramResultTest extends BaseTest {
   private static boolean init;
 
   static {
-    dbPath = "output_InternalTransactionComplexTest";
-    Args.setParam(new String[]{"--output-directory", dbPath, "--debug", "--support-constant"},
+    Args.setParam(new String[]{"--output-directory", dbPath(), "--debug", "--support-constant"},
         Constant.TEST_CONF);
     OWNER_ADDRESS = Wallet.getAddressPreFixString() + "abd4b9367799eaa3197fecb144eb71de1e049abc";
     TRANSFER_TO = Wallet.getAddressPreFixString() + "548794500882809695a8a687866e76d4271a1abc";

framework/src/test/java/org/tron/common/runtime/RuntimeImplTest.java

@@ -40,8 +40,7 @@ public class RuntimeImplTest extends BaseTest {
   private final long creatorTotalBalance = 3_000_000_000L;
 
   static {
-    dbPath = "output_RuntimeImplTest";
-    Args.setParam(new String[]{"--output-directory", dbPath, "--debug"}, Constant.TEST_CONF);
+    Args.setParam(new String[]{"--output-directory", dbPath(), "--debug"}, Constant.TEST_CONF);
     callerAddress = Hex
         .decode(Wallet.getAddressPreFixString() + "abd4b9367799eaa3197fecb144eb71de1e049abc");
     creatorAddress = Hex

framework/src/test/java/org/tron/common/runtime/RuntimeTransferComplexTest.java

@@ -32,8 +32,7 @@ public class RuntimeTransferComplexTest extends BaseTest {
   private static boolean init;
 
   static {
-    dbPath = "output_RuntimeTransferComplexTest";
-    Args.setParam(new String[]{"--output-directory", dbPath, "--debug"}, Constant.TEST_CONF);
+    Args.setParam(new String[]{"--output-directory", dbPath(), "--debug"}, Constant.TEST_CONF);
     OWNER_ADDRESS = Wallet.getAddressPreFixString() + "abd4b9367799eaa3197fecb144eb71de1e049abc";
     TRANSFER_TO = Wallet.getAddressPreFixString() + "548794500882809695a8a687866e76d4271a1abc";
   }

framework/src/test/java/org/tron/common/runtime/vm/BandWidthRuntimeOutOfTimeTest.java

@@ -67,10 +67,9 @@ public class BandWidthRuntimeOutOfTimeTest extends BaseTest {
   private static boolean init;
 
   static {
-    dbPath = "output_bandwidth_runtime_out_of_time_test";
     Args.setParam(
         new String[]{
-            "--output-directory", dbPath,
+            "--output-directory", dbPath(),
             "--storage-db-directory", dbDirectory,
             "--storage-index-directory", indexDirectory,
             "-w",

framework/src/test/java/org/tron/common/runtime/vm/BandWidthRuntimeOutOfTimeWithCheckTest.java

@@ -68,10 +68,9 @@ public class BandWidthRuntimeOutOfTimeWithCheckTest extends BaseTest {
   private static boolean init;
 
   static {
-    dbPath = "output_bandwidth_runtime_out_of_time_with_check_test";
     Args.setParam(
         new String[]{
-            "--output-directory", dbPath,
+            "--output-directory", dbPath(),
             "--storage-db-directory", dbDirectory,
             "--storage-index-directory", indexDirectory,
             "-w",

framework/src/test/java/org/tron/common/runtime/vm/BandWidthRuntimeTest.java

@@ -59,10 +59,9 @@ public class BandWidthRuntimeTest extends BaseTest {
 
   @BeforeClass
   public static void init() {
-    dbPath = "output_bandwidth_runtime_test";
     Args.setParam(
         new String[]{
-            "--output-directory", dbPath,
+            "--output-directory", dbPath(),
             "--storage-db-directory", dbDirectory,
             "--storage-index-directory", indexDirectory,
             "-w"