fix: add type-safe post return, strip image digests consistently

Author: nicktrn

apps/supervisor/src/workloadManager/compute.ts

@@ -6,7 +6,7 @@ import {
   type WorkloadManagerCreateOptions,
   type WorkloadManagerOptions,
 } from "./types.js";
-import { ComputeClient } from "@internal/compute";
+import { ComputeClient, stripImageDigest } from "@internal/compute";
 import { env } from "../env.js";
 import { getRunnerId } from "../util.js";
 import { buildOtlpTracePayload } from "../otlpPayload.js";
@@ -82,7 +82,7 @@ export class ComputeWorkloadManager implements WorkloadManager {
     }
 
     // Strip image digest - resolve by tag, not digest
-    const imageRef = opts.image.split("@")[0]!;
+    const imageRef = stripImageDigest(opts.image);
 
     // Wide event: single canonical log line emitted in finally
     const event: Record<string, unknown> = {

apps/webapp/app/v3/services/computeTemplateCreation.server.ts

@@ -1,4 +1,4 @@
-import { ComputeClient } from "@internal/compute";
+import { ComputeClient, stripImageDigest } from "@internal/compute";
 import { env } from "~/env.server";
 import { logger } from "~/services/logger.server";
 import type { PrismaClientOrTransaction } from "~/db.server";
@@ -159,7 +159,7 @@ export class ComputeTemplateCreationService {
 
     try {
       await this.client.templates.create({
-        image: imageReference,
+        image: stripImageDigest(imageReference),
         cpu: 0.5,
         memory_mb: 512,
         background: options?.background,

internal-packages/compute/src/client.ts

@@ -46,7 +46,7 @@ class HttpTransport {
     return options?.signal ?? AbortSignal.timeout(this.opts.timeoutMs);
   }
 
-  async post<T = unknown>(path: string, body: unknown, options?: RequestOptions): Promise<T> {
+  async post<T = unknown>(path: string, body: unknown, options?: RequestOptions): Promise<T | undefined> {
     const url = `${this.opts.gatewayUrl}${path}`;
 
     const response = await fetch(url, {
@@ -63,7 +63,7 @@ class HttpTransport {
 
     // 202 Accepted or 204 No Content - no body to parse
     if (response.status === 202 || response.status === 204) {
-      return undefined as T;
+      return undefined;
     }
 
     return (await response.json()) as T;
@@ -106,17 +106,8 @@ class TemplatesNamespace {
   async create(
     req: TemplateCreateRequest,
     options?: RequestOptions
-  ): Promise<{ accepted: boolean }> {
-    try {
-      await this.http.post("/api/templates", req, options);
-      // If we get here without error, the request was accepted (202) or succeeded
-      return { accepted: true };
-    } catch (error) {
-      if (error instanceof ComputeClientError && error.status === 202) {
-        return { accepted: true };
-      }
-      throw error;
-    }
+  ): Promise<void> {
+    await this.http.post("/api/templates", req, options);
   }
 }
 
@@ -127,7 +118,11 @@ class InstancesNamespace {
     req: InstanceCreateRequest,
     options?: RequestOptions
   ): Promise<InstanceCreateResponse> {
-    return this.http.post<InstanceCreateResponse>("/api/instances", req, options);
+    const result = await this.http.post<InstanceCreateResponse>("/api/instances", req, options);
+    if (!result) {
+      throw new Error("Compute gateway returned no instance body");
+    }
+    return result;
   }
 
   async delete(runnerId: string, options?: RequestOptions): Promise<void> {

internal-packages/compute/src/imageRef.ts

@@ -0,0 +1,11 @@
+/**
+ * Strip the digest suffix from a container image reference.
+ * Tags are immutable, so we resolve by tag rather than pinning to a digest.
+ *
+ * "ghcr.io/org/image:tag@sha256:abc..." -> "ghcr.io/org/image:tag"
+ * "ghcr.io/org/image@sha256:abc..."     -> "ghcr.io/org/image"
+ * "ghcr.io/org/image:tag"              -> "ghcr.io/org/image:tag" (unchanged)
+ */
+export function stripImageDigest(imageRef: string): string {
+  return imageRef.split("@")[0] ?? imageRef;
+}

internal-packages/compute/src/index.ts

@@ -1,5 +1,6 @@
 export { ComputeClient, ComputeClientError } from "./client.js";
 export type { ComputeClientOptions } from "./client.js";
+export { stripImageDigest } from "./imageRef.js";
 export {
   TemplateCreateRequestSchema,
   TemplateCallbackPayloadSchema,