Renaming some logs variables

Author: mpcgrid

apps/webapp/app/presenters/v3/LogsListPresenter.server.ts

@@ -1,4 +1,4 @@
-import { type ClickHouse, type LogsListV2Result } from "@internal/clickhouse";
+import { type ClickHouse, type LogsListResult } from "@internal/clickhouse";
 import { MachinePresetName } from "@trigger.dev/core/v3";
 import {
   type PrismaClient,

apps/webapp/app/utils/pathBuilder.ts

@@ -436,10 +436,7 @@ export function v3LogsPath(
   organization: OrgForPath,
   project: ProjectForPath,
   environment: EnvironmentForPath,
-  // deployment: DeploymentForPath,
-  // currentPage: number
 ) {
-  // const query = currentPage ? `?page=${currentPage}` : "";
   return `${v3EnvironmentPath(organization, project, environment)}/logs`;
 }
 

internal-packages/clickhouse/src/client/queryBuilder.ts

@@ -122,7 +122,6 @@ export class ClickhouseQueryFastBuilder<TOutput extends Record<string, any>> {
   /**
    * Add a PREWHERE clause - filters applied before reading columns.
    * Use for primary key columns (environment_id, start_time) to reduce I/O.
-   * PREWHERE is evaluated before WHERE and significantly reduces data read.
    */
   prewhere(clause: string, params?: QueryParams): this {
     this.prewhereClauses.push(clause);

internal-packages/clickhouse/src/index.ts

@@ -22,8 +22,8 @@ import {
   getTraceSummaryQueryBuilderV2,
   insertTaskEvents,
   insertTaskEventsV2,
-  getLogsListQueryBuilderV2,
-  getLogDetailQueryBuilderV2,
+  getLogsListQueryBuilder,
+  getLogDetailQueryBuilder,
 } from "./taskEvents.js";
 import { Logger, type LogLevel } from "@trigger.dev/core/logger";
 import type { Agent as HttpAgent } from "http";
@@ -184,8 +184,8 @@ export class ClickHouse {
       traceSummaryQueryBuilder: getTraceSummaryQueryBuilderV2(this.reader),
       traceDetailedSummaryQueryBuilder: getTraceDetailedSummaryQueryBuilderV2(this.reader),
       spanDetailsQueryBuilder: getSpanDetailsQueryBuilderV2(this.reader),
-      logsListQueryBuilder: getLogsListQueryBuilderV2(this.reader),
-      logDetailQueryBuilder: getLogDetailQueryBuilderV2(this.reader),
+      logsListQueryBuilder: getLogsListQueryBuilder(this.reader),
+      logDetailQueryBuilder: getLogDetailQueryBuilder(this.reader),
     };
   }
 }

internal-packages/clickhouse/src/taskEvents.ts

@@ -235,7 +235,7 @@ export function getSpanDetailsQueryBuilderV2(
 // Logs List Query Builders (for aggregated logs page)
 // ============================================================================
 
-export const LogsListV2Result = z.object({
+export const LogsListResult = z.object({
   environment_id: z.string(),
   organization_id: z.string(),
   project_id: z.string(),
@@ -251,10 +251,10 @@ export const LogsListV2Result = z.object({
   duration: z.number().or(z.string()),
 });
 
-export type LogsListV2Result = z.output<typeof LogsListV2Result>;
+export type LogsListResult = z.output<typeof LogsListResult>;
 
-export function getLogsListQueryBuilderV2(ch: ClickhouseReader, settings?: ClickHouseSettings) {
-  return ch.queryBuilderFast<LogsListV2Result>({
+export function getLogsListQueryBuilder(ch: ClickhouseReader, settings?: ClickHouseSettings) {
+  return ch.queryBuilderFast<LogsListResult>({
     name: "getLogsList",
     table: "trigger_dev.task_events_v2",
     columns: [
@@ -302,7 +302,7 @@ export const LogDetailV2Result = z.object({
 
 export type LogDetailV2Result = z.output<typeof LogDetailV2Result>;
 
-export function getLogDetailQueryBuilderV2(ch: ClickhouseReader, settings?: ClickHouseSettings) {
+export function getLogDetailQueryBuilder(ch: ClickhouseReader, settings?: ClickHouseSettings) {
   return ch.queryBuilderFast<LogDetailV2Result>({
     name: "getLogDetail",
     table: "trigger_dev.task_events_v2",