Skip to content

Commit 8c56d85

Browse files
authored
fix(helm): supervisor OTLP endpoint resolves cross-namespace (#3504)
Reported by external contributor. The supervisor template hardcoded a short DNS name for `OTEL_EXPORTER_OTLP_ENDPOINT`, which the supervisor then propagates verbatim into runner pods (`apps/supervisor/src/workloadManager/kubernetes.ts:196`). When runners are spawned in a different namespace via `supervisor.config.kubernetes.namespace`, the short name doesn't resolve and span/log export silently fails - runs complete fine but the dashboard shows nothing. Same FQDN pattern the chart already uses for `TRIGGER_WORKLOAD_API_DOMAIN` (line 203). Verified with `helm template trigger . --namespace my-ns` - renders `http://trigger-webapp.my-ns.svc.cluster.local:3030/otel`. Cheers Niels
1 parent dc98ae4 commit 8c56d85

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

hosting/k8s/helm/templates/supervisor.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ spec:
237237
value: {{ .Values.supervisor.config.debug | quote }}
238238
# OTEL
239239
- name: OTEL_EXPORTER_OTLP_ENDPOINT
240-
value: "http://{{ include "trigger-v4.fullname" . }}-webapp:{{ .Values.webapp.service.port }}/otel"
240+
value: "http://{{ include "trigger-v4.fullname" . }}-webapp.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.webapp.service.port }}/otel"
241241
{{- with .Values.supervisor.extraEnvVars }}
242242
{{- toYaml . | nindent 12 }}
243243
{{- end }}

0 commit comments

Comments
 (0)