Aerich does not set default values during migration

[lordcod]

An error occurs when trying to migrate:

tortoise.exceptions.OperationalError: Cannot add a NOT NULL column with default value NULL

My code:

class MyModel(Model): 
    temp_notification = JSONField(default={'by_username': {},
                                           'users': {}}, null=False)

Migrate code:

async def upgrade(db: BaseDBAsyncClient) -> str:
    return """
        ALTER TABLE "guilds" ADD "temp_notification" JSON NOT NULL;"""

The correct migration:

async def upgrade(db: BaseDBAsyncClient) -> str:
    return """
        ALTER TABLE "guilds" ADD "temp_notification" JSON NOT NULL DEFAULT '{"by_username": {}, "users": {}}';"""

In this case, the upgrade is successful.

I've already seen a similar error, it seems like I've already installed the latest version, but it still doesn't help.

[waketzheng]

Can't reproduce in MySQL/Postgresql/sqlite, with the following models:

# models.py
import os
from tortoise import Model, fields

TORTOISE_ORM = {
    "connections": {
        "default": "sqlite://db.sqlite3"
        # "default": "mysql://root:123456@127.0.0.1:3306/aerich_dev"
        # "default": "postgres://postgres:postgres@127.0.0.1:5432/aerich_dev"
    },
    "apps": {
        "models": {"models": ["models", "aerich.models"]},
    },
}


class Guilds(Model):
    name = fields.CharField(20)
    if os.getenv('AERICH_TEST_ADD_JSON_FIELD'):
        temp_notification = fields.JSONField(default={'by_username': {},'users': {}}, null=False)

Commands:

aerich init -t models.TORTOISE_ORM
aerich init-db
AERICH_TEST_ADD_JSON_FIELD=1 aerich migrate
cat migrations/models/1*

Got:

from tortoise import BaseDBAsyncClient


async def upgrade(db: BaseDBAsyncClient) -> str:
    return """
        ALTER TABLE "guilds" ADD "temp_notification" JSON NOT NULL;"""


async def downgrade(db: BaseDBAsyncClient) -> str:
    return """
        ALTER TABLE "guilds" DROP COLUMN "temp_notification";"""

This migration file does not raise OperationalError when executed by AERICH_TEST_ADD_JSON_FIELD=1 aerich upgrade

Finally, I found that insert data to guilds before upgrade can reproduce the bug.