Crashes on SDK 36

[androidacy-user]

On android 16, we're seeing a large amount of these libsu crashes:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.io.OutputStream java.lang.Process.getOutputStream()' on a null object reference
       at com.topjohnwu.superuser.internal.ShellImpl.<init>(ShellImpl.java:123)
       at com.topjohnwu.superuser.internal.BuilderImpl.build(BuilderImpl.java:131)
       at com.topjohnwu.superuser.internal.BuilderImpl.exec(BuilderImpl.java:119)
       at com.topjohnwu.superuser.internal.BuilderImpl.start(BuilderImpl.java:97)
       at com.topjohnwu.superuser.internal.BuilderImpl.build(BuilderImpl.java:158)
       at com.topjohnwu.superuser.internal.MainShell.get(MainShell.java:53)
       at com.topjohnwu.superuser.internal.MainShell.lambda$get$1(MainShell.java:74)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
       at java.lang.Thread.run(Thread.java:1119)
        

Prior android versions are unaffected.

[androidacy-user]

On android 16, we're seeing a large amount of these libsu crashes:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.io.OutputStream java.lang.Process.getOutputStream()' on a null object reference
at com.topjohnwu.superuser.internal.ShellImpl.(ShellImpl.java:123)
at com.topjohnwu.superuser.internal.BuilderImpl.build(BuilderImpl.java:131)
at com.topjohnwu.superuser.internal.BuilderImpl.exec(BuilderImpl.java:119)
at com.topjohnwu.superuser.internal.BuilderImpl.start(BuilderImpl.java:97)
at com.topjohnwu.superuser.internal.BuilderImpl.build(BuilderImpl.java:158)
at com.topjohnwu.superuser.internal.MainShell.get(MainShell.java:53)
at com.topjohnwu.superuser.internal.MainShell.lambda$get$1(MainShell.java:74)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
at java.lang.Thread.run(Thread.java:1119)

Prior android versions are unaffected.

More notes:

We can't consistently reproduce. The issue is not in app-side code but the library itself.

[MMouse23]

I ran into this issue as well on Android 16 (Raspberry Pi 5). Since adb root appears to be the only proper method that still works, I've written a Magisk module that handles root command execution via a file-based message bus running as a background daemon. https://gitlab.com/droid-public/magisk-adp-root-daemon The daemon starts at boot with root privileges and monitors /data/local/tmp/adp/ for request files. Apps write their commands to a request file, the daemon executes them as root, and writes the result back. No need to spawn su from the app process. Works around the SELinux restriction without requiring adb root to be connected.

[androidacy-user]

I ran into this issue as well on Android 16 (Raspberry Pi 5). Since adb root appears to be the only proper method that still works, I've written a Magisk module that handles root command execution via a file-based message bus running as a background daemon. https://gitlab.com/droid-public/magisk-adp-root-daemon The daemon starts at boot with root privileges and monitors /data/local/tmp/adp/ for request files. Apps write their commands to a request file, the daemon executes them as root, and writes the result back. No need to spawn su from the app process. Works around the SELinux restriction without requiring adb root to be connected.

Different issue, and that's a nonstandard restriction, indicating an issue with your specific android variant.

[AndroidDeveloperLB]

I actually found it too, and it can occur on Android 13 too:

#187

I also showed in code where it occurs.