Skip to content

Commit c5f96c3

Browse files
committed
libtmux(fix[logging]): remove exc_info from options parse warnings
why: exc_info=True on WARNING-level parse failures produces noisy tracebacks for expected edge cases (non-string option values). The structured extra fields already provide sufficient context. what: - Remove exc_info=True from all 5 logger.warning() calls in options.py
1 parent 0649640 commit c5f96c3

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

src/libtmux/options.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,6 @@ def explode_arrays(
431431
options[key] = val
432432
logger.warning(
433433
"tmux options parse failed",
434-
exc_info=True,
435434
extra={"tmux_option_key": key},
436435
)
437436
return options
@@ -519,7 +518,6 @@ def explode_complex(
519518
except Exception: # NOQA: PERF203
520519
logger.warning(
521520
"tmux options parse failed",
522-
exc_info=True,
523521
extra={"tmux_option_key": key},
524522
)
525523
options[key] = new_val
@@ -547,7 +545,6 @@ def explode_complex(
547545
except Exception: # NOQA: PERF203
548546
logger.warning(
549547
"tmux options parse failed",
550-
exc_info=True,
551548
extra={"tmux_option_key": key},
552549
)
553550
options[key] = new_overrides
@@ -567,7 +564,6 @@ def explode_complex(
567564
except Exception: # NOQA: PERF203
568565
logger.warning(
569566
"tmux options parse failed",
570-
exc_info=True,
571567
extra={"tmux_option_key": key},
572568
)
573569
options[key] = new_aliases
@@ -579,7 +575,6 @@ def explode_complex(
579575
options[key] = val
580576
logger.warning(
581577
"tmux options parse failed",
582-
exc_info=True,
583578
extra={"tmux_option_key": key},
584579
)
585580
return options

0 commit comments

Comments
 (0)