libtmux(fix[logging]): add tmux_stderr_len, hoist shlex.join, fix message tense

why: Three low-consensus but valid logging conformance findings.
what:
- common.py: add tmux_stderr_len to DEBUG extra dict for symmetry
  with tmux_stdout_len
- neo.py: hoist shlex.join to a local variable before first guard,
  reuse in both log calls
- pytest_plugin.py: move log after kill_session and change message
  to past tense "old test session killed"

Author: tony

src/libtmux/common.py

@@ -302,6 +302,7 @@ def __init__(self, *args: t.Any) -> None:
                     "tmux_stdout": self.stdout[:100],
                     "tmux_stderr": self.stderr[:100],
                     "tmux_stdout_len": len(self.stdout),
+                    "tmux_stderr_len": len(self.stderr),
                 },
             )
 

src/libtmux/neo.py

@@ -306,12 +306,14 @@ def fetch_objs(
 
     tmux_cmds.append(f"-F{format_string}")
 
+    cmd_str = shlex.join([str(x) for x in tmux_cmds])
+
     if logger.isEnabledFor(logging.DEBUG):
         logger.debug(
             "tmux list queried",
             extra={
                 "tmux_subcommand": list_cmd,
-                "tmux_cmd": shlex.join([str(x) for x in tmux_cmds]),
+                "tmux_cmd": cmd_str,
             },
         )
 
@@ -327,7 +329,7 @@ def fetch_objs(
             "tmux list parsed",
             extra={
                 "tmux_subcommand": list_cmd,
-                "tmux_cmd": shlex.join([str(x) for x in tmux_cmds]),
+                "tmux_cmd": cmd_str,
                 "tmux_stdout_len": len(proc.stdout),
             },
         )

src/libtmux/pytest_plugin.py

@@ -251,14 +251,14 @@ def session(
         server.switch_client(target_session=session_id)
 
     for old_test_session in old_test_sessions:
+        server.kill_session(old_test_session)
         logger.debug(
-            "old test session found, killing",
+            "old test session killed",
             extra={
                 "tmux_session": old_test_session,
                 "tmux_subcommand": "kill-session",
             },
         )
-        server.kill_session(old_test_session)
     assert session.session_name == TEST_SESSION_NAME
     assert TEST_SESSION_NAME != "tmuxp"