Skip to content

Commit 33dae71

Browse files
committed
Fix annoying mistake
1 parent 76ab409 commit 33dae71

2 files changed

Lines changed: 62 additions & 64 deletions

File tree

examples/sandbox/src/App.tsx

Lines changed: 61 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -163,69 +163,67 @@ const App: s.Component = () => {
163163

164164
const [showBroken, setShowBroken] = s.createSignal(false)
165165

166-
return (
167-
<>
168-
{header()}
169-
{objmemo().subheader}
170-
<div>
171-
<header>
172-
<Button onClick={() => setCount(p => ++p)} text={`Count: ${count()}`} />
173-
<Button onClick={() => setCount(p => ++p)} text={`Count: ${count()}`} />
174-
</header>
175-
<sweb.Dynamic
176-
component='div'
177-
style={{height: '1rem', 'margin-top': '1rem'}}
178-
>
179-
<s.Show when={showEven()}>
180-
{s.createComponent(() => <>
181-
<BoldWrapper/>
182-
</>, {})}
183-
</s.Show>
184-
</sweb.Dynamic>
185-
{/* <button onClick={() => disposeApp()}>Dispose whole application</button>
186-
<br /> */}
187-
<button onClick={() => setShowBroken(p => !p)}>
188-
{showBroken() ? 'Hide' : 'Show'} broken component.
189-
</button>
190-
<s.ErrorBoundary
191-
fallback={(err, reset) => <>
192-
{err.toString()}
193-
<button
194-
onClick={() => {
195-
setShowBroken(false)
196-
reset()
197-
}}
198-
>
199-
Reset
200-
</button>
201-
</>}
202-
>
203-
<s.Show when={showBroken()}>
204-
<Broken />
205-
</s.Show>
206-
</s.ErrorBoundary>
207-
<br />
208-
<br />
209-
</div>
210-
<DynamicSpreadParent />
211-
<button onClick={() => setRootCount(p => ++p)}>Update root count</button>
212-
<button onClick={() => disposeOuterRoot()}>Dispose OUTSIDE_ROOT</button>
213-
<Article />
214-
<Todos title='Simple Todos Example' />
215-
{s.untrack(() => {
216-
const MARGIN = '24px'
217-
return <>
218-
<div style={{margin: MARGIN}}>
219-
<CountingComponent />
220-
</div>
221-
<div style={{margin: MARGIN}}>
222-
<ThemeExample />
223-
</div>
224-
</>
225-
})}
226-
<Recursive />
227-
</>
228-
)
166+
return <>
167+
{header()}
168+
{objmemo().subheader}
169+
<div>
170+
<header>
171+
<Button onClick={() => setCount(p => ++p)} text={`Count: ${count()}`} />
172+
<Button onClick={() => setCount(p => ++p)} text={`Count: ${count()}`} />
173+
</header>
174+
<sweb.Dynamic
175+
component='div'
176+
style={{height: '1rem', 'margin-top': '1rem'}}
177+
>
178+
<s.Show when={showEven()}>
179+
{s.createComponent(() => <>
180+
<BoldWrapper/>
181+
</>, {})}
182+
</s.Show>
183+
</sweb.Dynamic>
184+
{/* <button onClick={() => disposeApp()}>Dispose whole application</button>
185+
<br /> */}
186+
<button onClick={() => setShowBroken(p => !p)}>
187+
{showBroken() ? 'Hide' : 'Show'} broken component.
188+
</button>
189+
<s.ErrorBoundary
190+
fallback={(err, reset) => <>
191+
{err.toString()}
192+
<button
193+
onClick={() => {
194+
setShowBroken(false)
195+
reset()
196+
}}
197+
>
198+
Reset
199+
</button>
200+
</>}
201+
>
202+
<s.Show when={showBroken()}>
203+
<Broken />
204+
</s.Show>
205+
</s.ErrorBoundary>
206+
<br />
207+
<br />
208+
</div>
209+
<DynamicSpreadParent />
210+
<button onClick={() => setRootCount(p => ++p)}>Update root count</button>
211+
<button onClick={() => disposeOuterRoot()}>Dispose OUTSIDE_ROOT</button>
212+
<Article />
213+
<Todos title='Simple Todos Example' />
214+
{s.untrack(() => {
215+
const MARGIN = '24px'
216+
return <>
217+
<div style={{margin: MARGIN}}>
218+
<CountingComponent />
219+
</div>
220+
<div style={{margin: MARGIN}}>
221+
<ThemeExample />
222+
</div>
223+
</>
224+
})}
225+
<Recursive />
226+
</>
229227
}
230228

231229
const CountingComponent = () => {

packages/debugger/src/structure/walker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ function mapOwner<TEl extends object>(
444444
children_stack_arr[0]!.splice(children_stack_idx[0]!-1, 1)
445445
children_stack_idx[0]! -= 1
446446
}
447-
children_stack_len = 0
447+
children_stack_len = 1
448448

449449
// Skip remaining elements from the child
450450
for (let skip_child_idx = child_idx + 1;;) {

0 commit comments

Comments
 (0)