Skip to content

Commit d8b439e

Browse files
committed
Address a theorically still possible non HTTP case
1 parent 09719a3 commit d8b439e

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

testssl.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17200,7 +17200,7 @@ run_renego() {
1720017200
# Connection could be closed by the server with 0 return value. We do one more iteration to not close
1720117201
# s_client STDIN too early as the close could come at any time and race with the tear down of s_client.
1720217202
# See https://github.com/drwetter/testssl.sh/issues/2590
17203-
# In this case the added iteration is harmfull as it will just spin in backgroup
17203+
# In this case the added iteration is harmless as it will just spin in backgroup
1720417204
for ((i=0; i <= ssl_reneg_attempts; i++ )); do sleep $ssl_reneg_wait; echo R; k=0; \
1720517205
# 0 means client is renegotiating & doesn't return an error --> vuln!
1720617206
# 1 means client tried to renegotiating but the server side errored then. You still see RENEGOTIATING in the output
@@ -17230,11 +17230,16 @@ run_renego() {
1723017230
if (tail -5 $TMPFILE| grep -qa '^closed'); then
1723117231
tmp_result=1
1723217232
fi
17233+
# timeout reached ?
1723317234
if [[ -f $TEMPDIR/was_killed ]]; then
1723417235
tmp_result=2
1723517236
rm -f $TEMPDIR/was_killed
1723617237
fi
1723717238
if [[ $SERVICE != HTTP ]]; then
17239+
# theoric possible case
17240+
if [[ $loop_reneg -eq 2 ]];
17241+
$tmp_result=0
17242+
fi
1723817243
case $tmp_result in
1723917244
0) pr_svrty_medium "VULNERABLE (NOT ok)"; outln ", potential DoS threat"
1724017245
fileout "$jsonID" "MEDIUM" "VULNERABLE, potential DoS threat" "$cve" "$cwe" "$hint"

0 commit comments

Comments
 (0)