Merge pull request #2660 from testssl/rm_comment

drwetter · web-flow · commit 74209e05de8c · 2025-02-17T15:39:26.000+01:00
Remove obsolete comment that SNI is not needed for ticketbleed
diff --git a/testssl.sh b/testssl.sh
@@ -16991,8 +16991,6 @@ run_ticketbleed() {
 
      #FIXME: we likely have done this already before (either @ run_server_defaults() or at least the output
      #       from a previous handshake) --> would save 1x connect. We have TLS_TICKET but not yet the ticket itself #FIXME
-     #ATTENTION: we DO NOT use SNI here as we assume ticketbleed is a vulnerability of the TLS stack. If we'd do SNI here, we'd also need
-     #           it in the ClientHello of run_ticketbleed() otherwise the ticket will be different and the whole thing won't work!
      #
      $OPENSSL s_client $(s_client_options "$BUGS $tls_proto $PROXY $SNI -connect $NODEIP:$PORT") </dev/null >$TMPFILE 2>$ERRFILE
      sclient_connect_successful $? "$TMPFILE"

Original file line number	Diff line number	Diff line change
`@@ -16991,8 +16991,6 @@ run_ticketbleed() {`
`16991`	`16991`
`16992`	`16992`	`#FIXME: we likely have done this already before (either @ run_server_defaults() or at least the output`
`16993`	`16993`	`# from a previous handshake) --> would save 1x connect. We have TLS_TICKET but not yet the ticket itself #FIXME`
`16994`		`- #ATTENTION: we DO NOT use SNI here as we assume ticketbleed is a vulnerability of the TLS stack. If we'd do SNI here, we'd also need`
`16995`		`- # it in the ClientHello of run_ticketbleed() otherwise the ticket will be different and the whole thing won't work!`
`16996`	`16994`	`#`
`16997`	`16995`	`$OPENSSL s_client $(s_client_options "$BUGS $tls_proto $PROXY $SNI -connect $NODEIP:$PORT") </dev/null >$TMPFILE 2>$ERRFILE`
`16998`	`16996`	`sclient_connect_successful $? "$TMPFILE"`