Skip to content

Commit 6c17b66

Browse files
committed
CI fix : Cleanup
testssl.sh worked as expected. Under the hood, broken pipes are expected as part of the fast loop exit strategy that relies as little as possible on timeout detection. But under the CI, testssl.sh output is garbled by the subshells stderr outputs, catched for some reason by 'prove -v'. Simply redirecting the stderr output of the offending command to /dev/null fixes the problem.
1 parent 88856ec commit 6c17b66

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

testssl.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17173,11 +17173,6 @@ run_renego() {
1717317173
prln_warning "not having provided client certificate and private key file, the client x509-based authentication prevents this from being tested"
1717417174
fileout "$jsonID" "WARN" "not having provided client certificate and private key file, the client x509-based authentication prevents this from being tested"
1717517175
else
17176-
# # We will extensively use subshell and command pipe
17177-
# # Do not let herited pipeline error control interfere
17178-
# [[ $- == *e* ]] && restore_pipeerror=1
17179-
# [[ $restore_pipeerror == 1 ]] && set +e
17180-
# set +o pipefail
1718117176
# We will need $ERRFILE for mitigation detection
1718217177
if [[ $ERRFILE =~ dev.null ]]; then
1718317178
ERRFILE=$TEMPDIR/errorfile.txt || exit $ERR_FCREATE
@@ -17288,7 +17283,6 @@ run_renego() {
1728817283
;;
1728917284
esac
1729017285
fi
17291-
# [[ $restore_pipeerror == 1 ]] && set -e
1729217286
fi
1729317287

1729417288
#pr_bold " Insecure Client-Initiated Renegotiation " # pre-RFC 5746, CVE-2009-3555

0 commit comments

Comments
 (0)