Skip to content

Commit 30a33e9

Browse files
committed
Trailing space after value in header is fine
This fixes #2466.
1 parent e59a0f2 commit 30a33e9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

testssl.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2588,7 +2588,7 @@ match_ipv4_httpheader() {
25882588

25892589
# Exclude some headers as they are mistakenly identified as ipv4 address. Issues #158, #323.
25902590
# Also facebook used to have a CSP rule for 127.0.0.1
2591-
headers="$(grep -Evai "$excluded_header" $HEADERFILE)"
2591+
headers="$(grep -Evai "$excluded_header" $HEADERFILE 2>/dev/null)"
25922592
if [[ "$headers" =~ $ipv4address ]]; then
25932593
pr_bold " IPv4 address in header "
25942594
while read line; do
@@ -2736,6 +2736,8 @@ run_hsts() {
27362736
# strict parsing now as suggested in #2381
27372737
hsts_age_sec="${HEADERVALUE#*=}"
27382738
hsts_age_sec=${hsts_age_sec%%;*}
2739+
# see #2466
2740+
hsts_age_sec=$(strip_trailing_space "$hsts_age_sec")
27392741
if [[ $hsts_age_sec =~ \" ]]; then
27402742
# remove first an last " in $hsts_age_sec (borrowed from strip_trailing_space/strip_leading_space):
27412743
hsts_age_sec=$(printf "%s" "${hsts_age_sec#"${hsts_age_sec%%[!\"]*}"}")

0 commit comments

Comments
 (0)