Skip to content

Commit 81c7d67

Browse files
committed
Default PieChart labels to `placement="callout"
1 parent d505f8e commit 81c7d67

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

docs/src/examples/components/PieChart/labels.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
import { fruitColors } from '$lib/utils/fruits';
66
77
const placements: { label: string; value: ArcLabelPlacement }[] = [
8+
{ label: 'Callout', value: 'callout' },
89
{ label: 'Centroid', value: 'centroid' },
910
{ label: 'Centroid (rotated)', value: 'centroid-rotated' },
1011
{ label: 'Centroid (radial)', value: 'centroid-radial' },
1112
{ label: 'Inner', value: 'inner' },
1213
{ label: 'Middle', value: 'middle' },
13-
{ label: 'Outer', value: 'outer' },
14-
{ label: 'Callout', value: 'callout' }
14+
{ label: 'Outer', value: 'outer' }
1515
];
1616
17-
let placement: ArcLabelPlacement = $state('centroid');
17+
let placement: ArcLabelPlacement = $state('callout');
1818
let offset = $state(0);
1919
2020
const data = longData.filter((d) => d.year === 2019);

packages/layerchart/src/lib/components/charts/PieChart.svelte

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,11 @@
227227
...restProps
228228
}: PieChartProps<TData> = $props();
229229
230-
const labelsConfig = $derived(
231-
labels === true ? ({} as ArcLabelConfig & { value?: Accessor }) : labels || null
232-
);
230+
const labelsConfig = $derived.by<(ArcLabelConfig & { value?: Accessor }) | null>(() => {
231+
if (labels === true) return { placement: 'callout' };
232+
if (labels) return { placement: 'callout', ...labels };
233+
return null;
234+
});
233235
234236
const series = $derived(
235237
seriesProp === undefined ? [{ key: 'default', value: value }] : seriesProp

0 commit comments

Comments
 (0)