0.1.0: complete State failure lifecycle proof

[suraciii]

Goal

Prove the documented State failure rules for mutable values and Reminder turns.

Scope

• Test a mutable map or slice returned by State.Get.
• Mutate the value and make State.Set fail.
• Prove that the in-memory alias cannot be rolled back.
• Make a State write fail during a Reminder turn.
• Prove that the failed Activation is discarded and the next Call creates a new Activation.

Acceptance

• The tests use injected failures and no sleep.
• The mutable alias result matches the product contract.
• Reminder State failure faults only the affected Activation.
• The next Call reloads confirmed State from the Store.
• make ci passes.

References

state.go
state_test.go
state_failure_test.go
design/persistence.md
docs/release-0.1.0.md

[suraciii]

Issue #114 is complete in local reviewed commit 4cb95eaf778efcbaefb010f043066dfa070ee277.

Delivered:

• Added the release proof contract before the tests.
• Proved a mutable map alias through real Runtime, Ref, and Call paths. A pre-commit Store failure leaves the failed Activation alias changed, does not advance the confirmed Store JSON or ETag, discards that Activation, and makes the next Call create a new Activation that reloads Confirmed State.
• Proved an applied-then-error State write during a Reminder turn. The failure is reported as ReminderInvocation, only Alice is faulted, Bob keeps the same Activation, and the next Alice Call creates a new Activation that reloads the committed Store value.
• Used injected Store outcomes, fake clocks, and synctest; there is no sleep, retry, or wider timeout.
• Kept production code unchanged because the existing root dispatch and runtime.Discard path already satisfies the documented contract.
• Added the design decisions, rejected alternatives, review history, mutation results, and gate counts to research/release-0.1.0-issue-114-mutations.md.

Review and mutation proof:

• The first independent review found that the mutable alias test bypassed the Runtime and checked Store/ETag indirectly. The test was rebuilt on the real Runtime path with direct Store JSON/ETag and factory-count assertions.
• The follow-up review confirmed those findings were fixed and found no blocking issue. Its remaining real-clock observation was also fixed with a fake clock and disabled Reminder poller.
• JSON-copying the value returned by State.Get made the alias test fail with local value 1 instead of 2.
• Removing the root dispatch conversion to runtime.Discard made both lifecycle tests reuse the failed Activation.

Exact-commit proof after clearing the Go test cache:

• make ci: exit 0, wall 78.98 seconds. Nonzero discovery: release contract 4; normal 633; race 633; simulation 20; generator 19; network 45; example 49; both resource checks 1 each; all three fuzz checks 1 each.
• make external: exit 0, wall 29.04 seconds. Nonzero discovery: release contract 4; Quick Start 1; external configuration and restart 19.
• The two new race tests also passed 20 consecutive runs.
• Worktree /home/szf/.herdr/worktrees/gor/release-0.1-issue114-state-lifecycle is clean on branch release-0.1-issue114-state-lifecycle.

The commit is local. Remote master remains 584f008dcf04151ff88376a9cf2c75fcfcd4e050. No branch was pushed and no pull request was created. Issue #114 stays open until integration.

[suraciii]

Completed in the integrated candidate #116. Injected, sleep-free tests cover mutable State aliases, failed Set behavior, Reminder-turn State failure, affected-Activation discard, and reloading confirmed Store State on the next Call. Exact master 0c41f9f644905183d7d4fd8f7efed24e4396bf0d passed local make ci and hosted run https://github.com/suraciii/gor/actions/runs/31504300130.