Crash when playing a MIDI file in Secret Sauce

[Mohamed00]

Hi, I noticed a crash when playing this MIDI file with Secret Sauce: discou8p.zip.
This crash is caused by a sysex on track 17. f0 41 10 42 11 40 01 3a 5a 2b f7.
This sysex might be slightly malformed. It's attempting to read the chorus level parameter at 40 01 3a with a size of 90 bytes, but it actually has a size of 1, so the author may have intended to write 12 40 01 3a.
Technically the crash is correct behavior. The file crashes the real SC-8820 as well.
But it would be nice to synchronize Secret Sauce's behavior with the official plug-in, which blocks data reads.
According to the SC-8850 manual, data requests are indicated by f0 41 10 42 11 in sysex messages.

[stuerp]

Thx. for reporting it. I'll look at.

[stuerp]

Hi, I noticed a crash when playing this MIDI file with Secret Sauce: discou8p.zip. This crash is caused by a sysex on track 17. f0 41 10 42 11 40 01 3a 5a 2b f7. This sysex might be slightly malformed. It's attempting to read the chorus level parameter at 40 01 3a with a size of 90 bytes, but it actually has a size of 1, so the author may have intended to write 12 40 01 3a. Technically the crash is correct behavior. The file crashes the real SC-8820 as well. But it would be nice to synchronize Secret Sauce's behavior with the official plug-in, which blocks data reads. According to the SC-8850 manual, data requests are indicated by f0 41 10 42 11 in sysex messages.

Have you set any special settings in the plug-in? I'm unable to reproduce the crash.

[Mohamed00]

I think that might be because scpipe is trying to restart the plug-in.
Try listening at 0:16.
If you hear a random out of tune trumpet note, that means the core has crashed.
Here are two renders of the file, one with the crash, and another playing a fixed version of the file with the problematic sysex removed. In the good version, the guitar is also much louder and is panned to the right. discou8prender.zip

[stuerp]

I see. Yes, I did hear strange instrument noises. But from the way you worded the issue I expected a hard crash.

You're right: the RQ1 should probably be a DT1.

So, the fix would be: don't send RQ1 to Secret Sauce?

[Mohamed00]

It seems so, yes.
I tried correcting the sysex to read 1 byte, but it still crashed.
I've also managed to crash it by reading other parameters in the address map.

[stuerp]

I changed the behavior in the next alpha release. The SC-55 CLAP plugin does not seem to have problem with the malformed SysEx.

[Mohamed00]

Yep, this is a bug that specifically occurs on the SC-8820.
The earlier SC-8850, as well as the SC-88Pro which this file was originally written for, don't have this problem.