Skip to content
This repository was archived by the owner on Dec 12, 2018. It is now read-only.

Commit 843d37a

Browse files
author
Richard Blaylock
committed
Issue-1136 Rename for consistency.
1 parent b548439 commit 843d37a

4 files changed

Lines changed: 17 additions & 17 deletions

File tree

api/src/main/java/com/stormpath/sdk/saml/SamlResponseRequest.java renamed to api/src/main/java/com/stormpath/sdk/saml/CreateSamlResponseRequest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*
1111
* @since 1.3.0
1212
*/
13-
public interface SamlResponseRequest extends Resource {
13+
public interface CreateSamlResponseRequest extends Resource {
1414

1515
/**
1616
* Returns the {@link Account} to be represented in this SAML response.
@@ -25,7 +25,7 @@ public interface SamlResponseRequest extends Resource {
2525
* @param account the {@link Account} to be represented in this SAML response.
2626
* @return this instance for method chaining.
2727
*/
28-
SamlResponseRequest setAccount(Account account);
28+
CreateSamlResponseRequest setAccount(Account account);
2929

3030
/**
3131
* Returns the {@link RegisteredSamlServiceProvider} to be represented in this SAML response.
@@ -40,7 +40,7 @@ public interface SamlResponseRequest extends Resource {
4040
* @param serviceProvider the {@link RegisteredSamlServiceProvider} to be represented in this SAML response.
4141
* @return this instance for method chaining.
4242
*/
43-
SamlResponseRequest setServiceProvider(RegisteredSamlServiceProvider serviceProvider);
43+
CreateSamlResponseRequest setServiceProvider(RegisteredSamlServiceProvider serviceProvider);
4444

4545
/**
4646
* Returns the request ID to be represented in this SAML response, which should match the request ID
@@ -57,7 +57,7 @@ public interface SamlResponseRequest extends Resource {
5757
* @param requestId the request ID to be represented in this SAML response.
5858
* @return this instance for method chaining.
5959
*/
60-
SamlResponseRequest setRequestId(String requestId);
60+
CreateSamlResponseRequest setRequestId(String requestId);
6161

6262
/**
6363
* Returns the issue instant to be represented in this SAML response, which should match the issue instant
@@ -74,5 +74,5 @@ public interface SamlResponseRequest extends Resource {
7474
* @param authnIssueInstant the issue instant to be represented in this SAML response.
7575
* @return this instance for method chaining.
7676
*/
77-
SamlResponseRequest setAuthnIssueInstant(Date authnIssueInstant);
77+
CreateSamlResponseRequest setAuthnIssueInstant(Date authnIssueInstant);
7878
}

‎api/src/main/java/com/stormpath/sdk/saml/SamlIdentityProvider.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,11 @@ public interface SamlIdentityProvider extends Resource, Saveable, Deletable, Aud
207207
AuthnVerification createAuthnVerification(AuthnVerificationRequest request);
208208

209209
/**
210-
* Given a {@link SamlResponseRequest} for a given {@link com.stormpath.sdk.account.Account} and {@link RegisteredSamlServiceProvider},
210+
* Given a {@link CreateSamlResponseRequest} for a given {@link com.stormpath.sdk.account.Account} and {@link RegisteredSamlServiceProvider},
211211
* creates a {@link SamlResponse} wrapping the XML of the SAML response to be returned to the service provider.
212212
*
213-
* @param samlResponseRequest a {@link SamlResponseRequest} wrapping the values needed to prepare the SAML response.
213+
* @param samlResponseRequest a {@link CreateSamlResponseRequest} wrapping the values needed to prepare the SAML response.
214214
* @return a {@link SamlResponse} wrapping the XML of the SAML response to be returned to the service provider.
215215
*/
216-
SamlResponse createSamlResponse(SamlResponseRequest samlResponseRequest);
216+
SamlResponse createSamlResponse(CreateSamlResponseRequest samlResponseRequest);
217217
}

impl/src/main/java/com/stormpath/sdk/impl/saml/DefaultSamlResponseRequest.java renamed to impl/src/main/java/com/stormpath/sdk/impl/saml/DefaultCreateSamlResponseRequest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
import com.stormpath.sdk.impl.resource.ResourceReference;
99
import com.stormpath.sdk.impl.resource.StringProperty;
1010
import com.stormpath.sdk.saml.RegisteredSamlServiceProvider;
11-
import com.stormpath.sdk.saml.SamlResponseRequest;
11+
import com.stormpath.sdk.saml.CreateSamlResponseRequest;
1212

1313
import java.util.Date;
1414
import java.util.Map;
1515

16-
public class DefaultSamlResponseRequest extends AbstractResource implements SamlResponseRequest {
16+
public class DefaultCreateSamlResponseRequest extends AbstractResource implements CreateSamlResponseRequest {
1717
static final ResourceReference<Account> ACCOUNT = new ResourceReference<>("account", Account.class);
1818
static final ResourceReference<RegisteredSamlServiceProvider> SERVICE_PROVIDER = new ResourceReference<>("serviceProvider", RegisteredSamlServiceProvider.class);
1919
static final StringProperty REQUEST_ID = new StringProperty("requestId");
@@ -25,11 +25,11 @@ public class DefaultSamlResponseRequest extends AbstractResource implements Saml
2525
PROPERTY_DESCRIPTORS = createPropertyDescriptorMap(new Property[] { ACCOUNT, SERVICE_PROVIDER, REQUEST_ID, AUTHN_ISSUE_INSTANT });
2626
}
2727

28-
public DefaultSamlResponseRequest(InternalDataStore dataStore) {
28+
public DefaultCreateSamlResponseRequest(InternalDataStore dataStore) {
2929
super(dataStore);
3030
}
3131

32-
public DefaultSamlResponseRequest(InternalDataStore dataStore, Map<String, Object> properties) {
32+
public DefaultCreateSamlResponseRequest(InternalDataStore dataStore, Map<String, Object> properties) {
3333
super(dataStore, properties);
3434
}
3535

@@ -44,7 +44,7 @@ public Account getAccount() {
4444
}
4545

4646
@Override
47-
public SamlResponseRequest setAccount(Account account) {
47+
public CreateSamlResponseRequest setAccount(Account account) {
4848
setResourceProperty(ACCOUNT, account);
4949
return this;
5050
}
@@ -55,7 +55,7 @@ public RegisteredSamlServiceProvider getServiceProvider() {
5555
}
5656

5757
@Override
58-
public SamlResponseRequest setServiceProvider(RegisteredSamlServiceProvider serviceProvider) {
58+
public CreateSamlResponseRequest setServiceProvider(RegisteredSamlServiceProvider serviceProvider) {
5959
setResourceProperty(SERVICE_PROVIDER, serviceProvider);
6060
return this;
6161
}
@@ -66,7 +66,7 @@ public String getRequestId() {
6666
}
6767

6868
@Override
69-
public SamlResponseRequest setRequestId(String requestId) {
69+
public CreateSamlResponseRequest setRequestId(String requestId) {
7070
setProperty(REQUEST_ID, requestId);
7171
return this;
7272
}
@@ -77,7 +77,7 @@ public Date getAuthnIssueInstant() {
7777
}
7878

7979
@Override
80-
public SamlResponseRequest setAuthnIssueInstant(Date authnIssueInstant) {
80+
public CreateSamlResponseRequest setAuthnIssueInstant(Date authnIssueInstant) {
8181
setProperty(AUTHN_ISSUE_INSTANT, authnIssueInstant);
8282
return this;
8383
}

‎impl/src/main/java/com/stormpath/sdk/impl/saml/DefaultSamlIdentityProvider.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ public AuthnVerification createAuthnVerification(AuthnVerificationRequest reques
191191
}
192192

193193
@Override
194-
public SamlResponse createSamlResponse(SamlResponseRequest samlResponseRequest) {
194+
public SamlResponse createSamlResponse(CreateSamlResponseRequest samlResponseRequest) {
195195
String samlResponsesHref = getHref() + "/samlResponses";
196196
return getDataStore().create(samlResponsesHref, samlResponseRequest, SamlResponse.class);
197197
}

0 commit comments

Comments
 (0)