feat(divisions): add endpoint to list all division airport requests

Author: AussieScorcher

data/openapi.json

@@ -1971,6 +1971,30 @@
 				}
 			}
 		},
+		"/staff/divisions/airports": {
+			"get": {
+				"x-hidden": true,
+				"summary": "List all division airport requests (staff)",
+				"tags": ["Staff", "Divisions"],
+				"description": "Returns every division airport request with division metadata. Requires Product Manager or higher.",
+				"security": [
+					{
+						"VatsimToken": []
+					}
+				],
+				"responses": {
+					"200": {
+						"description": "Division airports listed"
+					},
+					"401": {
+						"description": "Unauthorized"
+					},
+					"403": {
+						"description": "Forbidden"
+					}
+				}
+			}
+		},
 		"/contributions": {
 			"get": {
 				"summary": "List contributions",

src/index.ts

@@ -3639,6 +3639,69 @@ staffManageApp.delete('/:vatsimId', async (c) => {
 
 app.route('/staff/manage', staffManageApp);
 
+const staffDivisionsApp = new Hono<{
+	Bindings: Env;
+	Variables: {
+		user?: UserRecord;
+	};
+}>();
+
+staffDivisionsApp.use('*', async (c, next) => {
+	const vatsimToken = c.req.header('X-Vatsim-Token');
+	if (!vatsimToken) return c.text('Unauthorized', 401);
+
+	const vatsim = ServicePool.getVatsim(c.env);
+	const auth = ServicePool.getAuth(c.env);
+	const roles = ServicePool.getRoles(c.env);
+
+	const vatsimUser = await vatsim.getUser(vatsimToken);
+	const user = await auth.getUserByVatsimId(vatsimUser.id);
+	if (!user) return c.text('User not found', 404);
+
+	const allowed = await roles.hasPermission(user.id, StaffRole.PRODUCT_MANAGER);
+	if (!allowed) return c.text('Forbidden', 403);
+
+	c.set('user', user);
+	await next();
+});
+
+/**
+ * @openapi
+ * /staff/divisions/airports:
+ *   get:
+ *     x-hidden: true
+ *     summary: List all division airport requests (staff)
+ *     tags:
+ *       - Staff
+ *       - Divisions
+ *     description: Returns every division airport request with division metadata. Requires Product Manager or higher.
+ *     security:
+ *       - VatsimToken: []
+ *     responses:
+ *       200:
+ *         description: Division airports listed
+ *       401:
+ *         description: Unauthorized
+ *       403:
+ *         description: Forbidden
+ */
+staffDivisionsApp.get('/airports', async (c) => {
+	const divisions = ServicePool.getDivisions(c.env);
+	const airports = await divisions.getAllDivisionAirports();
+	const shaped = airports.map((airport) => ({
+		division_id: airport.division_id,
+		division_name: airport.division_name,
+		airport_request_id: airport.id,
+		icao: airport.icao,
+		status: airport.status,
+		requested_by: airport.requested_by,
+		approved_by: airport.approved_by ?? null,
+	}));
+	return c.json({ airports: shaped });
+});
+
+app.route('/staff/divisions', staffDivisionsApp);
+
 // Contributions endpoints
 const contributionsApp = new Hono<{ Bindings: Env }>();
 

src/services/divisions.ts

@@ -27,6 +27,10 @@ interface DivisionAirport {
 	updated_at: string;
 }
 
+type DivisionAirportWithDivision = DivisionAirport & {
+	division_name: string;
+};
+
 export class DivisionService {
 	private dbSession: DatabaseSessionService;
 
@@ -279,6 +283,40 @@ export class DivisionService {
 			}));
 	}
 
+	async getAllDivisionAirports(): Promise<DivisionAirportWithDivision[]> {
+		const result = await this.dbSession.executeRead<
+			DivisionAirportWithDivision & {
+				division_name: string | null;
+			}
+		>(
+			`SELECT
+				da.id,
+				da.division_id,
+				d.name AS division_name,
+				da.icao,
+				da.status,
+				da.requested_by,
+				da.approved_by,
+				da.created_at,
+				da.updated_at
+			FROM division_airports da
+			JOIN divisions d ON d.id = da.division_id
+			ORDER BY d.name ASC, da.created_at DESC`,
+		);
+
+		return result.results.map((row) => ({
+			id: row.id,
+			division_id: row.division_id,
+			division_name: row.division_name ?? '',
+			icao: row.icao,
+			status: row.status,
+			requested_by: row.requested_by,
+			approved_by: row.approved_by ?? undefined,
+			created_at: row.created_at,
+			updated_at: row.updated_at,
+		}));
+	}
+
 	async getDivisionMembers(divisionId: number): Promise<(DivisionMember & { display_name: string })[] | null> {
 		type DivisionMemberRow = {
 			division_exists: number | null;