Merge pull request #3195 from stan-dev/fix-promote-scalar-exception

Author: WardBrian

stan/math/mix/functor/laplace_marginal_density.hpp

@@ -314,7 +314,9 @@ inline void set_zero_adjoint(Output&& output) {
             static_assert(
                 sizeof(std::decay_t<output_i_t>*) == 0,
                 "INTERNAL ERROR:(laplace_marginal_lpdf) set_zero_adjoints was "
-                "not able to deduce the actions needed for the given type.");
+                "not able to deduce the actions needed for the given type. "
+                "This is an internal error, please report it: "
+                "https://github.com/stan-dev/math/issues");
           }
         },
         std::forward<Output>(output));
@@ -359,7 +361,9 @@ inline void collect_adjoints(Output& output, Input&& input) {
           static_assert(
               sizeof(std::decay_t<output_i_t>*) == 0,
               "INTERNAL ERROR:(laplace_marginal_lpdf) set_zero_adjoints was "
-              "not able to deduce the actions needed for the given type.");
+              "not able to deduce the actions needed for the given type. "
+              "This is an internal error, please report it: "
+              "https://github.com/stan-dev/math/issues");
         }
       },
       std::forward<Output>(output), std::forward<Input>(input));
@@ -813,7 +817,9 @@ inline void collect_adjoints(Output&& output, Input&& input) {
           static_assert(
               sizeof(std::decay_t<output_i_t>*) == 0,
               "INTERNAL ERROR:(laplace_marginal_lpdf) set_zero_adjoints was "
-              "not able to deduce the actions needed for the given type.");
+              "not able to deduce the actions needed for the given type. "
+              "This is an internal error, please report it: "
+              "https://github.com/stan-dev/math/issues");
         }
       },
       std::forward<Output>(output), std::forward<Input>(input));
@@ -863,7 +869,9 @@ inline void copy_compute_s2(Output&& output, Input&& input) {
           static_assert(
               sizeof(std::decay_t<output_i_t>*) == 0,
               "INTERNAL ERROR:(laplace_marginal_lpdf) set_zero_adjoints was "
-              "not able to deduce the actions needed for the given type.");
+              "not able to deduce the actions needed for the given type. "
+              "This is an internal error, please report it: "
+              "https://github.com/stan-dev/math/issues");
         }
       },
       std::forward<Output>(output), std::forward<Input>(input));
@@ -920,11 +928,11 @@ template <typename Output, typename Input>
 inline void collect_adjoints(Output&& output, const vari* ret, Input&& input) {
   if constexpr (is_tuple_v<Output>) {
     static_assert(sizeof(std::decay_t<Output>*) == 0,
-                  "INTERNAL ERROR:(laplace_marginal_lpdf)"
+                  "INTERNAL ERROR:(laplace_marginal_lpdf) "
                   "Accumulate Adjoints called on a tuple, but tuples cannot be "
-                  "on the reverse mode stack!"
-                  "This is an internal error, please report it to the stan "
-                  "github as an issue.");
+                  "on the reverse mode stack! "
+                  "This is an internal error, please report it: "
+                  "https://github.com/stan-dev/math/issues");
   } else if constexpr (is_std_vector_v<Output>) {
     if constexpr (!is_var_v<value_type_t<Output>>) {
       const auto output_size = output.size();

stan/math/prim/fun/promote_scalar.hpp

@@ -44,9 +44,11 @@ inline constexpr auto promote_scalar(UnPromotedTypes&& x) {
   } else if constexpr (is_stan_scalar_v<UnPromotedTypes>) {
     return PromotionScalars(std::forward<UnPromotedTypes>(x));
   } else {
-    throw std::domain_error(
-        "promote_scalar: "
-        "Unrecognized type for promotion");
+    static_assert(sizeof(std::decay_t<UnPromotedTypes>*) == 0,
+                  "INTERNAL ERROR:(promote_scalar) "
+                  "Unrecognized type for promotion. "
+                  "This is an internal error, please report it: "
+                  "https://github.com/stan-dev/math/issues");
   }
 }
 

test/unit/math/laplace/laplace_utility.hpp

@@ -252,7 +252,9 @@ inline void print_adjoint(Output&& output) {
   } else {
     static_assert(sizeof(Output*) == 0,
                   "INTERNAL ERROR:(laplace_marginal_lpdf) print_adjoint was "
-                  "not able to deduce the actiopns needed for the given type.");
+                  "not able to deduce the actiopns needed for the given type. "
+                  "This is an internal error, please report it: "
+                  "https://github.com/stan-dev/math/issues");
   }
 }