|
| 1 | +package promote |
| 2 | + |
| 3 | +import ( |
| 4 | + "testing" |
| 5 | + |
| 6 | + "github.com/stablekernel/cascade/internal/config" |
| 7 | + "github.com/stretchr/testify/require" |
| 8 | +) |
| 9 | + |
| 10 | +// newDowngradePreflighter builds a Preflighter wired with the given env state and |
| 11 | +// the allow-downgrade flag, so checkDowngrade can be exercised in isolation. |
| 12 | +func newDowngradePreflighter(t *testing.T, state map[string]*config.EnvState, allow bool) *Preflighter { |
| 13 | + t.Helper() |
| 14 | + cfg := &config.CICDFile{ |
| 15 | + Config: &config.TrunkConfig{ |
| 16 | + Environments: []string{"dev", "test", "uat", "prod"}, |
| 17 | + Deploys: []config.DeployConfig{{Name: "app"}}, |
| 18 | + }, |
| 19 | + State: state, |
| 20 | + } |
| 21 | + return NewPreflighter(PreflighterOptions{ |
| 22 | + Config: cfg, |
| 23 | + Mode: ModeDefault, |
| 24 | + BaseDir: "", |
| 25 | + AllowDowngrade: allow, |
| 26 | + }) |
| 27 | +} |
| 28 | + |
| 29 | +func TestCheckDowngrade_ForwardPromotion_Passes(t *testing.T) { |
| 30 | + p := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 31 | + "test": {Version: "v1.0.0"}, |
| 32 | + }, false) |
| 33 | + result := &PreflightResult{SourceVersion: "v1.1.0"} |
| 34 | + promotions := []EnvPromotion{{Environment: "test"}} |
| 35 | + |
| 36 | + err := p.checkDowngrade(promotions, result, "prod") |
| 37 | + require.NoError(t, err) |
| 38 | + require.Empty(t, result.Warnings) |
| 39 | +} |
| 40 | + |
| 41 | +func TestCheckDowngrade_EqualVersion_Passes(t *testing.T) { |
| 42 | + p := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 43 | + "test": {Version: "v1.0.0"}, |
| 44 | + }, false) |
| 45 | + result := &PreflightResult{SourceVersion: "v1.0.0"} |
| 46 | + promotions := []EnvPromotion{{Environment: "test"}} |
| 47 | + |
| 48 | + err := p.checkDowngrade(promotions, result, "prod") |
| 49 | + require.NoError(t, err) |
| 50 | + require.Empty(t, result.Warnings) |
| 51 | +} |
| 52 | + |
| 53 | +func TestCheckDowngrade_Downgrade_BlockedWithoutFlag(t *testing.T) { |
| 54 | + p := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 55 | + "test": {Version: "v1.2.0"}, |
| 56 | + }, false) |
| 57 | + result := &PreflightResult{SourceVersion: "v1.1.0"} |
| 58 | + promotions := []EnvPromotion{{Environment: "test"}} |
| 59 | + |
| 60 | + err := p.checkDowngrade(promotions, result, "prod") |
| 61 | + require.Error(t, err) |
| 62 | + require.Contains(t, err.Error(), "test") |
| 63 | + require.Contains(t, err.Error(), "v1.2.0") |
| 64 | + require.Contains(t, err.Error(), "v1.1.0") |
| 65 | + require.Contains(t, err.Error(), "--allow-downgrade") |
| 66 | +} |
| 67 | + |
| 68 | +func TestCheckDowngrade_Downgrade_AllowedWithFlag(t *testing.T) { |
| 69 | + p := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 70 | + "test": {Version: "v1.2.0"}, |
| 71 | + }, true) |
| 72 | + result := &PreflightResult{SourceVersion: "v1.1.0"} |
| 73 | + promotions := []EnvPromotion{{Environment: "test"}} |
| 74 | + |
| 75 | + err := p.checkDowngrade(promotions, result, "prod") |
| 76 | + require.NoError(t, err) |
| 77 | + require.Len(t, result.Warnings, 1) |
| 78 | + require.Contains(t, result.Warnings[0], "test") |
| 79 | + require.Contains(t, result.Warnings[0], "v1.2.0") |
| 80 | + require.Contains(t, result.Warnings[0], "v1.1.0") |
| 81 | +} |
| 82 | + |
| 83 | +func TestCheckDowngrade_ProdDowngrade_AlwaysRequiresFlag(t *testing.T) { |
| 84 | + // Without the flag, a prod downgrade is blocked. |
| 85 | + p := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 86 | + "prod": {Version: "v2.0.0"}, |
| 87 | + }, false) |
| 88 | + result := &PreflightResult{SourceVersion: "v1.9.0"} |
| 89 | + promotions := []EnvPromotion{{Environment: "prod"}} |
| 90 | + |
| 91 | + err := p.checkDowngrade(promotions, result, "prod") |
| 92 | + require.Error(t, err) |
| 93 | + require.Contains(t, err.Error(), "prod") |
| 94 | + require.Contains(t, err.Error(), "v2.0.0") |
| 95 | + require.Contains(t, err.Error(), "v1.9.0") |
| 96 | + require.Contains(t, err.Error(), "--allow-downgrade") |
| 97 | + |
| 98 | + // With the flag, a prod downgrade is permitted but warned. |
| 99 | + pAllow := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 100 | + "prod": {Version: "v2.0.0"}, |
| 101 | + }, true) |
| 102 | + resultAllow := &PreflightResult{SourceVersion: "v1.9.0"} |
| 103 | + err = pAllow.checkDowngrade(promotions, resultAllow, "prod") |
| 104 | + require.NoError(t, err) |
| 105 | + require.Len(t, resultAllow.Warnings, 1) |
| 106 | + require.Contains(t, resultAllow.Warnings[0], "prod") |
| 107 | + require.Contains(t, resultAllow.Warnings[0], "v2.0.0") |
| 108 | + require.Contains(t, resultAllow.Warnings[0], "v1.9.0") |
| 109 | +} |
| 110 | + |
| 111 | +func TestCheckDowngrade_NonSemver_WarnsAndAllows(t *testing.T) { |
| 112 | + // Current version is non-semver: fail-open with a warning naming both |
| 113 | + // versions and the env, and proceed. |
| 114 | + p := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 115 | + "test": {Version: "not-a-version"}, |
| 116 | + }, false) |
| 117 | + result := &PreflightResult{SourceVersion: "v1.1.0"} |
| 118 | + promotions := []EnvPromotion{{Environment: "test"}} |
| 119 | + |
| 120 | + err := p.checkDowngrade(promotions, result, "prod") |
| 121 | + require.NoError(t, err) |
| 122 | + require.Len(t, result.Warnings, 1) |
| 123 | + require.Contains(t, result.Warnings[0], "test") |
| 124 | + require.Contains(t, result.Warnings[0], "not-a-version") |
| 125 | + require.Contains(t, result.Warnings[0], "v1.1.0") |
| 126 | + |
| 127 | + // Incoming version is non-semver: also fail-open with a warning. |
| 128 | + p2 := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 129 | + "test": {Version: "v1.1.0"}, |
| 130 | + }, false) |
| 131 | + result2 := &PreflightResult{SourceVersion: "garbage"} |
| 132 | + err = p2.checkDowngrade(promotions, result2, "prod") |
| 133 | + require.NoError(t, err) |
| 134 | + require.Len(t, result2.Warnings, 1) |
| 135 | + require.Contains(t, result2.Warnings[0], "test") |
| 136 | + require.Contains(t, result2.Warnings[0], "v1.1.0") |
| 137 | + require.Contains(t, result2.Warnings[0], "garbage") |
| 138 | +} |
| 139 | + |
| 140 | +func TestCheckDowngrade_EmptyVersions_Skipped(t *testing.T) { |
| 141 | + // Empty current version: skipped, no error, no warning. |
| 142 | + p := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 143 | + "test": {Version: ""}, |
| 144 | + }, false) |
| 145 | + result := &PreflightResult{SourceVersion: "v1.1.0"} |
| 146 | + promotions := []EnvPromotion{{Environment: "test"}} |
| 147 | + |
| 148 | + err := p.checkDowngrade(promotions, result, "prod") |
| 149 | + require.NoError(t, err) |
| 150 | + require.Empty(t, result.Warnings) |
| 151 | + |
| 152 | + // Empty source version: skipped too. |
| 153 | + p2 := newDowngradePreflighter(t, map[string]*config.EnvState{ |
| 154 | + "test": {Version: "v1.1.0"}, |
| 155 | + }, false) |
| 156 | + result2 := &PreflightResult{SourceVersion: ""} |
| 157 | + err = p2.checkDowngrade(promotions, result2, "prod") |
| 158 | + require.NoError(t, err) |
| 159 | + require.Empty(t, result2.Warnings) |
| 160 | +} |
0 commit comments