Add PHP8 testing support

- Also upgrade psalm
- Add missing rulesets for PHPCS
- Upgrade PHPCS rules

Author: iquito

.travis.yml

@@ -2,11 +2,13 @@ env:
     global:
         - CC_TEST_REPORTER_ID=300652b345e59425b0203fd817ea93f39a436ef531b5731f0378b5ec3c755d33
         - GIT_COMMITTED_AT=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then git log -1 --pretty=format:%ct; else git log -1 --skip 1 --pretty=format:%ct; fi)
+        - XDEBUG_MODE=coverage
 language: php
 php:
     - '7.2'
     - '7.3'
     - '7.4'
+    - '8.0'
 
 before_script:
     - composer self-update

composer.json

@@ -22,7 +22,8 @@
     },
     "require-dev": {
         "bamarni/composer-bin-plugin": "^1.3",
-        "captainhook/plugin-composer": "^5.0"
+        "captainhook/plugin-composer": "^5.0",
+        "phpunit/phpunit": "^8.0|^9.0"
     },
     "config": {
         "sort-packages": false,
@@ -42,14 +43,14 @@
     },
     "scripts": {
         "phpstan": "vendor/bin/phpstan analyse",
+        "phpstan_full": "vendor/bin/phpstan clear-result-cache && vendor/bin/phpstan analyse",
         "phpstan_base": "vendor/bin/phpstan analyse --generate-baseline",
-        "phpstan_clear": "vendor/bin/phpstan clear-result-cache",
-        "psalm": "vendor/bin/psalm --show-info=false --diff",
-        "psalm_full": "vendor/bin/psalm --show-info=false",
+        "psalm": "vendor/bin/psalm --show-info=false",
+        "psalm_full": "vendor/bin/psalm --clear-cache && vendor/bin/psalm --show-info=false",
         "psalm_base": "vendor/bin/psalm --set-baseline=psalm-baseline.xml",
         "phpunit": "vendor/bin/phpunit --colors=always",
         "phpunit_clover": "vendor/bin/phpunit --coverage-text --coverage-clover build/logs/clover.xml",
-        "codecoverage": "vendor/bin/phpunit --coverage-html tests/_reports",
+        "coverage": "vendor/bin/phpunit --coverage-html tests/_reports",
         "phpcs": "vendor/bin/phpcs --standard=ruleset.xml --extensions=php --cache=.phpcs-cache --colors src tests",
         "phpcsfix": "vendor/bin/phpcbf --standard=ruleset.xml --extensions=php --cache=.phpcs-cache src tests",
         "binupdate": "@composer bin all update --ansi",

psalm-baseline.xml

@@ -1,16 +1,27 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="3.11.2@d470903722cfcbc1cd04744c5491d3e6d13ec3d9">
+<files psalm-version="4.3.1@2feba22a005a18bf31d4c7b9bdb9252c73897476">
+  <file src="src/PhpSyntaxExtension.php">
+    <InternalClass occurrences="4">
+      <code>ExpressionParser::OPERATOR_LEFT</code>
+      <code>ExpressionParser::OPERATOR_LEFT</code>
+      <code>ExpressionParser::OPERATOR_LEFT</code>
+      <code>ExpressionParser::OPERATOR_LEFT</code>
+    </InternalClass>
+  </file>
   <file src="src/TokenParser/BreakOrContinueTokenParser.php">
     <InternalMethod occurrences="3">
       <code>getSourceContext</code>
       <code>getSourceContext</code>
       <code>getSourceContext</code>
     </InternalMethod>
+    <UnsafeInstantiation occurrences="1">
+      <code>new $nodeClass($loopNumber, $lineno, $this-&gt;getTag())</code>
+    </UnsafeInstantiation>
   </file>
   <file src="src/TokenParser/ForeachTokenParser.php">
     <InternalMethod occurrences="2">
-      <code>parseExpression</code>
       <code>getSourceContext</code>
+      <code>parseExpression</code>
     </InternalMethod>
   </file>
 </files>

ruleset.xml

@@ -37,4 +37,24 @@
         </properties>
     </rule>
     <rule ref="SlevomatCodingStandard.Commenting.EmptyComment"/>
+    <rule ref="SlevomatCodingStandard.Arrays.DisallowImplicitArrayCreation"/>
+    <rule ref="SlevomatCodingStandard.Functions.StrictCall"/>
+    <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators"/>
+    <rule ref="SlevomatCodingStandard.PHP.DisallowReference"/>
+    <rule ref="SlevomatCodingStandard.PHP.UselessSemicolon"/>
+    <rule ref="SlevomatCodingStandard.Variables.DisallowSuperGlobalVariable"/>
+    <rule ref="SlevomatCodingStandard.ControlStructures.NewWithParentheses"/>
+    <rule ref="SlevomatCodingStandard.Functions.DisallowEmptyFunction"/>
+    <!--<rule ref="SlevomatCodingStandard.Functions.TrailingCommaInCall"/>-->
+    <rule ref="SlevomatCodingStandard.TypeHints.LongTypeHints"/>
+    <rule ref="SlevomatCodingStandard.PHP.ShortList"/>
+    <rule ref="SlevomatCodingStandard.PHP.TypeCast"/>
+    <rule ref="SlevomatCodingStandard.Classes.ClassConstantVisibility"/>
+    <rule ref="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/>
+    <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing"/>
+    <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHintSpacing"/>
+    <rule ref="SlevomatCodingStandard.Namespaces.MultipleUsesPerLine"/>
+    <rule ref="SlevomatCodingStandard.Namespaces.UseDoesNotStartWithBackslash"/>
+    <rule ref="SlevomatCodingStandard.Classes.DisallowLateStaticBindingForConstants"/>
+    <rule ref="SlevomatCodingStandard.Classes.UselessLateStaticBinding"/>
 </ruleset>

vendor-bin/phpcs/composer.json

@@ -1,6 +1,6 @@
 {
     "require": {
         "squizlabs/php_codesniffer": "^3.5",
-        "slevomat/coding-standard": "^5.0"
+        "slevomat/coding-standard": "^6.0"
     }
 }

vendor-bin/phpunit/composer.json

@@ -1,5 +1,5 @@
 {
     "require": {
-        "vimeo/psalm": "^3.7"
+        "vimeo/psalm": "^4.0"
     }
 }