chore: migrate to rust 2024 by fixing implicit borrows and unsafe env modifications

Author: lovasoa

src/app_config.rs

@@ -774,7 +774,7 @@ mod test {
         let _lock = ENV_LOCK
             .lock()
             .expect("Another test panicked while holding the lock");
-        env::set_var("SQLPAGE_CONFIGURATION_DIRECTORY", "/path/to/config");
+        unsafe { env::set_var("SQLPAGE_CONFIGURATION_DIRECTORY", "/path/to/config"); }
 
         let config = load_from_env().unwrap();
 
@@ -784,41 +784,41 @@ mod test {
             "Configuration directory should match the SQLPAGE_CONFIGURATION_DIRECTORY env var"
         );
 
-        env::remove_var("SQLPAGE_CONFIGURATION_DIRECTORY");
+        unsafe { env::remove_var("SQLPAGE_CONFIGURATION_DIRECTORY"); }
     }
 
     #[test]
     fn test_k8s_env_var_ignored() {
         let _lock = ENV_LOCK
             .lock()
             .expect("Another test panicked while holding the lock");
-        env::set_var("SQLPAGE_PORT", "tcp://10.0.0.1:8080");
+        unsafe { env::set_var("SQLPAGE_PORT", "tcp://10.0.0.1:8080"); }
 
         let config = load_from_env().unwrap();
         assert_eq!(config.port, None);
 
-        env::remove_var("SQLPAGE_PORT");
+        unsafe { env::remove_var("SQLPAGE_PORT"); }
     }
 
     #[test]
     fn test_valid_port_env_var() {
         let _lock = ENV_LOCK
             .lock()
             .expect("Another test panicked while holding the lock");
-        env::set_var("SQLPAGE_PORT", "9000");
+        unsafe { env::set_var("SQLPAGE_PORT", "9000"); }
 
         let config = load_from_env().unwrap();
         assert_eq!(config.port, Some(9000));
 
-        env::remove_var("SQLPAGE_PORT");
+        unsafe { env::remove_var("SQLPAGE_PORT"); }
     }
 
     #[test]
     fn test_config_priority() {
         let _lock = ENV_LOCK
             .lock()
             .expect("Another test panicked while holding the lock");
-        env::set_var("SQLPAGE_WEB_ROOT", "/");
+        unsafe { env::set_var("SQLPAGE_WEB_ROOT", "/"); }
 
         let cli = Cli {
             web_root: Some(PathBuf::from(".")),
@@ -835,7 +835,7 @@ mod test {
             "CLI argument should take precedence over environment variable"
         );
 
-        env::remove_var("SQLPAGE_WEB_ROOT");
+        unsafe { env::remove_var("SQLPAGE_WEB_ROOT"); }
     }
 
     #[test]
@@ -859,7 +859,7 @@ mod test {
         .to_string();
         std::fs::write(&config_file_path, config_content).unwrap();
 
-        env::set_var("SQLPAGE_WEB_ROOT", env_web_dir.to_str().unwrap());
+        unsafe { env::set_var("SQLPAGE_WEB_ROOT", env_web_dir.to_str().unwrap()); }
 
         let cli = Cli {
             web_root: None,
@@ -898,7 +898,7 @@ mod test {
             "Configuration directory should remain unchanged"
         );
 
-        env::remove_var("SQLPAGE_WEB_ROOT");
+        unsafe { env::remove_var("SQLPAGE_WEB_ROOT"); }
         std::fs::remove_dir_all(&temp_dir).unwrap();
     }
 
@@ -907,8 +907,8 @@ mod test {
         let _lock = ENV_LOCK
             .lock()
             .expect("Another test panicked while holding the lock");
-        env::remove_var("SQLPAGE_CONFIGURATION_DIRECTORY");
-        env::remove_var("SQLPAGE_WEB_ROOT");
+        unsafe { env::remove_var("SQLPAGE_CONFIGURATION_DIRECTORY"); }
+        unsafe { env::remove_var("SQLPAGE_WEB_ROOT"); }
 
         let cli = Cli {
             web_root: None,

src/webserver/database/execute_queries.rs

@@ -610,7 +610,7 @@ async fn apply_delayed_functions(
 ) -> anyhow::Result<()> {
     // We need to open new connections for each delayed function call, because we are still fetching the results of the current query in the main connection.
     let mut db_conn = None;
-    if let DbItem::Row(serde_json::Value::Object(ref mut results)) = item {
+    if let DbItem::Row(serde_json::Value::Object(results)) = item {
         for f in delayed_functions {
             log::trace!("Applying delayed function {} to {:?}", f.function, results);
             apply_single_delayed_function(request, &mut db_conn, f, results).await?;
@@ -654,7 +654,7 @@ fn json_to_fn_param(json: serde_json::Value) -> Option<Cow<'static, str>> {
 }
 
 fn apply_json_columns(item: &mut DbItem, json_columns: &[String]) {
-    if let DbItem::Row(Value::Object(ref mut row)) = item {
+    if let DbItem::Row(Value::Object(row)) = item {
         for column in json_columns {
             if let Some(value) = row.get_mut(column) {
                 if let Value::String(json_str) = value {

tests/requests/webhook_hmac.rs

@@ -6,7 +6,7 @@ use crate::common::get_request_to;
 #[actix_web::test]
 async fn test_webhook_hmac_invalid_signature() -> actix_web::Result<()> {
     // Set up environment variable for webhook secret
-    std::env::set_var("WEBHOOK_SECRET", "test-secret-key");
+    unsafe { std::env::set_var("WEBHOOK_SECRET", "test-secret-key"); }
 
     let webhook_body = r#"{"order_id":12345,"total":"99.99"}"#;
     let invalid_signature = "96a5f6f65c85a2d4d1f3a37813ab2c0b44041bdc17691fbb0884e3eb52b7c54b";
@@ -40,7 +40,7 @@ async fn test_webhook_hmac_invalid_signature() -> actix_web::Result<()> {
 #[actix_web::test]
 async fn test_webhook_hmac_valid_signature() -> actix_web::Result<()> {
     // Set up environment variable for webhook secret
-    std::env::set_var("WEBHOOK_SECRET", "test-secret-key");
+    unsafe { std::env::set_var("WEBHOOK_SECRET", "test-secret-key"); }
 
     let webhook_body = r#"{"order_id":12345,"total":"99.99"}"#;
     let valid_signature = "260b3b5ead84843645588af82d5d2c3fe24c598a950d36c45438c3a5f5bb941c";
@@ -68,7 +68,7 @@ async fn test_webhook_hmac_valid_signature() -> actix_web::Result<()> {
 #[actix_web::test]
 async fn test_webhook_hmac_missing_signature() -> actix_web::Result<()> {
     // Set up environment variable for webhook secret
-    std::env::set_var("WEBHOOK_SECRET", "test-secret-key");
+    unsafe { std::env::set_var("WEBHOOK_SECRET", "test-secret-key"); }
 
     let webhook_body = r#"{"order_id":12345,"total":"99.99"}"#;