fix: error response with errors field

Author: danielebriggi

package-lock.json

@@ -52,6 +52,16 @@ function getAttachmentLimitError(description: unknown, limit: number): SQLiteClo
   }
 }
 
+function getGatewayResponseError(response: any): Record<string, any> | undefined {
+  if (response?.error && typeof response.error === 'object') {
+    return response.error
+  }
+
+  if (Array.isArray(response?.errors) && response.errors[0] && typeof response.errors[0] === 'object') {
+    return response.errors[0]
+  }
+}
+
 /**
  * Implementation of TransportConnection that connects to the database indirectly
  * via SQLite Cloud Gateway, a socket.io based deamon that responds to sql query
@@ -90,6 +100,7 @@ export class SQLiteCloudWebsocketConnection extends SQLiteCloudConnection {
           const raw = this.config.gatewayurl
           gatewayUrl = raw.startsWith('ws://') || raw.startsWith('wss://') ? raw : `ws://${raw}`
           ioOpts.extraHeaders = { Host: this.config.host }
+          ioOpts.transports = ['websocket']
         } else {
           const gatewayHost = buildGatewayHost(this.config.host as string, this.config.gatewayurl)
           gatewayUrl = `wss://${gatewayHost}:443`
@@ -168,8 +179,9 @@ export class SQLiteCloudWebsocketConnection extends SQLiteCloudConnection {
         }
       },
       (response: any) => {
-        if (response?.error) {
-          const error = new SQLiteCloudError(response.error.detail, { ...response.error })
+        const gatewayError = getGatewayResponseError(response)
+        if (gatewayError) {
+          const error = new SQLiteCloudError(gatewayError.detail || gatewayError.message || 'Gateway error', { ...gatewayError })
           callback?.call(this, error)
         } else {
           const { metadata } = response

src/drivers/connection-ws.ts

@@ -29,10 +29,10 @@ describe('websocket transport helpers', () => {
 
     const connection = Object.create(SQLiteCloudWebsocketConnection.prototype) as any
     const connectionstring = 'sqlitecloud://host.sqlite.cloud/database?apikey=secret'
-    connection.connectTransport({ connectionstring, host: 'host.sqlite.cloud', websocketMaxAttachments: 321 }, jest.fn())
+    connection.connectTransport({ connectionstring, host: 'host.sqlite.cloud', apikey: 'secret', websocketMaxAttachments: 321 }, jest.fn())
 
-    expect(mockedIo).toHaveBeenCalledWith('wss://host.sqlite.cloud:443', {
-      auth: { token: connectionstring },
+    expect(mockedIo).toHaveBeenCalledWith('wss://host.gateway.sqlite.cloud:443', {
+      auth: { token: 'secret' },
       parser: expect.objectContaining({
         Encoder: expect.any(Function),
         Decoder: expect.any(Function)
@@ -84,6 +84,7 @@ describe('websocket transport helpers', () => {
           {
             sql: 'SELECT ?',
             bind: ['123n'],
+            database: undefined,
             row: 'array',
             safe_integer_mode: 'bigint',
             capabilities: {
@@ -162,6 +163,38 @@ describe('websocket transport helpers', () => {
     })
   })
 
+  it('should read gateway errors from the errors array response field', done => {
+    const connection = Object.create(SQLiteCloudWebsocketConnection.prototype) as any
+    const emit = jest.fn((_event: string, _payload: any, callback: (response: any) => void) => {
+      callback({
+        errors: [
+          {
+            detail: 'Gateway validation failed.',
+            errorCode: '40001',
+            externalErrorCode: '0',
+            offsetCode: -1
+          }
+        ]
+      })
+    })
+    connection.socket = { connected: true, emit }
+    connection.config = {}
+
+    connection.transportCommands('SELECT 1', (error: any, results?: SQLiteCloudRowset) => {
+      try {
+        expect(results).toBeUndefined()
+        expect(error).toBeDefined()
+        expect(error.message).toBe('Gateway validation failed.')
+        expect(error.errorCode).toBe('40001')
+        expect(error.externalErrorCode).toBe('0')
+        expect(error.offsetCode).toBe(-1)
+        done()
+      } catch (error) {
+        done(error as Error)
+      }
+    })
+  })
+
   it('should surface an actionable error when socket.io attachment limits are exceeded', () => {
     const handlers: Record<string, (...args: any[]) => void> = {}
     const socket = {