Fixing bugs: Duplicated initialization of ->subscription, and unset the subscribtion

jgil · jgil · commit f4f4497d3938 · 2015-10-04T16:37:25.000+02:00
diff --git a/src/Connection.php b/src/Connection.php
@@ -107,7 +107,6 @@ public function __construct(ConnectionOptions $options = null)
     {
         $this->pings = 0;
         $this->pubs = 0;
-        $this->subscriptions = 0;
         $this->subscriptions = [];
         $this->options = $options;
         if (is_null($options)) {
@@ -241,6 +240,8 @@ public function unsubscribe($sid)
     {
         $msg = 'UNSUB '.$sid;
         $this->send($msg);
+
+        unset($this->subscriptions[$sid]);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,6 @@ public function __construct(ConnectionOptions $options = null)`
`107`	`107`	`{`
`108`	`108`	`$this->pings = 0;`
`109`	`109`	`$this->pubs = 0;`
`110`		`- $this->subscriptions = 0;`
`111`	`110`	`$this->subscriptions = [];`
`112`	`111`	`$this->options = $options;`
`113`	`112`	`if (is_null($options)) {`
`@@ -241,6 +240,8 @@ public function unsubscribe($sid)`
`241`	`240`	`{`
`242`	`241`	`$msg = 'UNSUB '.$sid;`
`243`	`242`	`$this->send($msg);`
	`243`	`+`
	`244`	`+ unset($this->subscriptions[$sid]);`
`244`	`245`	`}`
`245`	`246`
`246`	`247`	`/**`