Fix bug non getting Exception on failed auth

repejota · repejota · commit 97b2d6bf1588 · 2017-04-25T14:44:23.000+02:00
diff --git a/src/Nats/Connection.php b/src/Nats/Connection.php
@@ -187,7 +187,7 @@ public function getStreamSocket()
      */
     private function isErrorResponse($response)
     {
-        return false !== strpos('-ERR', $response);
+        return substr( $response, 0, 4 ) === "-ERR";
     }
 
 
@@ -388,6 +388,7 @@ public function connect($timeout = null)
 
         $msg = 'CONNECT '.$this->options;
         $this->send($msg);
+        $infoResponse = $this->receive();
         $connectResponse = $this->receive();
 
         if ($this->isErrorResponse($connectResponse) === true) {

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ public function getStreamSocket()`
`187`	`187`	`*/`
`188`	`188`	`private function isErrorResponse($response)`
`189`	`189`	`{`
`190`		`- return false !== strpos('-ERR', $response);`
	`190`	`+ return substr( $response, 0, 4 ) === "-ERR";`
`191`	`191`	`}`
`192`	`192`
`193`	`193`
`@@ -388,6 +388,7 @@ public function connect($timeout = null)`
`388`	`388`
`389`	`389`	`$msg = 'CONNECT '.$this->options;`
`390`	`390`	`$this->send($msg);`
	`391`	`+ $infoResponse = $this->receive();`
`391`	`392`	`$connectResponse = $this->receive();`
`392`	`393`
`393`	`394`	`if ($this->isErrorResponse($connectResponse) === true) {`