Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

Commit 666ab37

Browse files
committed
Missing Best Practice
uniqid does not create random nor unpredictable string. This function must not be used for security purposes. If you need to generate cryptographically secure tokens use openssl_random_pseudo_bytes().
1 parent 54de1b8 commit 666ab37

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/Connection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ public function subscribe($subject, \Closure $callback)
307307
*/
308308
public function queueSubscribe($subject, $queue, \Closure $callback)
309309
{
310-
$sid = uniqid();
310+
$sid = openssl_random_pseudo_bytes(16);
311311
$msg = 'SUB '.$subject.' '.$queue.' '. $sid;
312312
$this->send($msg);
313313
$this->subscriptions[$sid] = $callback;

0 commit comments

Comments
 (0)