Improved attachment of log

GregorIwanowski · GregorIwanowski · commit 9308cc1c0198 · 2019-10-22T16:07:04.000+02:00
diff --git a/AppCenter/AppCenterSDK+HiDrive.swift b/AppCenter/AppCenterSDK+HiDrive.swift
@@ -163,9 +163,11 @@ private class AppCenterSDKDelegate	: NSObject, MSCrashesDelegate {
 	}
 
 	func attachments(with crashes: MSCrashes!, for errorReport: MSErrorReport!) -> [MSErrorAttachmentLog]! {
-		return [
-			MSErrorAttachmentLog.attachment(withText: self.applicationLog, filename: AppCenterConstants.crashLogFileName)
-		]
+		guard (self.isLogUploadEnabled == true) else {
+			return []
+		}
+
+		return [MSErrorAttachmentLog.attachment(withText: self.applicationLog, filename: AppCenterConstants.crashLogFileName)]
 	}
 
 	private var applicationLog: String {

Original file line number	Diff line number	Diff line change
`@@ -163,9 +163,11 @@ private class AppCenterSDKDelegate : NSObject, MSCrashesDelegate {`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`func attachments(with crashes: MSCrashes!, for errorReport: MSErrorReport!) -> [MSErrorAttachmentLog]! {`
`166`		`- return [`
`167`		`- MSErrorAttachmentLog.attachment(withText: self.applicationLog, filename: AppCenterConstants.crashLogFileName)`
`168`		`- ]`
	`166`	`+ guard (self.isLogUploadEnabled == true) else {`
	`167`	`+ return []`
	`168`	`+ }`
	`169`	`+`
	`170`	`+ return [MSErrorAttachmentLog.attachment(withText: self.applicationLog, filename: AppCenterConstants.crashLogFileName)]`
`169`	`171`	`}`
`170`	`172`
`171`	`173`	`private var applicationLog: String {`