Skip to content

Commit 5cb9466

Browse files
author
Sylvain MARIE
committed
Removed official support for python versions <3.9. These versions will not run in CI anymore. Note that 2.7 is
still supported - until corresponding github action stops working.
1 parent 6f123d7 commit 5cb9466

4 files changed

Lines changed: 18 additions & 11 deletions

File tree

.github/workflows/base.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ jobs:
156156
uses: actions/checkout@v4.1.1
157157
with:
158158
fetch-depth: 0 # so that gh-deploy works
159+
# persist-credentials: false # see https://github.com/orgs/community/discussions/25702
159160

160161
- name: Install python 3.9 for nox
161162
uses: actions/setup-python@v5.1.0
@@ -209,7 +210,11 @@ jobs:
209210
# 7) Create github release and build the wheel
210211
- name: \[TAG only\] Build wheel and create github release
211212
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
212-
run: nox -s release -- ${{ secrets.GITHUB_TOKEN }}
213+
# We would have to use a PAT instead of GITHUB_TOKEN if we want the next job to trigger.
214+
# See https://github.com/orgs/community/discussions/25702
215+
# For now we will rather rely on a "workflow completed" trigger to avoid
216+
# having a token expiration date to manage
217+
run: nox -s release -- ${{ secrets.GITHUB_TOKEN }} # ${{ secrets.WORKFLOW_SECRET}}
213218

214219
# 8) Publish the wheel on PyPi
215220
- name: \[TAG only\] Deploy on PyPi

ci_tools/nox_utils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@
1212
nox_logger = logging.getLogger("nox")
1313

1414

15-
PY27, PY35, PY36, PY37, PY38, PY39, PY310, PY311, PY312, PY313 = ("2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10",
16-
"3.11", "3.12", "3.13")
15+
PY27, PY35, PY36, PY37, PY38, PY39, PY310, PY311, PY312, PY313, PY314 = (
16+
"2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"
17+
)
1718
DONT_INSTALL = "dont_install"
1819

1920

docs/changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
### 1.16.0 - (in progress) new python versions scope
4+
5+
- Removed official support for python versions `<3.9`. These versions will not run in CI anymore. Note that `2.7` is
6+
still supported - until corresponding github action stops working.
7+
8+
39
### 1.15.6 - compatibility fix
410

511
- Fixed issue with legacy python 2.7 and 3.5. Fixes [#110](https://github.com/smarie/python-makefun/issues/110)

noxfile.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import argparse
2-
import json
31
import logging
42

53
import nox # noqa
@@ -9,7 +7,7 @@
97
# add parent folder to python path so that we can import noxfile_utils.py
108
# note that you need to "pip install -r noxfile-requiterements.txt" for this file to work.
119
sys.path.append(str(Path(__file__).parent / "ci_tools"))
12-
from nox_utils import (PY27, PY37, PY36, PY35, PY38, PY39, PY310, PY311, PY312, PY313, install_reqs, rm_folder, rm_file,
10+
from nox_utils import (PY27, PY39, PY310, PY311, PY312, PY313, PY314, install_reqs, rm_folder, rm_file,
1311
DONT_INSTALL) # noqa
1412

1513

@@ -54,17 +52,14 @@ class Folders:
5452

5553

5654
ENVS = {
55+
PY314: {"coverage": False, "pkg_specs": {"pip": ">19"}},
5756
PY313: {"coverage": False, "pkg_specs": {"pip": ">19"}},
5857
PY312: {"coverage": False, "pkg_specs": {"pip": ">19"}},
5958
PY311: {"coverage": False, "pkg_specs": {"pip": ">19"}},
6059
PY310: {"coverage": False, "pkg_specs": {"pip": ">19"}},
61-
PY39: {"coverage": False, "pkg_specs": {"pip": ">19"}},
62-
PY38: {"coverage": False, "pkg_specs": {"pip": ">19"}},
6360
PY27: {"coverage": False, "pkg_specs": {"pip": ">10"}},
64-
PY35: {"coverage": False, "pkg_specs": {"pip": ">10"}},
65-
PY36: {"coverage": False, "pkg_specs": {"pip": ">19"}},
6661
# IMPORTANT: this should be last so that the folder docs/reports is not deleted afterwards
67-
PY37: {"coverage": True, "pkg_specs": {"pip": ">19"}}, # , "pytest-html": "1.9.0"
62+
PY39: {"coverage": True, "pkg_specs": {"pip": ">19"}},
6863
}
6964

7065
ENV_PARAMS = tuple((k, v["coverage"], v["pkg_specs"]) for k, v in ENVS.items())

0 commit comments

Comments
 (0)