Revert 1a7de84 except tag dropdown changes (keep apps/sim/components/ui/tag-dropdown.tsx) (#972)

Author: icecrasher321

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/subflows/components/iteration-badges/iteration-badges.tsx

@@ -158,23 +158,19 @@ export function IterationBadges({ nodeId, data, iterationType }: IterationBadges
   const handleEditorChange = useCallback(
     (value: string) => {
       if (isPreview) return
+      collaborativeUpdateIterationCollection(nodeId, iterationType, value)
 
-      // Capture cursor first to minimize staleness in dropdown logic
-      const textarea = editorContainerRef.current?.querySelector(
-        'textarea'
-      ) as HTMLTextAreaElement | null
-      const cursorPos = textarea?.selectionStart ?? cursorPosition
+      const textarea = editorContainerRef.current?.querySelector('textarea')
       if (textarea) {
         textareaRef.current = textarea
-      }
-      setCursorPosition(cursorPos)
-
-      collaborativeUpdateIterationCollection(nodeId, iterationType, value)
+        const cursorPos = textarea.selectionStart || 0
+        setCursorPosition(cursorPos)
 
-      const triggerCheck = checkTagTrigger(value, cursorPos)
-      setShowTagDropdown(triggerCheck.show)
+        const triggerCheck = checkTagTrigger(value, cursorPos)
+        setShowTagDropdown(triggerCheck.show)
+      }
     },
-    [nodeId, iterationType, collaborativeUpdateIterationCollection, isPreview, cursorPosition]
+    [nodeId, iterationType, collaborativeUpdateIterationCollection, isPreview]
   )
 
   // Handle tag selection

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/sub-block/components/code.tsx

@@ -446,25 +446,24 @@ export function Code({
             value={code}
             onValueChange={(newCode) => {
               if (!isCollapsed && !isAiStreaming && !isPreview && !disabled) {
-                // Capture cursor first to minimize staleness in dropdown logic
-                const textarea = editorRef.current?.querySelector(
-                  'textarea'
-                ) as HTMLTextAreaElement | null
-                const pos = textarea?.selectionStart ?? cursorPosition
-                setCursorPosition(pos)
-
                 setCode(newCode)
                 setStoreValue(newCode)
 
-                const tagTrigger = checkTagTrigger(newCode, pos)
-                setShowTags(tagTrigger.show)
-                if (!tagTrigger.show) {
-                  setActiveSourceBlockId(null)
-                }
+                const textarea = editorRef.current?.querySelector('textarea')
+                if (textarea) {
+                  const pos = textarea.selectionStart
+                  setCursorPosition(pos)
 
-                const envVarTrigger = checkEnvVarTrigger(newCode, pos)
-                setShowEnvVars(envVarTrigger.show)
-                setSearchTerm(envVarTrigger.show ? envVarTrigger.searchTerm : '')
+                  const tagTrigger = checkTagTrigger(newCode, pos)
+                  setShowTags(tagTrigger.show)
+                  if (!tagTrigger.show) {
+                    setActiveSourceBlockId(null)
+                  }
+
+                  const envVarTrigger = checkEnvVarTrigger(newCode, pos)
+                  setShowEnvVars(envVarTrigger.show)
+                  setSearchTerm(envVarTrigger.show ? envVarTrigger.searchTerm : '')
+                }
               }
             }}
             onKeyDown={(e) => {

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/sub-block/components/combobox.tsx

@@ -150,14 +150,13 @@ export function ComboBox({
     const newValue = e.target.value
     const newCursorPosition = e.target.selectionStart ?? 0
 
-    // Update cursor first to reduce staleness for dropdown logic
-    setCursorPosition(newCursorPosition)
-
     // Update store value immediately (allow free text)
     if (!isPreview) {
       setStoreValue(newValue)
     }
 
+    setCursorPosition(newCursorPosition)
+
     // Check for environment variables trigger
     const envVarTrigger = checkEnvVarTrigger(newValue, newCursorPosition)
     setShowEnvVars(envVarTrigger.show)

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/sub-block/components/long-input.tsx

@@ -148,9 +148,6 @@ export function LongInput({
     const newValue = e.target.value
     const newCursorPosition = e.target.selectionStart ?? 0
 
-    // Update cursor first to minimize state staleness for dropdown selection logic
-    setCursorPosition(newCursorPosition)
-
     // Update local content immediately
     setLocalContent(newValue)
 
@@ -161,6 +158,8 @@ export function LongInput({
       setStoreValue(newValue)
     }
 
+    setCursorPosition(newCursorPosition)
+
     // Check for environment variables trigger
     const envVarTrigger = checkEnvVarTrigger(newValue, newCursorPosition)
     setShowEnvVars(envVarTrigger.show)

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/sub-block/components/short-input.tsx

@@ -106,16 +106,15 @@ export function ShortInput({
     const newValue = e.target.value
     const newCursorPosition = e.target.selectionStart ?? 0
 
-    // Update cursor first to minimize state staleness for dropdown selection logic
-    setCursorPosition(newCursorPosition)
-
     if (onChange) {
       onChange(newValue)
     } else if (!isPreview) {
       // Only update store when not in preview mode
       setStoreValue(newValue)
     }
 
+    setCursorPosition(newCursorPosition)
+
     // Check for environment variables trigger
     const envVarTrigger = checkEnvVarTrigger(newValue, newCursorPosition)