Skip to content

Commit 375703b

Browse files
fzowlfzowl
committed
revert: drop all MongoDB connection string changes
Reverts MongoDB Atlas connection string support due to validation issues in the Zod schemas. VoyageAI integration remains intact.
1 parent 1836124 commit 375703b

File tree

15 files changed

+28
-117
lines changed

15 files changed

+28
-117
lines changed

‎apps/sim/app/api/tools/mongodb/delete/route.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@ import { createMongoDBConnection, sanitizeCollectionName, validateFilter } from
88
const logger = createLogger('MongoDBDeleteAPI')
99

1010
const DeleteSchema = z.object({
11-
connectionString: z.string().optional(),
12-
host: z.string().default(''),
13-
port: z.coerce.number().int().nonnegative().default(27017),
11+
host: z.string().min(1, 'Host is required'),
12+
port: z.coerce.number().int().positive('Port must be a positive integer'),
1413
database: z.string().min(1, 'Database name is required'),
15-
username: z.string().default(''),
16-
password: z.string().default(''),
14+
username: z.string().min(1, 'Username is required'),
15+
password: z.string().min(1, 'Password is required'),
1716
authSource: z.string().optional(),
1817
ssl: z.enum(['disabled', 'required', 'preferred']).default('preferred'),
1918
collection: z.string().min(1, 'Collection name is required'),
@@ -76,7 +75,6 @@ export async function POST(request: NextRequest) {
7675
}
7776

7877
client = await createMongoDBConnection({
79-
connectionString: params.connectionString,
8078
host: params.host,
8179
port: params.port,
8280
database: params.database,

‎apps/sim/app/api/tools/mongodb/execute/route.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@ import { createMongoDBConnection, sanitizeCollectionName, validatePipeline } fro
88
const logger = createLogger('MongoDBExecuteAPI')
99

1010
const ExecuteSchema = z.object({
11-
connectionString: z.string().optional(),
12-
host: z.string().default(''),
13-
port: z.coerce.number().int().nonnegative().default(27017),
11+
host: z.string().min(1, 'Host is required'),
12+
port: z.coerce.number().int().positive('Port must be a positive integer'),
1413
database: z.string().min(1, 'Database name is required'),
15-
username: z.string().default(''),
16-
password: z.string().default(''),
14+
username: z.string().min(1, 'Username is required'),
15+
password: z.string().min(1, 'Password is required'),
1716
authSource: z.string().optional(),
1817
ssl: z.enum(['disabled', 'required', 'preferred']).default('preferred'),
1918
collection: z.string().min(1, 'Collection name is required'),
@@ -62,7 +61,6 @@ export async function POST(request: NextRequest) {
6261
const pipelineDoc = JSON.parse(params.pipeline)
6362

6463
client = await createMongoDBConnection({
65-
connectionString: params.connectionString,
6664
host: params.host,
6765
port: params.port,
6866
database: params.database,

‎apps/sim/app/api/tools/mongodb/insert/route.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@ import { createMongoDBConnection, sanitizeCollectionName } from '../utils'
88
const logger = createLogger('MongoDBInsertAPI')
99

1010
const InsertSchema = z.object({
11-
connectionString: z.string().optional(),
12-
host: z.string().default(''),
13-
port: z.coerce.number().int().nonnegative().default(27017),
11+
host: z.string().min(1, 'Host is required'),
12+
port: z.coerce.number().int().positive('Port must be a positive integer'),
1413
database: z.string().min(1, 'Database name is required'),
15-
username: z.string().default(''),
16-
password: z.string().default(''),
14+
username: z.string().min(1, 'Username is required'),
15+
password: z.string().min(1, 'Password is required'),
1716
authSource: z.string().optional(),
1817
ssl: z.enum(['disabled', 'required', 'preferred']).default('preferred'),
1918
collection: z.string().min(1, 'Collection name is required'),
@@ -55,7 +54,6 @@ export async function POST(request: NextRequest) {
5554

5655
const sanitizedCollection = sanitizeCollectionName(params.collection)
5756
client = await createMongoDBConnection({
58-
connectionString: params.connectionString,
5957
host: params.host,
6058
port: params.port,
6159
database: params.database,

‎apps/sim/app/api/tools/mongodb/introspect/route.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ import { createMongoDBConnection, executeIntrospect } from '../utils'
88
const logger = createLogger('MongoDBIntrospectAPI')
99

1010
const IntrospectSchema = z.object({
11-
connectionString: z.string().optional(),
12-
host: z.string().default(''),
13-
port: z.coerce.number().int().nonnegative().default(27017),
11+
host: z.string().min(1, 'Host is required'),
12+
port: z.coerce.number().int().positive('Port must be a positive integer'),
1413
database: z.string().optional(),
1514
username: z.string().optional(),
1615
password: z.string().optional(),
@@ -37,7 +36,6 @@ export async function POST(request: NextRequest) {
3736
)
3837

3938
client = await createMongoDBConnection({
40-
connectionString: params.connectionString,
4139
host: params.host,
4240
port: params.port,
4341
database: params.database || 'admin',

‎apps/sim/app/api/tools/mongodb/query/route.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@ import { createMongoDBConnection, sanitizeCollectionName, validateFilter } from
88
const logger = createLogger('MongoDBQueryAPI')
99

1010
const QuerySchema = z.object({
11-
connectionString: z.string().optional(),
12-
host: z.string().default(''),
13-
port: z.coerce.number().int().nonnegative().default(27017),
11+
host: z.string().min(1, 'Host is required'),
12+
port: z.coerce.number().int().positive('Port must be a positive integer'),
1413
database: z.string().min(1, 'Database name is required'),
15-
username: z.string().default(''),
16-
password: z.string().default(''),
14+
username: z.string().min(1, 'Username is required'),
15+
password: z.string().min(1, 'Password is required'),
1716
authSource: z.string().optional(),
1817
ssl: z.enum(['disabled', 'required', 'preferred']).default('preferred'),
1918
collection: z.string().min(1, 'Collection name is required'),
@@ -91,7 +90,6 @@ export async function POST(request: NextRequest) {
9190
}
9291

9392
client = await createMongoDBConnection({
94-
connectionString: params.connectionString,
9593
host: params.host,
9694
port: params.port,
9795
database: params.database,

‎apps/sim/app/api/tools/mongodb/update/route.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@ import { createMongoDBConnection, sanitizeCollectionName, validateFilter } from
88
const logger = createLogger('MongoDBUpdateAPI')
99

1010
const UpdateSchema = z.object({
11-
connectionString: z.string().optional(),
12-
host: z.string().default(''),
13-
port: z.coerce.number().int().nonnegative().default(27017),
11+
host: z.string().min(1, 'Host is required'),
12+
port: z.coerce.number().int().positive('Port must be a positive integer'),
1413
database: z.string().min(1, 'Database name is required'),
15-
username: z.string().default(''),
16-
password: z.string().default(''),
14+
username: z.string().min(1, 'Username is required'),
15+
password: z.string().min(1, 'Password is required'),
1716
authSource: z.string().optional(),
1817
ssl: z.enum(['disabled', 'required', 'preferred']).default('preferred'),
1918
collection: z.string().min(1, 'Collection name is required'),
@@ -100,7 +99,6 @@ export async function POST(request: NextRequest) {
10099
}
101100

102101
client = await createMongoDBConnection({
103-
connectionString: params.connectionString,
104102
host: params.host,
105103
port: params.port,
106104
database: params.database,

‎apps/sim/app/api/tools/mongodb/utils.ts‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,6 @@ import { validateDatabaseHost } from '@/lib/core/security/input-validation.serve
33
import type { MongoDBCollectionInfo, MongoDBConnectionConfig } from '@/tools/mongodb/types'
44

55
export async function createMongoDBConnection(config: MongoDBConnectionConfig) {
6-
if (config.connectionString) {
7-
const client = new MongoClient(config.connectionString, {
8-
connectTimeoutMS: 10000,
9-
socketTimeoutMS: 10000,
10-
maxPoolSize: 1,
11-
})
12-
await client.connect()
13-
return client
14-
}
15-
166
const hostValidation = await validateDatabaseHost(config.host, 'host')
177
if (!hostValidation.isValid) {
188
throw new Error(hostValidation.error)

‎apps/sim/blocks/blocks/mongodb.ts‎

Lines changed: 6 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -30,41 +30,20 @@ export const MongoDBBlock: BlockConfig<MongoDBResponse | MongoDBIntrospectRespon
3030
],
3131
value: () => 'query',
3232
},
33-
{
34-
id: 'connectionMode',
35-
title: 'Connection Mode',
36-
type: 'dropdown',
37-
options: [
38-
{ label: 'Host & Port', id: 'host_port' },
39-
{ label: 'Connection String (Atlas)', id: 'connection_string' },
40-
],
41-
value: () => 'host_port',
42-
},
43-
{
44-
id: 'connectionString',
45-
title: 'Connection String',
46-
type: 'short-input',
47-
placeholder: 'mongodb+srv://user:password@cluster.mongodb.net/mydb',
48-
password: true,
49-
condition: { field: 'connectionMode', value: 'connection_string' },
50-
required: { field: 'connectionMode', value: 'connection_string' },
51-
},
5233
{
5334
id: 'host',
5435
title: 'Host',
5536
type: 'short-input',
5637
placeholder: 'localhost or your.mongodb.host',
57-
condition: { field: 'connectionMode', value: 'connection_string', not: true },
58-
required: { field: 'connectionMode', value: 'connection_string', not: true },
38+
required: true,
5939
},
6040
{
6141
id: 'port',
6242
title: 'Port',
6343
type: 'short-input',
6444
placeholder: '27017',
6545
value: () => '27017',
66-
condition: { field: 'connectionMode', value: 'connection_string', not: true },
67-
required: { field: 'connectionMode', value: 'connection_string', not: true },
46+
required: true,
6847
},
6948
{
7049
id: 'database',
@@ -78,17 +57,15 @@ export const MongoDBBlock: BlockConfig<MongoDBResponse | MongoDBIntrospectRespon
7857
title: 'Username',
7958
type: 'short-input',
8059
placeholder: 'mongodb_user',
81-
condition: { field: 'connectionMode', value: 'connection_string', not: true },
82-
required: { field: 'connectionMode', value: 'connection_string', not: true },
60+
required: true,
8361
},
8462
{
8563
id: 'password',
8664
title: 'Password',
8765
type: 'short-input',
8866
password: true,
8967
placeholder: 'Your database password',
90-
condition: { field: 'connectionMode', value: 'connection_string', not: true },
91-
required: { field: 'connectionMode', value: 'connection_string', not: true },
68+
required: true,
9269
},
9370
{
9471
id: 'authSource',
@@ -860,7 +837,7 @@ Return ONLY the MongoDB query filter as valid JSON - no explanations, no markdow
860837
}
861838
},
862839
params: (params) => {
863-
const { operation, documents, connectionMode, ...rest } = params
840+
const { operation, documents, ...rest } = params
864841

865842
let parsedDocuments
866843
if (documents && typeof documents === 'string' && documents.trim()) {
@@ -876,7 +853,7 @@ Return ONLY the MongoDB query filter as valid JSON - no explanations, no markdow
876853
parsedDocuments = documents
877854
}
878855

879-
const connectionConfig: Record<string, unknown> = {
856+
const connectionConfig = {
880857
host: rest.host,
881858
port: typeof rest.port === 'string' ? Number.parseInt(rest.port, 10) : rest.port || 27017,
882859
database: rest.database,
@@ -886,10 +863,6 @@ Return ONLY the MongoDB query filter as valid JSON - no explanations, no markdow
886863
ssl: rest.ssl || 'preferred',
887864
}
888865

889-
if (rest.connectionString) {
890-
connectionConfig.connectionString = rest.connectionString
891-
}
892-
893866
const result: any = { ...connectionConfig }
894867

895868
if (rest.collection) result.collection = rest.collection
@@ -927,8 +900,6 @@ Return ONLY the MongoDB query filter as valid JSON - no explanations, no markdow
927900
},
928901
inputs: {
929902
operation: { type: 'string', description: 'Database operation to perform' },
930-
connectionMode: { type: 'string', description: 'Connection mode (host_port or connection_string)' },
931-
connectionString: { type: 'string', description: 'Full MongoDB connection string' },
932903
host: { type: 'string', description: 'MongoDB host' },
933904
port: { type: 'string', description: 'MongoDB port' },
934905
database: { type: 'string', description: 'Database name' },

‎apps/sim/tools/mongodb/delete.ts‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@ export const deleteTool: ToolConfig<MongoDBDeleteParams, MongoDBResponse> = {
88
version: '1.0',
99

1010
params: {
11-
connectionString: {
12-
type: 'string',
13-
required: false,
14-
visibility: 'user-only',
15-
description: 'Full MongoDB connection string (e.g., mongodb+srv://user:pass@cluster.mongodb.net/db)',
16-
},
1711
host: {
1812
type: 'string',
1913
required: true,

‎apps/sim/tools/mongodb/execute.ts‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@ export const executeTool: ToolConfig<MongoDBExecuteParams, MongoDBResponse> = {
88
version: '1.0',
99

1010
params: {
11-
connectionString: {
12-
type: 'string',
13-
required: false,
14-
visibility: 'user-only',
15-
description: 'Full MongoDB connection string (e.g., mongodb+srv://user:pass@cluster.mongodb.net/db)',
16-
},
1711
host: {
1812
type: 'string',
1913
required: true,

0 commit comments

Comments
 (0)