From 78719b01b04ab955c4c4a4ca2911c6ef02ba02a5 Mon Sep 17 00:00:00 2001 From: Lucas Lepski Date: Sun, 18 Oct 2026 10:34:07 +0200 Subject: [PATCH] Consolidate reviewed maintenance work into release 1.0.0.5 --- CHANGELOG.md | 44 ++++++------------- INSTALLATION.md | 13 ++++-- Properties/AssemblyInfo.cs | 4 +- README.md | 6 +-- ...REVIEW-1.0.0.6.md => CORRECTIVE-REVIEW.md} | 8 ++-- docs/SESSION-REVIEW-1.0.0.7.md | 21 --------- docs/SESSION-REVIEW.md | 21 +++++++++ ...M-REVIEW-1.0.0.5.md => UPSTREAM-REVIEW.md} | 4 +- 8 files changed, 54 insertions(+), 67 deletions(-) rename docs/{RELEASE-REVIEW-1.0.0.6.md => CORRECTIVE-REVIEW.md} (71%) delete mode 100644 docs/SESSION-REVIEW-1.0.0.7.md create mode 100644 docs/SESSION-REVIEW.md rename docs/{UPSTREAM-REVIEW-1.0.0.5.md => UPSTREAM-REVIEW.md} (93%) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3a4ca56..39e2fa6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,42 +1,24 @@ # Sony Camera Plugin -## 1.0.0.7 — exposure error classification and release maintenance +## 1.0.0.5 — combined community maintenance release -- Use GitHub handles in plugin descriptions, author/contributor display metadata and the packaged source notice. Preserve the original copyright notice and commit authorship. -- Correct README version, release status and installation links; retain the explicit limits of automated testing and manual distribution. -- Report a rejected busy capture-start through NINA's CameraExposureFailedException path, preserving the original message and cause. This avoids the duplicate generic-error notification path in NINA 3.2 while retaining capture rejection, prior cancellation and the existing soft-abort warning. Actual UI confirmation is still needed for the full popup report in this fork's issue #5. -- Publish a fresh versioned build; older release assets and checksums remain intact. +First consolidated maintained release from [@shurkanTwo's fork](https://github.com/shurkanTwo/NINASonyCameraPlugin), combining the reviewed work since upstream 1.0.0.4. @dougforpres's original authorship, MPL-2.0 and the original contributor commits are preserved. Install manually using [INSTALLATION.md](INSTALLATION.md); NINA's plugin manager still uses the upstream release source. -See [the session review](docs/SESSION-REVIEW-1.0.0.7.md) and [manual installation/rollback](INSTALLATION.md). Physical camera/USB/MTP, LiveView, lens operation and complete Sky Flat behavior remain unverified. NINA's plugin manager still uses the upstream release source. - -## 1.0.0.6 — corrective community release - -Follow-up to the 1.0.0.5 audit, retaining all previously integrated contributions and @dougforpres's original authorship. Install manually using [INSTALLATION.md](INSTALLATION.md). - -- Preserve aborts received during capture-start preflight. An aborted pending start cannot launch an exposure after its status check returns; a rejected busy start preserves cancellation of the preceding capture. -- Verify the specific nearest learnt shutter step using the native driver's float rounding and absolute-distance selection, replacing the broad ratio that accepted a stalled adjacent speed. -- Retry a valid previous Bulb readback when switching to a short numeric exposure. Malformed readbacks still fail, and a persistent mismatch cannot start capture. -- Restore the repeated-failure camera-loss protection adapted from @totoantibes's upstream #13: three consecutive qualifying native errors mark the camera disconnected and block all further native access until NINA restarts. Never-working properties, explicit unsupported results, lock contention and shutter-verification mismatches do not count. A successful camera operation resets the count. No native close, retry or automatic reconnection is attempted after the guard trips. -- Add regression coverage using the production capture controller and managed native wrappers, replacing only native delegates and NINA logging/notifications for portable tests. - -See [the corrective review](docs/RELEASE-REVIEW-1.0.0.6.md). Physical camera/USB operation remains unverified. This was published first as a preview and subsequently marked regular/Latest without changing the binaries; updates are installed manually. - -## 1.0.0.5 — community preview - -First maintained release from [@shurkanTwo’s fork](https://github.com/shurkanTwo/NINASonyCameraPlugin), preserving @dougforpres’s original authorship and MPL-2.0. Install manually using [INSTALLATION.md](INSTALLATION.md). This preview is not distributed through NINA’s plugin manager. - -- Integrate current capture start/abort coordination and an opt-in managed Sony camera simulator with full-plugin integration tests (@shurkanTwo, upstream #10/#15). -- Report the latest downloaded ARW’s Sony camera temperature in NINA and that image’s metadata; missing readings remain unavailable (@shurkanTwo, #18 / issue #1). +- Integrate current capture start/abort coordination and the opt-in managed Sony camera simulator with full-plugin integration tests (@shurkanTwo, upstream #10/#15). Preserve aborts received during capture-start preflight and cancellation of a preceding capture when a busy start is rejected. +- Report the latest downloaded ARW's Sony camera temperature in NINA and that image's metadata; missing readings remain unavailable (@shurkanTwo, #18 / issue #1). - Release native image and metadata allocations after copying, including error paths, avoiding a per-frame unmanaged memory leak (@totoantibes, #14). -- Retry and verify shutter changes for back-to-back exposures. A readable shutter mismatch now fails before capture rather than silently using the previous exposure. Exclude AUTO/Multi Frame NR from gain choices and fix native driver version comparisons (adapted from @totoantibes’s #13 / issue #5). -- Serialize native camera/lens calls with bounded waits. Execution timeout blocks further native access until NINA restarts. Keep native cancellation off by default and always soft-cancel during image readout/processing (adapted #13, preserving current #10 safeguards / issue #4). -- Return focuser capability information without throwing (@christian-photo, #11), improve focuser state cleanup and notifications (@totoantibes, #13). +- Retry and verify the specific nearest learned shutter step using the native driver's rounding and absolute-distance selection. Handle numeric/Bulb transitions and fail persistent mismatches before capture. Exclude AUTO/Multi Frame NR from gain choices and correct native driver version comparisons (adapted from @totoantibes's #13 / issue #5). +- Serialize native camera/lens calls with bounded waits. A native execution timeout or three consecutive qualifying native errors blocks further native access until NINA restarts. Unsupported/never-working properties, lock waits and managed verification failures are excluded from the error count. A successful camera operation resets the count. Keep native cancellation off by default and always soft-cancel during readout/processing (adapted #13, preserving current #10 safeguards / issue #4). +- Return focuser capability information without throwing (@christian-photo, #11), and improve focuser state cleanup and notifications (@totoantibes, #13). +- Report rejected busy capture starts through NINA's CameraExposureFailedException path, preserving the original message and cause. This avoids the duplicate generic-error notification path identified in NINA 3.2 while retaining capture rejection, prior cancellation and the existing soft-abort warning. The complete UI popup report in this fork's issue #5 still needs confirmation. - Document lens-learning tools and camera SD-card saving (@shurkanTwo, #16/#17 / issues #9/#3). -- Add Windows-tested manual-install ZIP/DLL packaging, checksums, source/build provenance, and installation/rollback instructions. +- Provide Windows-tested manual-install ZIP/DLL packaging, checksums, exact source/build provenance, and installation/rollback instructions. Authored display metadata and documentation use GitHub handles; original legal notices remain unchanged. + +Existing NINA 3.2/empty-ISO fixes from 1.0.0.4, including @naixx's contribution, remain included. Experimental USB auto-reconnection, retries of still-running timed-out native calls, forced cancellation after repeated busy starts, and closed WIP #12 video intervals remain deferred. -Reviewed but deferred: experimental USB auto-reconnection, retrying a still-running timed-out native call, forced cancellation after repeated busy starts, and closed WIP #12 video intervals. Existing NINA 3.2/empty-ISO fixes from 1.0.0.4 (including @naixx’s contribution) remain included. See the [full review and issue coverage](docs/UPSTREAM-REVIEW-1.0.0.5.md). +This combined package replaces the earlier maintenance builds labelled 1.0.0.5, 1.0.0.6 and 1.0.0.7. Their release entries and tags are retired; the original commits remain in history. If you installed an earlier build, download this package again and replace the DLL manually. The lower consolidated version includes all reviewed fixes. -Validation uses automated tests and Windows CI. Physical camera/USB operation for this combined release has not been verified. Native access violations, newer camera support, and complete NINA Sky Flat behavior are not claimed fixed. Existing legacy-package NU1701 restore warnings remain. +See the [session review](docs/SESSION-REVIEW.md), [corrective review](docs/CORRECTIVE-REVIEW.md) and [upstream review and issue coverage](docs/UPSTREAM-REVIEW.md). Validation uses automated tests and Windows CI. Physical Sony camera/USB/MTP, LiveView, lens operation and complete Sky Flat behavior remain unverified. Native access violations and newer camera support are not claimed fixed. Existing legacy-package NU1701 restore warnings remain. ## 1.0.0.4 * Added the `UpdateSubSampleArea` implementation and bumped the minimum NINA version so the plugin loads in 3.2. diff --git a/INSTALLATION.md b/INSTALLATION.md index a5fa53c..61b6519 100644 --- a/INSTALLATION.md +++ b/INSTALLATION.md @@ -5,10 +5,15 @@ These instructions install the community-maintained build from The original plugin was developed by **@dougforpres**. This fork is maintained by **@shurkanTwo and contributors** while shared upstream maintenance is being discussed. -The current community release, **1.0.0.7**, is a regular GitHub release marked Latest. +The current community release, **1.0.0.5**, is a regular GitHub release marked Latest. Windows builds and automated tests are checked; physical Sony camera/USB operation remains unverified for this combined release. See the release notes for scope. +The consolidated **1.0.0.5** package supersedes the earlier maintenance builds, +including those labelled 1.0.0.5, 1.0.0.6 and 1.0.0.7. If you installed any of +those builds, download this package again and replace the DLL manually using the +steps below. All reviewed fixes are included despite the lower version number. + ## Requirements - Windows 10 1809 or newer and N.I.N.A. 3.2 or newer (minimum 3.2.0.3001). @@ -17,7 +22,7 @@ remains unverified for this combined release. See the release notes for scope. ## Install or replace an existing version -1. Download **`SonyCameraPlugin-1.0.0.7.zip`** from the [1.0.0.7 release](https://github.com/shurkanTwo/NINASonyCameraPlugin/releases/tag/1.0.0.7). Choose the release asset, rather than GitHub's automatic “Source code” archives. Extract it to a temporary folder. The plugin is `NINA.RetroKiwi.Plugin.SonyCamera.dll`. +1. Download **`SonyCameraPlugin-1.0.0.5.zip`** from the [1.0.0.5 release](https://github.com/shurkanTwo/NINASonyCameraPlugin/releases/tag/1.0.0.5). Choose the release asset, rather than GitHub's automatic “Source code” archives. Extract it to a temporary folder. The plugin is `NINA.RetroKiwi.Plugin.SonyCamera.dll`. 2. Disconnect the camera and focuser in NINA, then **close every NINA window** before changing plugin files. 3. Press **Win+R**, enter `%LOCALAPPDATA%\NINA\Plugins`, and open the plugin-version folder used by your NINA installation. NINA 3.x installations commonly use **`3.0.0`**: this folder tracks plugin compatibility, so it need not match the NINA version in About. If several version folders exist, use the one in NINA's startup log (`%LOCALAPPDATA%\NINA\Logs`); look for the path from which the Sony plugin was loaded. 4. If Sony Camera Plugin is already installed, locate its existing `NINA.RetroKiwi.Plugin.SonyCamera.dll` and copy the entire containing plugin folder **outside `%LOCALAPPDATA%\NINA\Plugins`** as a backup. Replace the DLL **in that existing folder**, even if the folder name differs from the example. Do not create another plugin folder containing a second copy. Keep the rest of the existing folder's files. @@ -29,7 +34,7 @@ remains unverified for this combined release. See the release notes for scope. 6. Copy the extracted DLL into the existing or newly created folder. The ZIP also contains the license, source reference, and these instructions; you can keep those files alongside it. It contains no replacement NINA runtime libraries or native Sony driver. 7. If Windows shows an **Unblock** checkbox in the downloaded ZIP or DLL's Properties, unblock the file. Alternatively run `Unblock-File` in PowerShell on that downloaded ZIP/DLL before copying/extracting it. -8. Restart NINA. In its plugin manager, confirm **Sony Camera Plugin 1.0.0.7** is loaded; the description identifies the community-maintained build. Select the Sony camera in Equipment and connect it. +8. Restart NINA. In its plugin manager, confirm **Sony Camera Plugin 1.0.0.5** is loaded; the description identifies the community-maintained build. Select the Sony camera in Equipment and connect it. 9. Leave **Enable native cancel** disabled initially. Try one short exposure and check the downloaded image, ISO and exposure before using the build for a sequence. Temperature appears only after downloading an ARW that contains a supported Sony temperature reading. This is a replacement for the upstream plugin, with the same identifier so existing @@ -45,7 +50,7 @@ The release includes **`SHA256SUMS.txt`** for its ZIP and standalone DLL. In PowerShell, calculate a downloaded file's hash and compare it to the matching entry: ```powershell -Get-FileHash "$env:USERPROFILE\Downloads\SonyCameraPlugin-1.0.0.7.zip" -Algorithm SHA256 +Get-FileHash "$env:USERPROFILE\Downloads\SonyCameraPlugin-1.0.0.5.zip" -Algorithm SHA256 ``` ## Roll back diff --git a/Properties/AssemblyInfo.cs b/Properties/AssemblyInfo.cs index 0bb28a2..830e426 100644 --- a/Properties/AssemblyInfo.cs +++ b/Properties/AssemblyInfo.cs @@ -8,8 +8,8 @@ // [MANDATORY] The assembly versioning //Should be incremented for each new release build of a plugin -[assembly: AssemblyVersion("1.0.0.7")] -[assembly: AssemblyFileVersion("1.0.0.7")] +[assembly: AssemblyVersion("1.0.0.5")] +[assembly: AssemblyFileVersion("1.0.0.5")] // [MANDATORY] The name of your plugin [assembly: AssemblyTitle("Sony Camera Plugin")] diff --git a/README.md b/README.md index 98db151..8051c91 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ Native NINA plugin for Sony mirrorless/DSLR bodies over the Sony MTP interface, ## Installation -Download a maintained build from [this fork’s releases](https://github.com/shurkanTwo/NINASonyCameraPlugin/releases) and follow the **[manual installation instructions](INSTALLATION.md)**. The current release, **1.0.0.7**, is a regular GitHub release marked Latest; physical-camera validation remains outstanding. It replaces the upstream plugin; install one copy only. +Download a maintained build from [this fork’s releases](https://github.com/shurkanTwo/NINASonyCameraPlugin/releases) and follow the **[manual installation instructions](INSTALLATION.md)**. The current release, **1.0.0.5**, is a regular GitHub release marked Latest; physical-camera validation remains outstanding. It replaces the upstream plugin; install one copy only. The N.I.N.A. plugin manager currently distributes the upstream release. This fork has not been submitted as its update source. @@ -124,11 +124,11 @@ Menu locations and labels vary by Sony model; consult your camera's manual if th ## Metadata -- Version: 1.0.0.7 +- Version: 1.0.0.5 - Author: @dougforpres - Maintainer of this fork: [@shurkanTwo](https://github.com/shurkanTwo) - Contributors include [@totoantibes](https://github.com/totoantibes), [@christian-photo](https://github.com/christian-photo), and [@naixx](https://github.com/naixx); original commit authorship is preserved. -- Review and release scope: [session review and 1.0.0.7](docs/SESSION-REVIEW-1.0.0.7.md), [1.0.0.6 corrections](docs/RELEASE-REVIEW-1.0.0.6.md), and [upstream integration history](docs/UPSTREAM-REVIEW-1.0.0.5.md) +- Review and release scope: [session review](docs/SESSION-REVIEW.md), [corrective review](docs/CORRECTIVE-REVIEW.md), and [upstream integration history](docs/UPSTREAM-REVIEW.md) - Minimum NINA version: 3.2.0.3001 - License: MPL-2.0 (https://www.mozilla.org/en-US/MPL/2.0/) - Original author’s homepage: https://retro.kiwi diff --git a/docs/RELEASE-REVIEW-1.0.0.6.md b/docs/CORRECTIVE-REVIEW.md similarity index 71% rename from docs/RELEASE-REVIEW-1.0.0.6.md rename to docs/CORRECTIVE-REVIEW.md index b7d7102..88e2cb4 100644 --- a/docs/RELEASE-REVIEW-1.0.0.6.md +++ b/docs/CORRECTIVE-REVIEW.md @@ -1,6 +1,6 @@ -# Corrective review: 1.0.0.6 community release +# Corrective review of the upstream integration -This release addresses all four findings from the follow-up audit of 1.0.0.5. It retains that release's original contributor history and adapted work. @dougforpres remains the original author; @totoantibes's PR #13 remains credited as the source of the native stability and shutter retry work. The original MPL-2.0 license is unchanged. +The corrections at [`0341e8f`](https://github.com/shurkanTwo/NINASonyCameraPlugin/tree/0341e8f9cf6e5e1c5b13352d485285e00300df0e) address all four findings from the follow-up audit of the initial integration at `413290f`. They are included in the consolidated 1.0.0.5 release, retaining the original contributor history and adapted work. @dougforpres remains the original author; @totoantibes's PR #13 remains credited as the source of the native stability and shutter retry work. The original MPL-2.0 license is unchanged. ## Corrections @@ -17,8 +17,8 @@ Regression cases cover blocked preflight with native cancel both enabled and dis The Windows workflow runs the portable capture/native-policy suite, ARW temperature suite, full-plugin simulator integration suite and release build before packaging the manual-install DLL/ZIP and SHA256 checksums. SOURCE.txt records the exact source commit and build run. -These checks do not establish physical Sony camera, USB/MTP, lens, LiveView or complete Sky Flat compatibility. The release was initially published as a preview and later marked regular/Latest with unchanged binaries. Version 1.0.0.7 subsequently corrects metadata and documentation; physical-camera validation is still required. Experimental USB reconnection, retries of still-running timed-out calls, forced cancellation of busy captures and closed WIP #12 video intervals remain deferred. +These checks do not establish physical Sony camera, USB/MTP, lens, LiveView or complete Sky Flat compatibility. The [session review](SESSION-REVIEW.md) subsequently corrected the exposure-failure classification, metadata and documentation. All of these fixes are included in the consolidated release; physical-camera validation is still required. Experimental USB reconnection, retries of still-running timed-out calls, forced cancellation of busy captures and closed WIP #12 video intervals remain deferred. ## Installation and history -Use [INSTALLATION.md](../INSTALLATION.md) and install one copy of the maintained plugin. This fork is not an automatic update source in NINA's plugin manager. Version 1.0.0.5 remains available as historical release evidence; its follow-up findings and these corrections are recorded explicitly rather than replacing its assets or tag. +Use [INSTALLATION.md](../INSTALLATION.md) and install one copy of the maintained plugin. This fork is not an automatic update source in NINA's plugin manager. Earlier build sources remain available through the immutable commit links above. Intermediate release entries and tags are retired in favor of one combined package; users of any earlier maintenance build should download the consolidated package again and replace the DLL manually. diff --git a/docs/SESSION-REVIEW-1.0.0.7.md b/docs/SESSION-REVIEW-1.0.0.7.md deleted file mode 100644 index 78d5c74..0000000 --- a/docs/SESSION-REVIEW-1.0.0.7.md +++ /dev/null @@ -1,21 +0,0 @@ -# Session review and maintenance release 1.0.0.7 - -The session review compared the maintained plugin against upstream 1.0.0.4 (`8bd9042bcd477fd028c2aa2adfe34260192de936`) and reviewed the 1.0.0.6 release (`0341e8f9cf6e5e1c5b13352d485285e00300df0e`), native-driver release/candidate and public announcements separately. The requested scope includes original commit attribution, manual installation, regular/Latest releases and GitHub-handle credits. - -## Standards - -The review found one remaining requirement violation: authored credit text still contained real names in plugin display metadata, the packaged SOURCE.txt, README, installation guide, changelog, source comments and review records. Version 1.0.0.7 uses @dougforpres, @shurkanTwo, @totoantibes and @christian-photo in those places. The original legal copyright notice, MPL-2.0 license and commit author metadata are preserved. No additional introduced runtime blocker or actionable baseline smell was found. - -## Spec - -The README still identified 1.0.0.5 and described all maintained releases as previews after 1.0.0.6 became a regular release. Current documentation now identifies 1.0.0.7, manual installation and the actual GitHub release classification. Automated test results remain separate from physical-camera acceptance. - -The audit also inspected [the duplicate-popup report](https://github.com/shurkanTwo/NINASonyCameraPlugin/issues/5). In NINA 3.2, a generic busy-start exception selects notification handlers in both [ImagingVM](https://github.com/isbeorn/nina/blob/2393eae581145ed5b8114bf07c48ca2580540fd5/NINA/ViewModel/ImagingVM.cs#L260) and [AnchorableSnapshotVM](https://github.com/isbeorn/nina/blob/2393eae581145ed5b8114bf07c48ca2580540fd5/NINA/ViewModel/Imaging/AnchorableSnapshotVM.cs#L411). The latter deliberately handles CameraExposureFailedException without a second notification. The plugin now uses that typed failure and preserves its message and inner cause. The existing integration test checks the failure classification, prior cancellation, one soft-abort warning and absence of native cancellation. This establishes a duplicate-notification mechanism, not the exact count of three in the screenshot; the complete UI report still needs confirmation. - -## Validation and publication - -The Windows release workflow runs the capture/native-policy, temperature and plugin-integration suites and builds/packages the plugin. Release notes identify the successful build and exact source commit for 1.0.0.7. Changes comprise the capture-start failure classification, version/display metadata, attribution comments, packaging credit text and documentation. Busy captures remain rejected and native cancellation is not forced. - -Published 1.0.0.5 and 1.0.0.6 binaries, tags and checksums remain historical artifacts. Their release notes point to the maintained release; they are not silently replaced. Existing public announcements and the central upstream issue link to the corrected release and retain issue-specific context. - -Physical Sony camera/USB/MTP, LiveView, lens operation and complete Sky Flat behavior remain unverified. NINA's plugin manager still uses the upstream release source. The native driver is a separate package, and its device-removal candidate remains experimental and outside the regular releases. See [installation and rollback](../INSTALLATION.md). diff --git a/docs/SESSION-REVIEW.md b/docs/SESSION-REVIEW.md new file mode 100644 index 0000000..dbc3c98 --- /dev/null +++ b/docs/SESSION-REVIEW.md @@ -0,0 +1,21 @@ +# Session review and combined maintenance release + +The session review compared the maintained plugin against upstream 1.0.0.4 (`8bd9042bcd477fd028c2aa2adfe34260192de936`) and reviewed the corrective build at [`0341e8f`](https://github.com/shurkanTwo/NINASonyCameraPlugin/tree/0341e8f9cf6e5e1c5b13352d485285e00300df0e), native-driver release/candidate and public announcements separately. The requested scope includes original commit attribution, manual installation, regular/Latest releases and GitHub-handle credits. + +## Standards + +The review found one remaining requirement violation: authored credit text still contained real names in plugin display metadata, the packaged SOURCE.txt, README, installation guide, changelog, source comments and review records. The combined release uses @dougforpres, @shurkanTwo, @totoantibes and @christian-photo in those places. The original legal copyright notice, MPL-2.0 license and commit author metadata are preserved. No additional introduced runtime blocker or actionable baseline smell was found. + +## Spec + +Earlier documentation had inconsistent version and preview/regular labels. Current documentation identifies the consolidated 1.0.0.5 package, manual installation and its regular/Latest GitHub release classification. Automated test results remain separate from physical-camera acceptance. + +The audit also inspected [the duplicate-popup report](https://github.com/shurkanTwo/NINASonyCameraPlugin/issues/5). In NINA 3.2, a generic busy-start exception selects notification handlers in both [ImagingVM](https://github.com/isbeorn/nina/blob/2393eae581145ed5b8114bf07c48ca2580540fd5/NINA/ViewModel/ImagingVM.cs#L260) and [AnchorableSnapshotVM](https://github.com/isbeorn/nina/blob/2393eae581145ed5b8114bf07c48ca2580540fd5/NINA/ViewModel/Imaging/AnchorableSnapshotVM.cs#L411). The latter deliberately handles CameraExposureFailedException without a second notification. The plugin now uses that typed failure and preserves its message and inner cause. The existing integration test checks the failure classification, prior cancellation, one soft-abort warning and absence of native cancellation. This establishes a duplicate-notification mechanism, not the exact count of three in the screenshot; the complete UI report still needs confirmation. + +## Validation and publication + +The Windows release workflow runs the capture/native-policy, temperature and plugin-integration suites and builds/packages the plugin. Release notes identify the successful build and exact source commit for the combined 1.0.0.5 package. Changes comprise the capture-start failure classification, version/display metadata, attribution comments, packaging credit text and documentation. Busy captures remain rejected and native cancellation is not forced. + +The reviewed fixes through [`992f520`](https://github.com/shurkanTwo/NINASonyCameraPlugin/tree/992f5202b655a4287288089dde5cd83b4eb54f5f) are rebuilt as one combined 1.0.0.5 release following upstream 1.0.0.4. The earlier maintenance release entries and tags are retired, and the 1.0.0.5 tag now identifies the consolidated source. Original commits and contributor history remain intact; historical review evidence uses immutable commit links. Public announcements link to the combined release and retain issue-specific context. Users of any earlier maintenance build must download this package again and replace the DLL manually, even if they previously installed a higher-numbered intermediate build. Runtime source is unchanged by the consolidation; the embedded version, documentation and package are rebuilt together. + +Physical Sony camera/USB/MTP, LiveView, lens operation and complete Sky Flat behavior remain unverified. NINA's plugin manager still uses the upstream release source. The native driver is a separate package, and its device-removal candidate remains experimental and outside the regular releases. See [installation and rollback](../INSTALLATION.md). diff --git a/docs/UPSTREAM-REVIEW-1.0.0.5.md b/docs/UPSTREAM-REVIEW.md similarity index 93% rename from docs/UPSTREAM-REVIEW-1.0.0.5.md rename to docs/UPSTREAM-REVIEW.md index d493242..7e487a0 100644 --- a/docs/UPSTREAM-REVIEW-1.0.0.5.md +++ b/docs/UPSTREAM-REVIEW.md @@ -1,6 +1,6 @@ -# Upstream review for community preview 1.0.0.5 +# Upstream contribution review -> Historical review of 1.0.0.5. A subsequent audit found gaps in cancellation, shutter verification and repeated-failure detection. These are corrected in [1.0.0.6](RELEASE-REVIEW-1.0.0.6.md); the original assessment below is retained as release history. +> Historical assessment of the initial integration at [`413290f`](https://github.com/shurkanTwo/NINASonyCameraPlugin/tree/413290f68b114cb0393e52ae8eabdf4f12bbd1da). A subsequent audit found gaps in cancellation, shutter verification and repeated-failure detection. The [corrective review](CORRECTIVE-REVIEW.md) supersedes the affected statements below, including the old shutter-ratio check. All corrections are included in the consolidated 1.0.0.5 release; this initial assessment is retained as review history. Reviewed against upstream `master`, commit `8bd9042bcd477fd028c2aa2adfe34260192de936` (upstream release 1.0.0.4).