All pylint errors fixed

Author: sergioteula

amazon_paapi/api.py

@@ -52,7 +52,7 @@ def __init__(
         except KeyError as error:
             raise InvalidArgumentException("Country code is not correct") from error
 
-        self._api = DefaultApi(key, secret, self._host, self.region)
+        self.api = DefaultApi(key, secret, self._host, self.region)
 
     def get_items(
         self,

amazon_paapi/errors/exceptions.py

@@ -9,52 +9,36 @@ def __init__(self, reason: str):
         self.reason = reason
 
     def __str__(self) -> str:
-        return "%s" % self.reason
+        return self.reason
 
 
 class InvalidArgumentException(AmazonException):
     """Raised when arguments are not correct."""
 
-    pass
-
 
 class AsinNotFoundException(AmazonException):
     """Raised if the ASIN for an item is not found."""
 
-    pass
-
 
 class ApiRequestException(AmazonException):
     """Raised if the request to Amazon API fails"""
 
-    pass
-
 
 class MalformedRequestException(AmazonException):
     """Raised if the request for Amazon API is not correctly formed"""
 
-    pass
-
 
 class ItemsNotFoundException(AmazonException):
     """Raised if no items are found"""
 
-    pass
-
 
 class TooManyRequestsException(AmazonException):
     """Raised when requests limit is reached"""
 
-    pass
-
 
 class InvalidPartnerTagException(AmazonException):
     """Raised if the partner tag is not present or invalid"""
 
-    pass
-
 
 class AssociateValidationException(AmazonException):
     """Raised when credentials are not valid for the selected country"""
-
-    pass

amazon_paapi/helpers/requests.py

@@ -36,19 +36,19 @@ def get_items_request(amazon_api, asin_chunk: List[str], **kwargs) -> GetItemsRe
             marketplace=amazon_api.marketplace,
             partner_tag=amazon_api.tag,
             item_ids=asin_chunk,
-            **kwargs
+            **kwargs,
         )
-    except TypeError as e:
+    except TypeError as exc:
         raise MalformedRequestException(
-            "Parameters for get_items request are not correct: " + str(e)
-        )
+            f"Parameters for get_items request are not correct: {exc}"
+        ) from exc
 
 
 def get_items_response(amazon_api, request: GetItemsRequest) -> List[Item]:
     try:
-        response = amazon_api._api.get_items(request)
-    except ApiException as e:
-        _manage_response_exceptions(e)
+        response = amazon_api.api.get_items(request)
+    except ApiException as exc:
+        _manage_response_exceptions(exc)
 
     if response.items_result is None:
         raise ItemsNotFoundException("No items have been found")
@@ -63,19 +63,19 @@ def get_search_items_request(amazon_api, **kwargs) -> SearchItemsRequest:
             partner_type=PartnerType.ASSOCIATES,
             marketplace=amazon_api.marketplace,
             partner_tag=amazon_api.tag,
-            **kwargs
+            **kwargs,
         )
-    except TypeError as e:
+    except TypeError as exc:
         raise MalformedRequestException(
-            "Parameters for search_items request are not correct: " + str(e)
-        )
+            f"Parameters for search_items request are not correct: {exc}"
+        ) from exc
 
 
 def get_search_items_response(amazon_api, request: SearchItemsRequest) -> SearchResult:
     try:
-        response = amazon_api._api.search_items(request)
-    except ApiException as e:
-        _manage_response_exceptions(e)
+        response = amazon_api.api.search_items(request)
+    except ApiException as exc:
+        _manage_response_exceptions(exc)
 
     if response.search_result is None:
         raise ItemsNotFoundException("No items have been found")
@@ -90,21 +90,21 @@ def get_variations_request(amazon_api, **kwargs) -> GetVariationsRequest:
             partner_type=PartnerType.ASSOCIATES,
             marketplace=amazon_api.marketplace,
             partner_tag=amazon_api.tag,
-            **kwargs
+            **kwargs,
         )
-    except TypeError as e:
+    except TypeError as exc:
         raise MalformedRequestException(
-            "Parameters for get_variations request are not correct: " + str(e)
-        )
+            f"Parameters for get_variations request are not correct: {exc}"
+        ) from exc
 
 
 def get_variations_response(
     amazon_api, request: GetVariationsRequest
 ) -> VariationsResult:
     try:
-        response = amazon_api._api.get_variations(request)
-    except ApiException as e:
-        _manage_response_exceptions(e)
+        response = amazon_api.api.get_variations(request)
+    except ApiException as exc:
+        _manage_response_exceptions(exc)
 
     if response.variations_result is None:
         raise ItemsNotFoundException("No variation items have been found")
@@ -119,21 +119,21 @@ def get_browse_nodes_request(amazon_api, **kwargs) -> GetBrowseNodesRequest:
             partner_type=PartnerType.ASSOCIATES,
             marketplace=amazon_api.marketplace,
             partner_tag=amazon_api.tag,
-            **kwargs
+            **kwargs,
         )
-    except TypeError as e:
+    except TypeError as exc:
         raise MalformedRequestException(
-            "Parameters for get_browse_nodes request are not correct: " + str(e)
-        )
+            f"Parameters for get_browse_nodes request are not correct: {exc}"
+        ) from exc
 
 
 def get_browse_nodes_response(
     amazon_api, request: GetBrowseNodesRequest
 ) -> List[BrowseNode]:
     try:
-        response = amazon_api._api.get_browse_nodes(request)
-    except ApiException as e:
-        _manage_response_exceptions(e)
+        response = amazon_api.api.get_browse_nodes(request)
+    except ApiException as exc:
+        _manage_response_exceptions(exc)
 
     if response.browse_nodes_result is None:
         raise ItemsNotFoundException("No browse nodes have been found")
@@ -157,16 +157,16 @@ def _manage_response_exceptions(error) -> None:
                 " trying again"
             )
 
-        elif "InvalidParameterValue" in error.body:
+        if "InvalidParameterValue" in error.body:
             raise InvalidArgumentException(
                 "The value provided in the request for atleast one parameter is"
                 " invalid."
             )
 
-        elif "InvalidPartnerTag" in error.body:
+        if "InvalidPartnerTag" in error.body:
             raise InvalidArgumentException("The partner tag is invalid or not present.")
 
-        elif "InvalidAssociate" in error.body:
+        if "InvalidAssociate" in error.body:
             raise AssociateValidationException(
                 "Used credentials are not valid for the selected country."
             )

examples/example.py

@@ -2,6 +2,7 @@
 
 from amazon_paapi import AmazonApi
 
+# pylint: disable=no-member
 amazon = AmazonApi(
     secrets.KEY, secrets.SECRET, secrets.TAG, secrets.COUNTRY, throttling=2
 )

pyproject.toml

@@ -8,7 +8,8 @@ skip_glob = "*/sdk/*"
 
 [tool.pylint]
     [tool.pylint.master]
-        ignore-paths = ".*/sdk"
+        ignore = ["test.py"]
+        ignore-paths = [".*/sdk", ".*/docs"]
     [tool.pylint.message_control]
         disable = [
             "too-many-instance-attributes",

setup.py

@@ -1,6 +1,6 @@
 import setuptools
 
-with open("README.md", "r") as fh:
+with open("README.md", "r", encoding="utf8") as fh:
     long_description = fh.read()
 
 setuptools.setup(