Updated arguments helper

Author: sergioteula

amazon_paapi/helpers/arguments.py

@@ -3,7 +3,7 @@
 
 from typing import List, Union
 
-from ..errors import AsinNotFound, InvalidArgument
+from ..errors import InvalidArgument
 from ..tools import get_asin
 
 
@@ -20,27 +20,24 @@ def get_items_ids(items: Union[str, List[str]]) -> List[str]:
     else:
         items_ids = [get_asin(x.strip()) for x in items]
 
-    if items_ids:
-        return items_ids
-
-    raise AsinNotFound("No ASIN codes have been found.")
+    return items_ids
 
 
 def check_search_args(**kwargs):
-    _check_search_mandatory_args(**kwargs)
-    _check_search_pagination_args(**kwargs)
+    check_search_mandatory_args(**kwargs)
+    check_search_pagination_args(**kwargs)
 
 
-def _check_search_mandatory_args(**kwargs):
+def check_search_mandatory_args(**kwargs):
     mandatory_args = [
-        kwargs["keywords"],
-        kwargs["actor"],
-        kwargs["artist"],
-        kwargs["author"],
-        kwargs["brand"],
-        kwargs["title"],
-        kwargs["browse_node_id"],
-        kwargs["search_index"],
+        kwargs.get("keywords"),
+        kwargs.get("actor"),
+        kwargs.get("artist"),
+        kwargs.get("author"),
+        kwargs.get("brand"),
+        kwargs.get("title"),
+        kwargs.get("browse_node_id"),
+        kwargs.get("search_index"),
     ]
     if all(arg is None for arg in mandatory_args):
         error_message = (
@@ -50,9 +47,9 @@ def _check_search_mandatory_args(**kwargs):
         raise InvalidArgument(error_message)
 
 
-def _check_search_pagination_args(**kwargs):
+def check_search_pagination_args(**kwargs):
     error_message = "Args item_count and item_page should be integers between 1 and 10."
-    pagination_args = [kwargs["item_count"], kwargs["item_page"]]
+    pagination_args = [kwargs.get("item_count"), kwargs.get("item_page")]
     pagination_args = [arg for arg in pagination_args if arg]
 
     if not all(isinstance(arg, int) for arg in pagination_args):
@@ -66,7 +63,7 @@ def check_variations_args(**kwargs):
     error_message = (
         "Args variation_count and variation_page should be integers between 1 and 10."
     )
-    variation_args = [kwargs["variation_count"], kwargs["variation_page"]]
+    variation_args = [kwargs.get("variation_count"), kwargs.get("variation_page")]
     variation_args = [arg for arg in variation_args if arg]
 
     if not all(isinstance(arg, int) for arg in variation_args):
@@ -77,6 +74,6 @@ def check_variations_args(**kwargs):
 
 
 def check_browse_nodes_args(**kwargs):
-    if not isinstance(kwargs["browse_node_ids"], List):
+    if not isinstance(kwargs.get("browse_node_ids"), List):
         error_message = "Argument browse_node_ids should be a List of strings."
         raise InvalidArgument(error_message)

tests/test_helpers_arguments.py

@@ -2,9 +2,9 @@
 
 from amazon_paapi.errors import AsinNotFound, InvalidArgument
 from amazon_paapi.helpers.arguments import (
-    _check_search_mandatory_args,
-    _check_search_pagination_args,
     check_browse_nodes_args,
+    check_search_mandatory_args,
+    check_search_pagination_args,
     check_variations_args,
     get_items_ids,
 )
@@ -56,22 +56,22 @@ def test_get_items_ids_invalid_argument(self):
             get_items_ids(34)
 
     def test_check_search_mandatory_args_correct(self):
-        _check_search_mandatory_args(actor="John Doe")
+        check_search_mandatory_args(actor="John Doe")
 
     def test_check_search_mandatory_args_raises_exception(self):
         with self.assertRaises(InvalidArgument):
-            _check_search_mandatory_args()
+            check_search_mandatory_args()
 
     def test_check_search_pagination_args_correct(self):
-        _check_search_pagination_args(item_count=1, item_page=10)
+        check_search_pagination_args(item_count=1, item_page=10)
 
     def test_check_search_pagination_args_if_not_integers(self):
         with self.assertRaises(InvalidArgument):
-            _check_search_pagination_args(item_count=True, item_page="test")
+            check_search_pagination_args(item_count=True, item_page="test")
 
     def test_check_search_pagination_args_if_not_between_1_10(self):
         with self.assertRaises(InvalidArgument):
-            _check_search_pagination_args(item_count=0, item_page=11)
+            check_search_pagination_args(item_count=0, item_page=11)
 
     def test_check_check_variations_args_correct(self):
         check_variations_args(variation_count=1, variation_page=10)