Fix warnings

Author: phil-opp

bios/boot_sector/src/fail.rs

@@ -54,6 +54,7 @@ fn hlt() {
 }
 
 #[panic_handler]
+#[cfg(not(test))]
 pub fn panic(_info: &core::panic::PanicInfo) -> ! {
     fail(b'P');
 }

bios/boot_sector/src/mbr.rs

@@ -1,19 +1,5 @@
 use super::fail::{fail, UnwrapOrFail};
 
-/// We use this partition type to store the second bootloader stage;
-const BOOTLOADER_SECOND_STAGE_PARTITION_TYPE: u8 = 0x20;
-
-/// Returns the first bootable partition in the partition table.
-pub(crate) fn boot_partition(partitions_raw: &[u8]) -> Option<PartitionTableEntry> {
-    for index in 0..4 {
-        let entry = get_partition(partitions_raw, index);
-        if entry.partition_type == BOOTLOADER_SECOND_STAGE_PARTITION_TYPE {
-            return Some(entry);
-        }
-    }
-    None
-}
-
 pub(crate) fn get_partition(partitions_raw: &[u8], index: usize) -> PartitionTableEntry {
     const PARTITIONS_AREA_SIZE: usize = 16 * 4;
     const ENTRY_SIZE: usize = 16;

bios/stage-2/src/fat.rs

@@ -189,7 +189,6 @@ impl<D: Read + Seek> FileSystem<D> {
                 },
                 None => {
                     panic!("next none");
-                    return None;
                 }
             },
         };

bios/stage-2/src/screen.rs

@@ -36,6 +36,7 @@ impl core::fmt::Write for Writer {
 }
 
 #[panic_handler]
+#[cfg(not(test))]
 pub fn panic(info: &core::panic::PanicInfo) -> ! {
     let _ = writeln!(Writer, "\nPANIC: {}", info);
 

bios/stage-2/src/vesa.rs

@@ -3,9 +3,10 @@
 use bootloader_x86_64_bios_common::PixelFormat;
 
 use crate::{disk::AlignedBuffer, AlignedArrayBuffer};
-use core::{arch::asm, fmt::Write as _};
+use core::arch::asm;
 
 #[repr(packed)]
+#[allow(dead_code)]
 struct VbeInfoBlock {
     signature: [u8; 4], // should be "VESA"
     version: u16,       // should be 0x0300 for VBE 3.0

bios/stage-3/src/main.rs

@@ -67,6 +67,7 @@ pub fn enter_long_mode_and_jump_to_stage_4(info: &mut BiosInfo) {
 }
 
 #[panic_handler]
+#[cfg(not(test))]
 pub fn panic(info: &core::panic::PanicInfo) -> ! {
     let _ = writeln!(Writer, "PANIC: {info}");
     loop {}

bios/stage-3/src/screen.rs

@@ -25,8 +25,6 @@ pub fn init(info: BiosFramebufferInfo) {
 
 /// Additional vertical space between lines
 const LINE_SPACING: usize = 0;
-/// Additional vertical space between separate log messages
-const LOG_SPACING: usize = 2;
 
 struct ScreenWriter {
     framebuffer: &'static mut [u8],
@@ -52,10 +50,6 @@ impl ScreenWriter {
         self.carriage_return()
     }
 
-    fn add_vspace(&mut self, space: usize) {
-        self.y_pos += space;
-    }
-
     fn carriage_return(&mut self) {
         self.x_pos = 0;
     }