Move the check_call method to BenchmarkRunner module

And add tests to it.

Author: rafaelfranca

lib/benchmark_runner.rb

@@ -80,4 +80,21 @@ def setarch_prefix
 
     prefix
   end
+
+  # Checked system - error or return info if the command fails
+  def check_call(command, env: {}, raise_error: true, quiet: false)
+    puts("+ #{command}") unless quiet
+
+    result = {}
+
+    result[:success] = system(env, command)
+    result[:status] = $?
+
+    unless result[:success]
+      puts "Command #{command.inspect} failed with exit code #{result[:status].exitstatus} in directory #{Dir.pwd}"
+      raise RuntimeError.new if raise_error
+    end
+
+    result
+  end
 end

run_benchmarks.rb

@@ -15,23 +15,6 @@
 require_relative 'lib/table_formatter'
 require_relative 'lib/benchmark_filter'
 
-# Checked system - error or return info if the command fails
-def check_call(command, env: {}, raise_error: true, quiet: false)
-  puts("+ #{command}") unless quiet
-
-  result = {}
-
-  result[:success] = system(env, command)
-  result[:status] = $?
-
-  unless result[:success]
-    puts "Command #{command.inspect} failed with exit code #{result[:status].exitstatus} in directory #{Dir.pwd}"
-    raise RuntimeError.new if raise_error
-  end
-
-  result
-end
-
 def check_output(*command)
   IO.popen(*command, &:read)
 end
@@ -46,17 +29,17 @@ def set_bench_config(turbo:)
   # sudo requires the flag '-S' in order to take input from stdin
   if File.exist?('/sys/devices/system/cpu/intel_pstate') # Intel
     unless intel_no_turbo? || turbo
-      check_call("sudo -S sh -c 'echo 1 > /sys/devices/system/cpu/intel_pstate/no_turbo'")
-      at_exit { check_call("sudo -S sh -c 'echo 0 > /sys/devices/system/cpu/intel_pstate/no_turbo'", quiet: true) }
+      BenchmarkRunner.check_call("sudo -S sh -c 'echo 1 > /sys/devices/system/cpu/intel_pstate/no_turbo'")
+      at_exit { BenchmarkRunner.check_call("sudo -S sh -c 'echo 0 > /sys/devices/system/cpu/intel_pstate/no_turbo'", quiet: true) }
     end
     # Disabling Turbo Boost reduces the CPU frequency, so this should be run after that.
-    check_call("sudo -S sh -c 'echo 100 > /sys/devices/system/cpu/intel_pstate/min_perf_pct'") unless intel_perf_100pct?
+    BenchmarkRunner.check_call("sudo -S sh -c 'echo 100 > /sys/devices/system/cpu/intel_pstate/min_perf_pct'") unless intel_perf_100pct?
   elsif File.exist?('/sys/devices/system/cpu/cpufreq/boost') # AMD
     unless amd_no_boost? || turbo
-      check_call("sudo -S sh -c 'echo 0 > /sys/devices/system/cpu/cpufreq/boost'")
-      at_exit { check_call("sudo -S sh -c 'echo 1 > /sys/devices/system/cpu/cpufreq/boost'", quiet: true) }
+      BenchmarkRunner.check_call("sudo -S sh -c 'echo 0 > /sys/devices/system/cpu/cpufreq/boost'")
+      at_exit { BenchmarkRunner.check_call("sudo -S sh -c 'echo 1 > /sys/devices/system/cpu/cpufreq/boost'", quiet: true) }
     end
-    check_call("sudo -S cpupower frequency-set -g performance") unless performance_governor?
+    BenchmarkRunner.check_call("sudo -S cpupower frequency-set -g performance") unless performance_governor?
   end
 end
 
@@ -230,7 +213,7 @@ def run_benchmarks(ruby:, ruby_description:, categories:, name_filters:, out_pat
       end
 
       # Do the benchmarking
-      result = check_call(cmd.shelljoin, env: env, raise_error: false)
+      result = BenchmarkRunner.check_call(cmd.shelljoin, env: env, raise_error: false)
 
       if result[:success]
         bench_data[bench_name] = JSON.parse(File.read(result_json_path)).tap do |json|

test/benchmark_runner_test.rb

@@ -170,6 +170,82 @@
     end
   end
 
+  describe '.check_call' do
+    it 'runs a successful command and returns success status' do
+      result = nil
+
+      capture_io do
+        result = BenchmarkRunner.check_call('true')
+      end
+
+      assert_equal true, result[:success]
+      assert_equal 0, result[:status].exitstatus
+    end
+
+    it 'prints the command by default' do
+      output = capture_io do
+        BenchmarkRunner.check_call('true')
+      end
+
+      assert_includes output[0], '+ true'
+    end
+
+    it 'suppresses output when quiet is true' do
+      output = capture_io do
+        BenchmarkRunner.check_call('true', quiet: true)
+      end
+
+      assert_equal '', output[0]
+    end
+
+    it 'raises error by default when command fails' do
+      output = capture_io do
+        assert_raises(RuntimeError) do
+          BenchmarkRunner.check_call('false')
+        end
+      end
+
+      assert_includes output[0], 'Command "false" failed'
+    end
+
+    it 'does not raise error when raise_error is false' do
+      output = capture_io do
+        result = BenchmarkRunner.check_call('false', raise_error: false)
+
+        assert_equal false, result[:success]
+        assert_equal 1, result[:status].exitstatus
+      end
+
+      assert_includes output[0], 'Command "false" failed'
+    end
+
+    it 'passes environment variables to the command' do
+      Dir.mktmpdir do |dir|
+        output_file = File.join(dir, 'test_output.txt')
+        output = capture_io do
+          result = BenchmarkRunner.check_call("sh -c 'echo $TEST_VAR > #{output_file}'", env: { 'TEST_VAR' => 'hello' })
+          assert_equal true, result[:success]
+        end
+
+        # Command should be printed
+        assert_includes output[0], "+ sh -c 'echo $TEST_VAR"
+        # Environment variable should be written to file
+        assert_equal "hello\n", File.read(output_file)
+      end
+    end
+
+    it 'includes exit code and directory in error message' do
+      output = capture_io do
+        result = BenchmarkRunner.check_call('sh -c "exit 42"', raise_error: false)
+        assert_equal false, result[:success]
+        assert_equal 42, result[:status].exitstatus
+      end
+
+      assert_includes output[0], 'exit code 42'
+      assert_includes output[0], "directory #{Dir.pwd}"
+    end
+  end
+
   describe '.setarch_prefix' do
     it 'returns an array' do
       result = BenchmarkRunner.setarch_prefix