Skip to content

Commit 34afd36

Browse files
committed
Reenable sorbet in CI
We made some incompatible type changes with MissingNode but shouldn't fail typecheck for that Just stub it back in so it can run in CI
1 parent 0808b31 commit 34afd36

3 files changed

Lines changed: 15 additions & 4 deletions

File tree

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ jobs:
5151
with:
5252
ruby-version: "3.4"
5353
bundler-cache: true
54-
# - name: Check Sorbet
55-
# run: bundle exec rake typecheck:tapioca typecheck:sorbet
54+
- name: Check Sorbet
55+
run: bundle exec rake typecheck:tapioca typecheck:sorbet
5656
- name: Check Steep
5757
run: bundle exec rake typecheck:steep
5858
- name: Check field kinds

rakelib/check_manifest.rake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ task check_manifest: :templates do
5555
compile_commands.json
5656
include/prism/config.h
5757
lib/prism/prism.{so,bundle,jar}
58-
sig/_*/*.rbs
59-
sig/**/_*/*.rbs
58+
rbi/_shims/*.rbi
59+
sig/_shims/*.rbs
6060
tags
6161
]
6262

rbi/_shims/spoom.rbi

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# typed: strict
2+
3+
# Spoom hasn't yet adopted ErrorRecoveryNode
4+
module Prism
5+
class MissingNode < Node; end
6+
7+
class Visitor
8+
sig { params(node: MissingNode).void }
9+
def visit_missing_node(node); end
10+
end
11+
end

0 commit comments

Comments
 (0)