From 7e25762a9347c9219fb1ea08bf36b83018123dae Mon Sep 17 00:00:00 2001 From: Erik Arvidsson Date: Mon, 19 Oct 2026 12:35:49 +0000 Subject: [PATCH] ci: remove the bump-version workflow It pushes the version commit straight to main, which the main ruleset rejects: changes must go through a pull request and the merge queue, and its commits aren't signed by an allowed key. Document bumping the version in a pull request instead, as done for 1.1.5 and 1.1.6. --- .github/workflows/bump-version.yml | 41 ------------------------------ docs/contribution.md | 12 ++++----- 2 files changed, 6 insertions(+), 47 deletions(-) delete mode 100644 .github/workflows/bump-version.yml diff --git a/.github/workflows/bump-version.yml b/.github/workflows/bump-version.yml deleted file mode 100644 index 0ae59c1..0000000 --- a/.github/workflows/bump-version.yml +++ /dev/null @@ -1,41 +0,0 @@ -name: bump-version - -on: - workflow_dispatch: - inputs: - type: - type: choice - description: Type of version bump - required: true - options: - - patch - - minor - - major - -jobs: - bump: - name: Bump to a new version - runs-on: ubuntu-latest - permissions: - contents: write # Required to push the version commit and tag. - steps: - - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 - with: - # Use the built-in GITHUB_TOKEN (no PAT secret needed). Note: pushes - # made with GITHUB_TOKEN do not trigger further workflows, so the - # release that publishes to npm must still be created manually (which - # fires the `release` event that the publish job listens for). - fetch-depth: 0 - - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 - with: - node-version: 20 - - name: Configure user - run: | - git config --local user.name "${{ github.actor }}" - git config --local user.email "${{ github.actor }}@users.noreply.github.com" - - name: Bump the version - run: npm version ${{ github.event.inputs.type }} - - name: Push commit - run: git push origin HEAD:main - - name: Push tag - run: git push origin --tags diff --git a/docs/contribution.md b/docs/contribution.md index 2f6fa58..e52f2d2 100644 --- a/docs/contribution.md +++ b/docs/contribution.md @@ -137,11 +137,11 @@ People love `better-sqlite3` because of its robustness and reliability. Each and Trusted contributors have the privileges necessary to create a release. Here are the steps to create a release: -1. Run [this workflow](https://github.com/WiseLibs/better-sqlite3/actions/workflows/bump-version.yml) from the `master` branch to create a new version tag - - Select `patch` for bug fixes and general maintenance - - Select `minor` for larger releases with new features - - Select `major` for releases with backwards-incompatible changes -2. [Draft a new release](https://github.com/WiseLibs/better-sqlite3/releases/new), and select the version tag that you just created +1. Open a pull request that bumps `version` in `package.json` (e.g. `npm version patch --no-git-tag-version`), and merge it through the merge queue + - Bump `patch` for bug fixes and general maintenance + - Bump `minor` for larger releases with new features + - Bump `major` for releases with backwards-incompatible changes +2. [Draft a new release](https://github.com/rocicorp/zero-sqlite3/releases/new) with a new tag `v` on the merged commit 3. Leave the "Release title" blank, and click "Auto-generate release notes" 4. Click "Publish release" -5. Wait for the `build` job to complete ([here](https://github.com/WiseLibs/better-sqlite3/actions)) +5. Wait for the `build` job to complete ([here](https://github.com/rocicorp/zero-sqlite3/actions/workflows/build.yml))