Skip to content

Commit d834e31

Browse files
committed
Fix deprecation warnings in unit tests and improve logging for approval tests
1 parent 423ebb8 commit d834e31

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

utest/test/api/test_plugin_documentation.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22
import unittest
33

44
from approvaltests.approvals import verify
5+
from approvaltests.reporters.first_working_reporter import FirstWorkingReporter
56
from approvaltests.reporters.generic_diff_reporter_factory import (
67
GenericDiffReporterFactory,
78
)
9+
from approvaltests.reporters.python_native_reporter import PythonNativeReporter
810
from robot.utils import WINDOWS
911

1012
from SeleniumLibrary import SeleniumLibrary
@@ -24,7 +26,9 @@ def setUp(self):
2426
)
2527
factory = GenericDiffReporterFactory()
2628
factory.load(reporter_json)
27-
self.reporter = factory.get_first_working()
29+
self.reporter = FirstWorkingReporter(
30+
factory.get_first_working(), PythonNativeReporter()
31+
)
2832

2933
@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
3034
def test_many_plugins(self):

utest/test/keywords/test_browsermanagement.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import pytest
2-
from mockito import when, mock, verify, verifyNoMoreInteractions, ANY
2+
from mockito import when, mock, verify, ensureNoUnverifiedInteractions, ANY
33
from selenium import webdriver
44
from selenium.webdriver.chrome.service import Service as ChromeService
55
from selenium.webdriver.chrome.service import Service
@@ -21,8 +21,8 @@ def test_set_selenium_timeout_only_affects_open_browsers():
2121
verify(second_browser).set_script_timeout(10.0)
2222
ctx._drivers.active_drivers = []
2323
bm.set_selenium_timeout("20 seconds")
24-
verifyNoMoreInteractions(first_browser)
25-
verifyNoMoreInteractions(second_browser)
24+
ensureNoUnverifiedInteractions(first_browser)
25+
ensureNoUnverifiedInteractions(second_browser)
2626

2727

2828
def test_action_chain_delay_default():

0 commit comments

Comments
 (0)