Tiny string copying refactor

Author: sgrowe

src/rescript.rs

@@ -1,4 +1,4 @@
-use std::{env, fs};
+use std::{borrow::Cow, env, fs};
 use zed_extension_api::{self as zed, Result};
 
 const SERVER_PATH: &str = "node_modules/.bin/rescript-language-server";
@@ -13,11 +13,14 @@ impl ReScriptExtension {
         fs::metadata(SERVER_PATH).map_or(false, |stat| stat.is_file())
     }
 
-    fn server_script_path(&mut self, server_id: &zed::LanguageServerId) -> Result<String> {
+    fn server_script_path(
+        &mut self,
+        server_id: &zed::LanguageServerId,
+    ) -> Result<Cow<'static, str>> {
         let server_exists = self.server_exists();
         self.did_find_server = true;
         if self.did_find_server && server_exists {
-            return Ok(SERVER_PATH.to_string());
+            return Ok(SERVER_PATH.into());
         }
 
         zed::set_language_server_installation_status(
@@ -51,7 +54,8 @@ impl ReScriptExtension {
         }
 
         self.did_find_server = true;
-        Ok(SERVER_PATH.to_string())
+
+        Ok(SERVER_PATH.into())
     }
 }
 
@@ -68,12 +72,13 @@ impl zed::Extension for ReScriptExtension {
         _worktree: &zed::Worktree,
     ) -> Result<zed::Command> {
         let server_path = self.server_script_path(server_id)?;
+
         Ok(zed::Command {
             command: zed::node_binary_path()?,
             args: vec![
                 env::current_dir()
                     .unwrap()
-                    .join(&server_path)
+                    .join(server_path.as_ref())
                     .to_string_lossy()
                     .to_string(),
                 "--stdio".to_string(),