Allow postUpgradeTasks to "veto" an update
#42594
fschoenm
started this conversation in
Suggest an Idea
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Tell us more.
Hello, in my self-hosted instance of renovate, I configured a custom regex manager that allows finding updated dependencies from
conan.lockfiles, together with apostUpgradeTaskthat callsconan lock upgradeto correctly update the lockfile.However, due to how Conan lockfiles work, the above approach sometimes finds a newer dependency version than would be supported in the Conan dependency graph. This leads to an invalid PR, which will fail in the CI.
I would like to propose a feature where a
postUpgradeTaskcan "veto" an update if the call fails with an error code. To be backwards compatible, it could feature a new configuration optionpostUpgradeTask.abortOnFailureor similar, which defaults tofalse.I tried to understand the existing code around https://github.com/renovatebot/renovate/blob/main/lib/workers/repository/update/branch/index.ts#L669 and it seems like there are very specific conditions under which the PR doesn't get created (i.e. if the update is below 2h old ...) but most of the time it just creates an invalid PR.
Beta Was this translation helpful? Give feedback.
All reactions