From cb45a84bdb9447810f13901b9da1ed79e4efb25e Mon Sep 17 00:00:00 2001 From: Drahsid Date: Mon, 21 Sep 2026 21:30:12 -0400 Subject: [PATCH 1/2] Improve win32 --- plume_d3d12.cpp | 2 +- plume_render_interface_types.h | 4 ++-- plume_vulkan.cpp | 8 ++++---- plume_vulkan.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/plume_d3d12.cpp b/plume_d3d12.cpp index 2cdcf18..5e842c5 100644 --- a/plume_d3d12.cpp +++ b/plume_d3d12.cpp @@ -879,7 +879,7 @@ namespace plume { D3D12_CPU_DESCRIPTOR_HANDLE D3D12DescriptorHeapAllocator::getCPUHandleAt(uint32_t index) const { assert(index < heapSize); assert(cpuDescriptorHandle.ptr > 0); - return { cpuDescriptorHandle.ptr + uint64_t(index) * descriptorHandleIncrement }; + return { cpuDescriptorHandle.ptr + SIZE_T(index) * descriptorHandleIncrement }; } D3D12_GPU_DESCRIPTOR_HANDLE D3D12DescriptorHeapAllocator::getGPUHandleAt(uint32_t index) const { diff --git a/plume_render_interface_types.h b/plume_render_interface_types.h index 9dcfedf..04a6ad9 100644 --- a/plume_render_interface_types.h +++ b/plume_render_interface_types.h @@ -15,7 +15,7 @@ #include #include -#if defined(_WIN64) +#if defined(_WIN32) || defined(_WIN64) #include #elif defined(__ANDROID__) #include "android/native_window.h" @@ -34,7 +34,7 @@ #endif namespace plume { -#if defined(_WIN64) +#if defined(_WIN32) || defined(_WIN64) // Native HWND handle to the target window. typedef HWND RenderWindow; #elif defined(__ANDROID__) diff --git a/plume_vulkan.cpp b/plume_vulkan.cpp index f1dd503..e1b66be 100644 --- a/plume_vulkan.cpp +++ b/plume_vulkan.cpp @@ -48,7 +48,7 @@ namespace plume { # ifdef VULKAN_OBJECT_NAMES_ENABLED VK_EXT_DEBUG_UTILS_EXTENSION_NAME, # endif -# if defined(_WIN64) +# if defined(_WIN32) || defined(_WIN64) VK_KHR_WIN32_SURFACE_EXTENSION_NAME, # elif defined(__ANDROID__) VK_KHR_ANDROID_SURFACE_EXTENSION_NAME, @@ -1855,7 +1855,7 @@ namespace plume { this->descriptorSetCount = uint32_t(pipelineLayout->descriptorSetLayouts.size()); - VkResult res = vkCreateRayTracingPipelinesKHR(device->vk, nullptr, nullptr, 1, &pipelineInfo, nullptr, &vk); + VkResult res = vkCreateRayTracingPipelinesKHR(device->vk, VK_NULL_HANDLE, VK_NULL_HANDLE, 1, &pipelineInfo, nullptr, &vk); if (res != VK_SUCCESS) { fprintf(stderr, "vkCreateRayTracingPipelinesKHR failed with error code 0x%X.\n", res); return; @@ -2082,7 +2082,7 @@ namespace plume { VkResult res; -# ifdef _WIN64 +# if defined(_WIN32) || defined(_WIN64) assert(desc.renderWindow != 0); VkWin32SurfaceCreateInfoKHR surfaceCreateInfo = {}; surfaceCreateInfo.sType = VK_STRUCTURE_TYPE_WIN32_SURFACE_CREATE_INFO_KHR; @@ -2458,7 +2458,7 @@ namespace plume { } void VulkanSwapChain::getWindowSize(uint32_t &dstWidth, uint32_t &dstHeight) const { -# if defined(_WIN64) +# if defined(_WIN32) || defined(_WIN64) RECT rect; GetClientRect(desc.renderWindow, &rect); dstWidth = rect.right - rect.left; diff --git a/plume_vulkan.h b/plume_vulkan.h index 0a1edbe..9260869 100644 --- a/plume_vulkan.h +++ b/plume_vulkan.h @@ -14,7 +14,7 @@ #include #include -#if defined(_WIN64) +#if defined(_WIN32) || defined(_WIN64) #define VK_USE_PLATFORM_WIN32_KHR #elif defined(__ANDROID__) #define VK_USE_PLATFORM_ANDROID_KHR From 8a307cb11d351983e121882c221d9be579ae4c92 Mon Sep 17 00:00:00 2001 From: Drahsid Date: Mon, 21 Sep 2026 22:18:10 -0400 Subject: [PATCH 2/2] Simplify win32 + win64 guards to win32 --- plume_render_interface_types.h | 4 ++-- plume_vulkan.cpp | 6 +++--- plume_vulkan.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/plume_render_interface_types.h b/plume_render_interface_types.h index 04a6ad9..2281168 100644 --- a/plume_render_interface_types.h +++ b/plume_render_interface_types.h @@ -15,7 +15,7 @@ #include #include -#if defined(_WIN32) || defined(_WIN64) +#if defined(_WIN32) #include #elif defined(__ANDROID__) #include "android/native_window.h" @@ -34,7 +34,7 @@ #endif namespace plume { -#if defined(_WIN32) || defined(_WIN64) +#if defined(_WIN32) // Native HWND handle to the target window. typedef HWND RenderWindow; #elif defined(__ANDROID__) diff --git a/plume_vulkan.cpp b/plume_vulkan.cpp index e1b66be..4a2a489 100644 --- a/plume_vulkan.cpp +++ b/plume_vulkan.cpp @@ -48,7 +48,7 @@ namespace plume { # ifdef VULKAN_OBJECT_NAMES_ENABLED VK_EXT_DEBUG_UTILS_EXTENSION_NAME, # endif -# if defined(_WIN32) || defined(_WIN64) +# if defined(_WIN32) VK_KHR_WIN32_SURFACE_EXTENSION_NAME, # elif defined(__ANDROID__) VK_KHR_ANDROID_SURFACE_EXTENSION_NAME, @@ -2082,7 +2082,7 @@ namespace plume { VkResult res; -# if defined(_WIN32) || defined(_WIN64) +# if defined(_WIN32) assert(desc.renderWindow != 0); VkWin32SurfaceCreateInfoKHR surfaceCreateInfo = {}; surfaceCreateInfo.sType = VK_STRUCTURE_TYPE_WIN32_SURFACE_CREATE_INFO_KHR; @@ -2458,7 +2458,7 @@ namespace plume { } void VulkanSwapChain::getWindowSize(uint32_t &dstWidth, uint32_t &dstHeight) const { -# if defined(_WIN32) || defined(_WIN64) +# if defined(_WIN32) RECT rect; GetClientRect(desc.renderWindow, &rect); dstWidth = rect.right - rect.left; diff --git a/plume_vulkan.h b/plume_vulkan.h index 9260869..a0cf5cc 100644 --- a/plume_vulkan.h +++ b/plume_vulkan.h @@ -14,7 +14,7 @@ #include #include -#if defined(_WIN32) || defined(_WIN64) +#if defined(_WIN32) #define VK_USE_PLATFORM_WIN32_KHR #elif defined(__ANDROID__) #define VK_USE_PLATFORM_ANDROID_KHR