Skip to content

Commit 49ecaa4

Browse files
committed
Mark all classes as final
Classes should be used via composition rather than extension. This reduces our API footprint and avoids future BC breaks by avoiding exposing its internal assumptions.
1 parent ae230e5 commit 49ecaa4

6 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/CompositeStream.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Evenement\EventEmitter;
66

7-
class CompositeStream extends EventEmitter implements DuplexStreamInterface
7+
final class CompositeStream extends EventEmitter implements DuplexStreamInterface
88
{
99
protected $readable;
1010
protected $writable;

src/DuplexResourceStream.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
use React\EventLoop\LoopInterface;
77
use InvalidArgumentException;
88

9-
class DuplexResourceStream extends EventEmitter implements DuplexStreamInterface
9+
final class DuplexResourceStream extends EventEmitter implements DuplexStreamInterface
1010
{
1111
private $stream;
1212
private $loop;

src/ReadableResourceStream.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
use React\EventLoop\LoopInterface;
77
use InvalidArgumentException;
88

9-
class ReadableResourceStream extends EventEmitter implements ReadableStreamInterface
9+
final class ReadableResourceStream extends EventEmitter implements ReadableStreamInterface
1010
{
1111
/**
1212
* @var resource

src/ThroughStream.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
* @see DuplexStreamInterface::close()
7474
* @see WritableStreamInterface::pipe()
7575
*/
76-
class ThroughStream extends EventEmitter implements DuplexStreamInterface
76+
final class ThroughStream extends EventEmitter implements DuplexStreamInterface
7777
{
7878
private $readable = true;
7979
private $writable = true;

src/Util.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace React\Stream;
44

5-
class Util
5+
final class Util
66
{
77
/**
88
* Pipes all the data from the given $source into the $dest

src/WritableResourceStream.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Evenement\EventEmitter;
66
use React\EventLoop\LoopInterface;
77

8-
class WritableResourceStream extends EventEmitter implements WritableStreamInterface
8+
final class WritableResourceStream extends EventEmitter implements WritableStreamInterface
99
{
1010
private $stream;
1111
private $loop;

0 commit comments

Comments
 (0)