Skip to content

Commit b25a5c2

Browse files
committed
[dns] Use mt_rand to generate id, limit to id field size (16 bits)
1 parent bd21ef8 commit b25a5c2

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

Query/Executor.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function query($nameserver, Query $query, $callback)
3636
public function prepareRequest(Query $query)
3737
{
3838
$request = new Message();
39-
$request->header->set('id', rand());
39+
$request->header->set('id', $this->generateId());
4040
$request->header->set('rd', 1);
4141
$request->questions[] = (array) $query;
4242
$request->prepare();
@@ -79,6 +79,11 @@ public function doQuery($nameserver, $transport, $queryData, $callback)
7979
$conn->write($queryData);
8080
}
8181

82+
protected function generateId()
83+
{
84+
return mt_rand(0, 0xffff);
85+
}
86+
8287
protected function createConnection($nameserver, $transport)
8388
{
8489
$fd = stream_socket_client("$transport://$nameserver");

0 commit comments

Comments
 (0)