Skip to content

Commit 9e0b172

Browse files
committed
Fix failing test on PHP 7.4 with code coverage when skipping some tests
This only reports an error on PHP 7.4 when executed like this: $ vendor/bin/phpunit --coverage-text --exclude-group internet
1 parent 89d8379 commit 9e0b172

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

tests/FunctionalResolverTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ public function testCancelResolveShouldNotCauseGarbageReferences()
188188
$this->resolver = $factory->create('127.0.0.1', $this->loop);
189189

190190
gc_collect_cycles();
191+
gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on
191192

192193
$promise = $this->resolver->resolve('google.com');
193194
$promise->cancel();

0 commit comments

Comments
 (0)